From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F23D8C83F33 for ; Tue, 5 Sep 2023 09:03:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z7B4tBfpaQqENF+rmjtrZiYFqCxDQGRPvAFxYt01zdo=; b=YnyBSoNBW28Cif uc8E4UGeTYRetb9beAvnpHUcf/1eMaE2C2rVMzqJS3i0O6ctsFDtPCMArJRU7gU+p2sBFXaeDtco9 kaQa8RZaOYGERdlonWqXL0ON30Hj+F7zAoo4TSRcrLNGWgQqgfUug4UONhjOVkp8IKRrLxMHSjCa3 2a+GPrVh3iPDTWEN+ZzT0xHxmmqyJB6fI/jMKXTsAQVYMQaC1x3BD15cd+jiJpBT9E4yd4kDS2HPQ EwrMAjuwH8l/qmKXbhdB6GOn4b70iHUhq87l4urR5Rw8tdJM0YLzmJzgyAeFNU/fuMeIXLUhFPvJV 4k3JduHLVQev5/QkKyaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qdRxS-005bUq-2E; Tue, 05 Sep 2023 09:02:50 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qdRxQ-005bUS-0o for linux-arm-kernel@lists.infradead.org; Tue, 05 Sep 2023 09:02:49 +0000 Received: from pendragon.ideasonboard.com (ftip006315900.acc1.colindale.21cn-nte.bt.net [81.134.214.249]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8CDDE128D; Tue, 5 Sep 2023 11:01:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1693904479; bh=i5xgoAvknUQnAeBrZlobtbTH4p/BfgvRHjqgFdrRzAo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mOHafGtT3Q36EEF7HniHebrGl8NFSP2+8LDoiWnYIVMmqAIhnixtIXnLXR5cQc8ut 1w+tfxF0njauRH3r2BNE5GvHe3n0pybRvFN97mj1wlB85q1LqHnnq8qPXNIOePtBzS NN64tVqdxLSHqtJbpHR0azVqWOTCO2azMVlmxZVQ= Date: Tue, 5 Sep 2023 12:02:58 +0300 From: Laurent Pinchart To: Alain Volmat Cc: Hugues Fruchet , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Russell King , Philipp Zabel , Sakari Ailus , Dan Scally , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/5] ARM: dts: stm32: add dcmipp support to stm32mp135 Message-ID: <20230905090258.GC31594@pendragon.ideasonboard.com> References: <20230901155732.252436-1-alain.volmat@foss.st.com> <20230901155732.252436-5-alain.volmat@foss.st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230901155732.252436-5-alain.volmat@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230905_020248_435255_639B1A0B X-CRM114-Status: GOOD ( 16.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alain, Thank you for the patch. On Fri, Sep 01, 2023 at 05:57:23PM +0200, Alain Volmat wrote: > From: Hugues Fruchet > > Add dcmipp support to STM32MP135. > > Signed-off-by: Hugues Fruchet > Signed-off-by: Alain Volmat > --- > arch/arm/boot/dts/st/stm32mp135.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/st/stm32mp135.dtsi b/arch/arm/boot/dts/st/stm32mp135.dtsi > index abf2acd37b4e..beee9ec7ed0d 100644 > --- a/arch/arm/boot/dts/st/stm32mp135.dtsi > +++ b/arch/arm/boot/dts/st/stm32mp135.dtsi > @@ -8,5 +8,13 @@ > > / { > soc { > + dcmipp: dcmipp@5a000000 { > + compatible = "st,stm32mp13-dcmipp"; > + reg = <0x5a000000 0x400>; > + interrupts = ; > + resets = <&rcc DCMIPP_R>; > + clocks = <&rcc DCMIPP_K>; > + status = "disabled"; This needs a port, as it's marked as required in the bindings. You can leave the endpoint out. With this fixed, Reviewed-by: Laurent Pinchart > + }; > }; > }; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel