From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC06FCA100D for ; Tue, 5 Sep 2023 20:51:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MUFh9AeuO3vsFF9ITpB06iOvUYE2TjLP4EcIJAVw89Y=; b=VszReqkKM2+y1D 3HGwwTCO1FRuvpqVq2H7ts5g6wAZ684tm3JYWgx6Z2sxXidQjyCMEhq6pFoPcc+lYDyDlVBI0dW1B BqX+ZBLWgLF6JYnz1fxQA2glZWnM89riSSMZnBsgh9bgNpuBTANUXTcJV7XhTVkMMrxYUO5GgxHT6 OnwEFIkZyuh+d46W3lNtMSPC+2LQPtvTQie/TSrOZdSY+HYMNstxhW+2Bf6rGZbhE7SXMhCtvpg3z jNKMQI6XdhInTKTMxUt2TARcX2lV/YMEA6q5UszqXyTlXifTTlqc5DTk04JVJvz83bVLcNBw1O90P 0YHRzHbX+9Gdf+S3ghPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qdd0z-006iLr-2R; Tue, 05 Sep 2023 20:51:13 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qdd0u-006iKc-2p for linux-arm-kernel@lists.infradead.org; Tue, 05 Sep 2023 20:51:12 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EEC1B60E97; Tue, 5 Sep 2023 20:51:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAF0AC433C9; Tue, 5 Sep 2023 20:51:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693947065; bh=IAfZD62GpmBQoVGiSUG9EApPenk0Eiw2bjCJMCsRqyo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=n9LEKj/AoIxy36nnexsV6oqzkMZkl9gynD9E6ojvBpffxxQVRz816uTmHvLZg4sFo NN57OGAR0rV6mxxgUA6NAFrDnSjn9rZ8N/VxkXyq1TppUgXaBNwOo7DZZzXlOWb6rc bvAsBxk54AHgNLe3uYYw6WXw7JbXJQpjWx50HDIhL9N3bBBgxExKob/9ybRAl8nm8v 9cQd+1bLrqOuVo0qZ0jchYJlbjfpQjhz9jQxsW0Fy91wUZWx54vME6lPktNNc3dwgH Ua7q3i/fobLiaB+Wkwpbr73SlUgm1QoRAC9A0uGuF1uQltel6QeByTVXKh5PFAtCVD N7irBo0mhMZVA== Date: Tue, 5 Sep 2023 13:51:03 -0700 From: Jakub Kicinski To: Vincent Whitchurch Cc: Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Paolo Abeni , Maxime Coquelin , Felix Fietkau , Maxim Mikityanskiy , , , , , Subject: Re: [PATCH net] net: stmmac: fix handling of zero coalescing tx-usecs Message-ID: <20230905135103.04649841@kernel.org> In-Reply-To: <20230905-stmmac-coaloff-v1-1-e29820e8ff6d@axis.com> References: <20230905-stmmac-coaloff-v1-1-e29820e8ff6d@axis.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230905_135108_973339_BE209149 X-CRM114-Status: GOOD ( 12.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 5 Sep 2023 13:32:48 +0200 Vincent Whitchurch wrote: > Setting ethtool -C eth0 tx-usecs 0 is supposed to disable the use of the > coalescing timer but currently it gets programmed with zero delay > instead. > > Disable the use of the coalescing timer if tx-usecs is zero by > preventing it from being restarted. Note that to keep things simple we > don't start/stop the timer when the coalescing settings are changed, but > just let that happen on the next transmit or timer expiry. > > Fixes: 8fce33317023 ("net: stmmac: Rework coalesce timer and fix multi-queue races") > Signed-off-by: Vincent Whitchurch This does not apply cleanly to net, please rebase and repost. -- pw-bot: cr _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel