From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 612FAC83F3E for ; Tue, 5 Sep 2023 14:17:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=26vIORpHpzIQEO58M5oHvg30JSCPCpaepLIM2hLxru8=; b=eLAmghSjDU5KIP G0p874hrO9rZX736RXokVgXe/XKjkNC8CoV2AteOoYU8/Sc3NxsqtoZQQpRYu2nr+3bZXmfTNpzAI 7LA0/3kYAs8I5Xt/hYD1fS5Rg5AwuPXrDDtJNJt9Q5IgZdMqZ2sg3TMCILPhr4XOQlDmcrQwQSEv3 kYQ9Z+ZSzzwh1dgp6b9nuKrf3nYu3XjFGkfdLGT8eBxPVZwXIaeHx2UB/g2FedbV9NKth97DYtzbZ e8NVo85a8n+g5CtNBgcgHQWySGbZUskGmn+KV3zG0pgzHgcUp7FiQh5yG0E9/kG6DHxVFN4hbQzV5 kVXFijqbvvyBwrS7t76g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qdWrD-0069cY-0L; Tue, 05 Sep 2023 14:16:43 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qdWrA-0069by-2e for linux-arm-kernel@lists.infradead.org; Tue, 05 Sep 2023 14:16:42 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 82DA1CE10E7; Tue, 5 Sep 2023 14:16:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85F80C433C7; Tue, 5 Sep 2023 14:16:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693923396; bh=b1HjVkh0xrreHoeaZyylU8NoDy/+pEJYUbGeu9YyivQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TNgxVyJFRw10wginbFjErx24ryk8fp7TsmpWsX6woUBaEKADXyhU/94yz4NdLojvu tRJdysMnyBAGnkxy7VJKdggCeeXALwg7/wGl0NpvBT7wtisArgwUBcbq4EK3lQk84h dtaz6uvL+1JhRR2yH1ooWGITwqaXaKoCAq+VyH/XT1JICPRuqlpytrA9u4TM/cWLVF JOpT0wfVb421dJq9VzYLUDaBgXojNzJpWiffXCOkXQn2DmP2/EPk+DD0/InUDXHJk3 BZT0DBbjUfd+95pNid95Cd6vfLojSwo8XdT+u7Yo4rylCYqmf43gbNQOnVZBQYE1sV ldDwHY7iomENg== Date: Tue, 5 Sep 2023 15:16:31 +0100 From: Will Deacon To: Mostafa Saleh Cc: Justin Stitt , Catalin Marinas , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kees Cook , linux-hardening@vger.kernel.org Subject: Re: [PATCH v3] arm64/sysreg: refactor deprecated strncpy Message-ID: <20230905141631.GA3236@willie-the-truck> References: <20230831-strncpy-arch-arm64-v3-1-cdbb1e7ea5e1@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230905_071641_067178_B44DC3C9 X-CRM114-Status: GOOD ( 15.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 01, 2023 at 12:09:19PM +0000, Mostafa Saleh wrote: > On Thu, Aug 31, 2023 at 10:55:59PM +0000, Justin Stitt wrote: > > diff --git a/arch/arm64/kernel/idreg-override.c b/arch/arm64/kernel/idreg-override.c > > index 2fe2491b692c..3addc09f8746 100644 > > --- a/arch/arm64/kernel/idreg-override.c > > +++ b/arch/arm64/kernel/idreg-override.c > > @@ -263,8 +263,8 @@ static __init void __parse_cmdline(const char *cmdline, bool parse_aliases) > > return; > > > > len = min(len, ARRAY_SIZE(buf) - 1); > > - strncpy(buf, cmdline, len); > > - buf[len] = 0; > > + memcpy(buf, cmdline, len); > > + buf[len] = '\0'; > > > > if (strcmp(buf, "--") == 0) > > return; > > > > --- > > base-commit: 706a741595047797872e669b3101429ab8d378ef > > change-id: 20230810-strncpy-arch-arm64-1f3d328bd9b8 > > Your patch will not apply on mainline but on the revert, otherwise > > Tested-by: Mostafa Saleh If somebody can post a v4 based against mainline, then I'm happy to pick it up as a fix. Thanks. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel