[PATCH v4 1/4] dt-bindings: vendor-prefixes: Add BigTreeTech

[PATCH v4 1/4] dt-bindings: vendor-prefixes: Add BigTreeTech

[Martin Botka]

From: Martin Botka <martin.botka@somainline.org>

BigTreeTech is a company based in Shenzhen that makes
3D printers and accessories.

Add prefix for it.

Signed-off-by: Martin Botka <martin.botka@somainline.org>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes in V2:
    - Fix alphabetical order
Changes in V3,V4: none

 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index af60bf1a6664..a1f3bb7be860 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -192,6 +192,8 @@ patternProperties:
     description: BeagleBoard.org Foundation
   "^bhf,.*":
     description: Beckhoff Automation GmbH & Co. KG
+  "^bigtreetech,.*":
+    description: Shenzhen BigTree Tech Co., LTD
   "^bitmain,.*":
     description: Bitmain Technologies
   "^blutek,.*":
-- 
2.41.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 1/4] dt-bindings: vendor-prefixes: Add BigTreeTech

[Jernej Škrabec]

Dne ponedeljek, 07. avgust 2023 ob 16:53:21 CEST je Martin Botka napisal(a):
> From: Martin Botka <martin.botka@somainline.org>
> 
> BigTreeTech is a company based in Shenzhen that makes
> 3D printers and accessories.
> 
> Add prefix for it.
> 
> Signed-off-by: Martin Botka <martin.botka@somainline.org>
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej

> ---
> Changes in V2:
>     - Fix alphabetical order
> Changes in V3,V4: none
> 
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> b/Documentation/devicetree/bindings/vendor-prefixes.yaml index
> af60bf1a6664..a1f3bb7be860 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -192,6 +192,8 @@ patternProperties:
>      description: BeagleBoard.org Foundation
>    "^bhf,.*":
>      description: Beckhoff Automation GmbH & Co. KG
> +  "^bigtreetech,.*":
> +    description: Shenzhen BigTree Tech Co., LTD
>    "^bitmain,.*":
>      description: Bitmain Technologies
>    "^blutek,.*":





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v4 2/4] dt-bindings: arm: sunxi: Add BigTreeTech boards

[Martin Botka]

From: Martin Botka <martin.botka@somainline.org>

Add name & compatible for BigTreeTech Manta boards and
BigTreeTech Pi

Signed-off-by: Martin Botka <martin.botka@somainline.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes in V2:
    - Remove CB1 SoM as its own entry
    - Squash BTT Pi and manta patches into 1
Changes in V3,V4: none

 Documentation/devicetree/bindings/arm/sunxi.yaml | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
index ee8fdd2da869..b90d2a7dbe2d 100644
--- a/Documentation/devicetree/bindings/arm/sunxi.yaml
+++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
@@ -151,6 +151,17 @@ properties:
           - const: roofull,beelink-x2
           - const: allwinner,sun8i-h3
 
+      - description: BigTreeTech Manta M4/8P
+        items:
+          - const: bigtreetech,cb1-manta
+          - const: bigtreetech,cb1
+          - const: allwinner,sun50i-h616
+
+      - description: BigTreeTech Pi
+        items:
+          - const: bigtreetech,pi
+          - const: allwinner,sun50i-h616
+
       - description: Chuwi V7 CW0825
         items:
           - const: chuwi,v7-cw0825
-- 
2.41.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 2/4] dt-bindings: arm: sunxi: Add BigTreeTech boards

[Jernej Škrabec]

Dne ponedeljek, 07. avgust 2023 ob 16:53:22 CEST je Martin Botka napisal(a):
> From: Martin Botka <martin.botka@somainline.org>
> 
> Add name & compatible for BigTreeTech Manta boards and
> BigTreeTech Pi
> 
> Signed-off-by: Martin Botka <martin.botka@somainline.org>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej

> ---
> Changes in V2:
>     - Remove CB1 SoM as its own entry
>     - Squash BTT Pi and manta patches into 1
> Changes in V3,V4: none
> 
>  Documentation/devicetree/bindings/arm/sunxi.yaml | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml
> b/Documentation/devicetree/bindings/arm/sunxi.yaml index
> ee8fdd2da869..b90d2a7dbe2d 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> @@ -151,6 +151,17 @@ properties:
>            - const: roofull,beelink-x2
>            - const: allwinner,sun8i-h3
> 
> +      - description: BigTreeTech Manta M4/8P
> +        items:
> +          - const: bigtreetech,cb1-manta
> +          - const: bigtreetech,cb1
> +          - const: allwinner,sun50i-h616
> +
> +      - description: BigTreeTech Pi
> +        items:
> +          - const: bigtreetech,pi
> +          - const: allwinner,sun50i-h616
> +
>        - description: Chuwi V7 CW0825
>          items:
>            - const: chuwi,v7-cw0825





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v4 3/4] arm64: dts: allwinner: h616: Add BigTreeTech CB1 SoM & boards support

[Martin Botka]

From: Martin Botka <martin.botka@somainline.org>

CB1 is Compute Module style board that plugs into Rpi board style adapter or
Manta 3D printer boards (M4P/M8P).

The SoM features:
  - H616 SoC
  - 1GiB of RAM
  - AXP313A PMIC
  - RTL8189FTV WiFi

Boards feature:
  - 4x USB via USB2 hub (usb1 on SoM).
  - SDcard slot for loading images.
  - Ethernet port wired to the internal PHY. (100M)
  - 2x HDMI 2.0. (Only 1 usable on CB1)
  - Power and Status LEDs. (Only Status LED usable on CB1)
  - 40 pin GPIO header

Currently working:
  - Booting
  - USB
  - UART
  - MMC
  - Status LED
  - WiFi (RTL8189FS via out of tree driver)

I didnt want to duplicate things so the manta DTS can also be used on BTT pi4b adapter.
CB1 SoM has its own DTSI file in case other boards shows up that accept this SoM.

Signed-off-by: Martin Botka <martin.botka@somainline.org>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
---
Changes in V2:
    - Fixed whitespace errors
    - Move UART into carrier boards and BTT Pi
    - Remove usb1-vbus regulator
    - Fix ranges and naming of AXP313A rails
    - Add comment specifying why broken-cd in mmc0 is needed
    - Rename sdio_wifi to wifi
    - Specify in commit description that USB-OTG doesnt work
Changes in V3:
    - Add missed semicolons
    - Move model string from dtsi to board dts
    - Add cb1 compatible
    - Remove extra empty line
Changed in V4:
    - Extend the range of vcc-dram to 1.5V (1.35V max caused issues with booting up

 arch/arm64/boot/dts/allwinner/Makefile        |   1 +
 .../sun50i-h616-bigtreetech-cb1-manta.dts     |  35 +++++
 .../sun50i-h616-bigtreetech-cb1.dtsi          | 140 ++++++++++++++++++
 3 files changed, 176 insertions(+)
 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1-manta.dts
 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1.dtsi

diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile
index 6a96494a2e0a..7b386428510b 100644
--- a/arch/arm64/boot/dts/allwinner/Makefile
+++ b/arch/arm64/boot/dts/allwinner/Makefile
@@ -38,5 +38,6 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64-model-b.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6-mini.dtb
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-cb1-manta.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1-manta.dts b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1-manta.dts
new file mode 100644
index 000000000000..dbce61b355d6
--- /dev/null
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1-manta.dts
@@ -0,0 +1,35 @@
+// SPDX-License-Identifier: (GPL-2.0+ or MIT)
+/*
+ * Copyright (C) 2023 Martin Botka <martin.botka@somainline.org>.
+ */
+
+/dts-v1/;
+
+#include "sun50i-h616-bigtreetech-cb1.dtsi"
+
+/ {
+	model = "BigTreeTech CB1";
+	compatible = "bigtreetech,cb1-manta", "bigtreetech,cb1", "allwinner,sun50i-h616";
+
+	aliases {
+		serial0 = &uart0;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+};
+
+&ehci1 {
+	status = "okay";
+};
+
+&ohci1 {
+	status = "okay";
+};
+
+&uart0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&uart0_ph_pins>;
+	status = "okay";
+};
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1.dtsi
new file mode 100644
index 000000000000..5e756f217813
--- /dev/null
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1.dtsi
@@ -0,0 +1,140 @@
+// SPDX-License-Identifier: (GPL-2.0+ or MIT)
+/*
+ * Copyright (C) 2023 Martin Botka <martin.botka@somainline.org>.
+ */
+
+/dts-v1/;
+
+#include "sun50i-h616.dtsi"
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/leds/common.h>
+
+/ {
+	aliases {
+		ethernet0 = &rtl8189ftv;
+	};
+
+	leds {
+		compatible = "gpio-leds";
+
+		led-0 {
+			function = LED_FUNCTION_STATUS;
+			color = <LED_COLOR_ID_GREEN>;
+			gpios = <&pio 7 5 GPIO_ACTIVE_HIGH>; /* PH5 */
+		};
+	};
+
+	reg_vcc5v: regulator-vcc5v {
+		/* board wide 5V supply from carrier boards */
+		compatible = "regulator-fixed";
+		regulator-name = "vcc-5v";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		regulator-always-on;
+	};
+
+	reg_vcc33_wifi: vcc33-wifi {
+		/* Always on 3.3V regulator for WiFi */
+		compatible = "regulator-fixed";
+		regulator-name = "vcc33-wifi";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-always-on;
+		vin-supply = <&reg_vcc5v>;
+	};
+
+	reg_vcc_wifi_io: vcc-wifi-io {
+		/* Always on 1.8V/300mA regulator for WiFi */
+		compatible = "regulator-fixed";
+		regulator-name = "vcc-wifi-io";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+		regulator-always-on;
+		vin-supply = <&reg_vcc33_wifi>;
+	};
+
+	wifi_pwrseq: wifi-pwrseq {
+		compatible = "mmc-pwrseq-simple";
+		clocks = <&rtc 1>;
+		clock-names = "ext_clock";
+		reset-gpios = <&pio 6 18 GPIO_ACTIVE_LOW>; /* PG18 */
+		post-power-on-delay-ms = <200>;
+	};
+};
+
+&mmc0 {
+	vmmc-supply = <&reg_dldo1>;
+	/* Card detection pin is not connected */
+	broken-cd;
+	bus-width = <4>;
+	status = "okay";
+};
+
+&mmc1 {
+	vmmc-supply = <&reg_vcc33_wifi>;
+	vqmmc-supply = <&reg_vcc_wifi_io>;
+	mmc-pwrseq = <&wifi_pwrseq>;
+	bus-width = <4>;
+	non-removable;
+	mmc-ddr-1_8v;
+	status = "okay";
+
+	rtl8189ftv: wifi@1 {
+		reg = <1>;
+	};
+};
+
+&r_i2c {
+	status = "okay";
+
+	axp313a: pmic@36 {
+		compatible = "x-powers,axp313a";
+		reg = <0x36>;
+		interrupt-controller;
+		#interrupt-cells = <1>;
+
+		regulators{
+			reg_dcdc1: dcdc1 {
+				regulator-name = "vdd-gpu-sys";
+				regulator-min-microvolt = <810000>;
+				regulator-max-microvolt = <990000>;
+				regulator-always-on;
+			};
+
+			reg_dcdc2: dcdc2 {
+				regulator-name = "vdd-cpu";
+				regulator-min-microvolt = <810000>;
+				regulator-max-microvolt = <1100000>;
+				regulator-ramp-delay = <200>;
+				regulator-always-on;
+			};
+
+			reg_dcdc3: dcdc3 {
+				regulator-name = "vcc-dram";
+				regulator-min-microvolt = <1350000>;
+				regulator-max-microvolt = <1500000>;
+				regulator-always-on;
+			};
+
+			reg_aldo1: aldo1 {
+				regulator-name = "vcc-1v8-pll";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
+			};
+
+			reg_dldo1: dldo1 {
+				regulator-name = "vcc-3v3-io";
+				regulator-min-microvolt = <3300000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-always-on;
+			};
+		};
+	};
+};
+
+&usbphy {
+	status = "okay";
+};
-- 
2.41.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 3/4] arm64: dts: allwinner: h616: Add BigTreeTech CB1 SoM & boards support

[Jernej Škrabec]

Hi Martin,

since this will be obviously delayed to 6.7 cycle due to mfd patch not being 
merged in time, I have few nits below.

Dne ponedeljek, 07. avgust 2023 ob 16:53:23 CEST je Martin Botka napisal(a):
> From: Martin Botka <martin.botka@somainline.org>
> 
> CB1 is Compute Module style board that plugs into Rpi board style adapter or
> Manta 3D printer boards (M4P/M8P).
> 
> The SoM features:
>   - H616 SoC
>   - 1GiB of RAM
>   - AXP313A PMIC
>   - RTL8189FTV WiFi
> 
> Boards feature:
>   - 4x USB via USB2 hub (usb1 on SoM).
>   - SDcard slot for loading images.
>   - Ethernet port wired to the internal PHY. (100M)
>   - 2x HDMI 2.0. (Only 1 usable on CB1)
>   - Power and Status LEDs. (Only Status LED usable on CB1)
>   - 40 pin GPIO header
> 
> Currently working:
>   - Booting
>   - USB
>   - UART
>   - MMC
>   - Status LED
>   - WiFi (RTL8189FS via out of tree driver)
> 
> I didnt want to duplicate things so the manta DTS can also be used on BTT
> pi4b adapter. CB1 SoM has its own DTSI file in case other boards shows up
> that accept this SoM.
> 
> Signed-off-by: Martin Botka <martin.botka@somainline.org>
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>
> ---
> Changes in V2:
>     - Fixed whitespace errors
>     - Move UART into carrier boards and BTT Pi
>     - Remove usb1-vbus regulator
>     - Fix ranges and naming of AXP313A rails
>     - Add comment specifying why broken-cd in mmc0 is needed
>     - Rename sdio_wifi to wifi
>     - Specify in commit description that USB-OTG doesnt work
> Changes in V3:
>     - Add missed semicolons
>     - Move model string from dtsi to board dts
>     - Add cb1 compatible
>     - Remove extra empty line
> Changed in V4:
>     - Extend the range of vcc-dram to 1.5V (1.35V max caused issues with
> booting up
> 
>  arch/arm64/boot/dts/allwinner/Makefile        |   1 +
>  .../sun50i-h616-bigtreetech-cb1-manta.dts     |  35 +++++
>  .../sun50i-h616-bigtreetech-cb1.dtsi          | 140 ++++++++++++++++++
>  3 files changed, 176 insertions(+)
>  create mode 100644
> arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1-manta.dts create
> mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1.dtsi
> 
> diff --git a/arch/arm64/boot/dts/allwinner/Makefile
> b/arch/arm64/boot/dts/allwinner/Makefile index 6a96494a2e0a..7b386428510b
> 100644
> --- a/arch/arm64/boot/dts/allwinner/Makefile
> +++ b/arch/arm64/boot/dts/allwinner/Makefile
> @@ -38,5 +38,6 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64.dtb
>  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64-model-b.dtb
>  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb
>  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6-mini.dtb
> +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-cb1-manta.dtb
>  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb
>  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb
> diff --git
> a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1-manta.dts
> b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1-manta.dts new
> file mode 100644
> index 000000000000..dbce61b355d6
> --- /dev/null
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1-manta.dts
> @@ -0,0 +1,35 @@
> +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> +/*
> + * Copyright (C) 2023 Martin Botka <martin.botka@somainline.org>.
> + */
> +
> +/dts-v1/;
> +
> +#include "sun50i-h616-bigtreetech-cb1.dtsi"
> +
> +/ {
> +	model = "BigTreeTech CB1";
> +	compatible = "bigtreetech,cb1-manta", "bigtreetech,cb1",
> "allwinner,sun50i-h616"; +
> +	aliases {
> +		serial0 = &uart0;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
> +};
> +
> +&ehci1 {
> +	status = "okay";
> +};
> +
> +&ohci1 {
> +	status = "okay";
> +};
> +
> +&uart0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&uart0_ph_pins>;
> +	status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1.dtsi
> b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1.dtsi new file
> mode 100644
> index 000000000000..5e756f217813
> --- /dev/null
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1.dtsi
> @@ -0,0 +1,140 @@
> +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> +/*
> + * Copyright (C) 2023 Martin Botka <martin.botka@somainline.org>.
> + */
> +
> +/dts-v1/;
> +
> +#include "sun50i-h616.dtsi"
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/leds/common.h>
> +
> +/ {
> +	aliases {
> +		ethernet0 = &rtl8189ftv;
> +	};
> +
> +	leds {
> +		compatible = "gpio-leds";
> +
> +		led-0 {
> +			function = LED_FUNCTION_STATUS;
> +			color = <LED_COLOR_ID_GREEN>;
> +			gpios = <&pio 7 5 GPIO_ACTIVE_HIGH>; /* PH5 
*/
> +		};
> +	};
> +
> +	reg_vcc5v: regulator-vcc5v {
> +		/* board wide 5V supply from carrier boards */
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc-5v";
> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +		regulator-always-on;
> +	};
> +
> +	reg_vcc33_wifi: vcc33-wifi {
> +		/* Always on 3.3V regulator for WiFi */

Please drop the comment. It's pretty obvious from properties.

> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc33-wifi";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		regulator-always-on;
> +		vin-supply = <&reg_vcc5v>;
> +	};
> +
> +	reg_vcc_wifi_io: vcc-wifi-io {
> +		/* Always on 1.8V/300mA regulator for WiFi */

Ditto.

Once fixed, you can add:
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej

> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc-wifi-io";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +		regulator-always-on;
> +		vin-supply = <&reg_vcc33_wifi>;
> +	};
> +
> +	wifi_pwrseq: wifi-pwrseq {
> +		compatible = "mmc-pwrseq-simple";
> +		clocks = <&rtc 1>;
> +		clock-names = "ext_clock";
> +		reset-gpios = <&pio 6 18 GPIO_ACTIVE_LOW>; /* PG18 */
> +		post-power-on-delay-ms = <200>;
> +	};
> +};
> +
> +&mmc0 {
> +	vmmc-supply = <&reg_dldo1>;
> +	/* Card detection pin is not connected */
> +	broken-cd;
> +	bus-width = <4>;
> +	status = "okay";
> +};
> +
> +&mmc1 {
> +	vmmc-supply = <&reg_vcc33_wifi>;
> +	vqmmc-supply = <&reg_vcc_wifi_io>;
> +	mmc-pwrseq = <&wifi_pwrseq>;
> +	bus-width = <4>;
> +	non-removable;
> +	mmc-ddr-1_8v;
> +	status = "okay";
> +
> +	rtl8189ftv: wifi@1 {
> +		reg = <1>;
> +	};
> +};
> +
> +&r_i2c {
> +	status = "okay";
> +
> +	axp313a: pmic@36 {
> +		compatible = "x-powers,axp313a";
> +		reg = <0x36>;
> +		interrupt-controller;
> +		#interrupt-cells = <1>;
> +
> +		regulators{
> +			reg_dcdc1: dcdc1 {
> +				regulator-name = "vdd-gpu-sys";
> +				regulator-min-microvolt = 
<810000>;
> +				regulator-max-microvolt = 
<990000>;
> +				regulator-always-on;
> +			};
> +
> +			reg_dcdc2: dcdc2 {
> +				regulator-name = "vdd-cpu";
> +				regulator-min-microvolt = 
<810000>;
> +				regulator-max-microvolt = 
<1100000>;
> +				regulator-ramp-delay = <200>;
> +				regulator-always-on;
> +			};
> +
> +			reg_dcdc3: dcdc3 {
> +				regulator-name = "vcc-dram";
> +				regulator-min-microvolt = 
<1350000>;
> +				regulator-max-microvolt = 
<1500000>;
> +				regulator-always-on;
> +			};
> +
> +			reg_aldo1: aldo1 {
> +				regulator-name = "vcc-1v8-pll";
> +				regulator-min-microvolt = 
<1800000>;
> +				regulator-max-microvolt = 
<1800000>;
> +				regulator-always-on;
> +			};
> +
> +			reg_dldo1: dldo1 {
> +				regulator-name = "vcc-3v3-io";
> +				regulator-min-microvolt = 
<3300000>;
> +				regulator-max-microvolt = 
<3300000>;
> +				regulator-always-on;
> +			};
> +		};
> +	};
> +};
> +
> +&usbphy {
> +	status = "okay";
> +};





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 3/4] arm64: dts: allwinner: h616: Add BigTreeTech CB1 SoM & boards support

[Martin Botka]

On Sun, Aug 13 2023 at 05:52:10 PM +02:00:00, Jernej Škrabec 
<jernej.skrabec@gmail.com> wrote:
> Hi Martin,
> 
> since this will be obviously delayed to 6.7 cycle due to mfd patch 
> not being
> merged in time, I have few nits below.
> 
> Dne ponedeljek, 07. avgust 2023 ob 16:53:23 CEST je Martin Botka 
> napisal(a):
>>  From: Martin Botka <martin.botka@somainline.org>
>> 
>>  CB1 is Compute Module style board that plugs into Rpi board style 
>> adapter or
>>  Manta 3D printer boards (M4P/M8P).
>> 
>>  The SoM features:
>>    - H616 SoC
>>    - 1GiB of RAM
>>    - AXP313A PMIC
>>    - RTL8189FTV WiFi
>> 
>>  Boards feature:
>>    - 4x USB via USB2 hub (usb1 on SoM).
>>    - SDcard slot for loading images.
>>    - Ethernet port wired to the internal PHY. (100M)
>>    - 2x HDMI 2.0. (Only 1 usable on CB1)
>>    - Power and Status LEDs. (Only Status LED usable on CB1)
>>    - 40 pin GPIO header
>> 
>>  Currently working:
>>    - Booting
>>    - USB
>>    - UART
>>    - MMC
>>    - Status LED
>>    - WiFi (RTL8189FS via out of tree driver)
>> 
>>  I didnt want to duplicate things so the manta DTS can also be used 
>> on BTT
>>  pi4b adapter. CB1 SoM has its own DTSI file in case other boards 
>> shows up
>>  that accept this SoM.
>> 
>>  Signed-off-by: Martin Botka <martin.botka@somainline.org>
>>  Reviewed-by: Andre Przywara <andre.przywara@arm.com>
>>  ---
>>  Changes in V2:
>>      - Fixed whitespace errors
>>      - Move UART into carrier boards and BTT Pi
>>      - Remove usb1-vbus regulator
>>      - Fix ranges and naming of AXP313A rails
>>      - Add comment specifying why broken-cd in mmc0 is needed
>>      - Rename sdio_wifi to wifi
>>      - Specify in commit description that USB-OTG doesnt work
>>  Changes in V3:
>>      - Add missed semicolons
>>      - Move model string from dtsi to board dts
>>      - Add cb1 compatible
>>      - Remove extra empty line
>>  Changed in V4:
>>      - Extend the range of vcc-dram to 1.5V (1.35V max caused issues 
>> with
>>  booting up
>> 
>>   arch/arm64/boot/dts/allwinner/Makefile        |   1 +
>>   .../sun50i-h616-bigtreetech-cb1-manta.dts     |  35 +++++
>>   .../sun50i-h616-bigtreetech-cb1.dtsi          | 140 
>> ++++++++++++++++++
>>   3 files changed, 176 insertions(+)
>>   create mode 100644
>>  arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1-manta.dts 
>> create
>>  mode 100644 
>> arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1.dtsi
>> 
>>  diff --git a/arch/arm64/boot/dts/allwinner/Makefile
>>  b/arch/arm64/boot/dts/allwinner/Makefile index 
>> 6a96494a2e0a..7b386428510b
>>  100644
>>  --- a/arch/arm64/boot/dts/allwinner/Makefile
>>  +++ b/arch/arm64/boot/dts/allwinner/Makefile
>>  @@ -38,5 +38,6 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64.dtb
>>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64-model-b.dtb
>>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb
>>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6-mini.dtb
>>  +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-cb1-manta.dtb
>>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb
>>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb
>>  diff --git
>>  
>> a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1-manta.dts
>>  
>> b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1-manta.dts 
>> new
>>  file mode 100644
>>  index 000000000000..dbce61b355d6
>>  --- /dev/null
>>  +++ 
>> b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1-manta.dts
>>  @@ -0,0 +1,35 @@
>>  +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
>>  +/*
>>  + * Copyright (C) 2023 Martin Botka <martin.botka@somainline.org>.
>>  + */
>>  +
>>  +/dts-v1/;
>>  +
>>  +#include "sun50i-h616-bigtreetech-cb1.dtsi"
>>  +
>>  +/ {
>>  +	model = "BigTreeTech CB1";
>>  +	compatible = "bigtreetech,cb1-manta", "bigtreetech,cb1",
>>  "allwinner,sun50i-h616"; +
>>  +	aliases {
>>  +		serial0 = &uart0;
>>  +	};
>>  +
>>  +	chosen {
>>  +		stdout-path = "serial0:115200n8";
>>  +	};
>>  +};
>>  +
>>  +&ehci1 {
>>  +	status = "okay";
>>  +};
>>  +
>>  +&ohci1 {
>>  +	status = "okay";
>>  +};
>>  +
>>  +&uart0 {
>>  +	pinctrl-names = "default";
>>  +	pinctrl-0 = <&uart0_ph_pins>;
>>  +	status = "okay";
>>  +};
>>  diff --git 
>> a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1.dtsi
>>  b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1.dtsi 
>> new file
>>  mode 100644
>>  index 000000000000..5e756f217813
>>  --- /dev/null
>>  +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1.dtsi
>>  @@ -0,0 +1,140 @@
>>  +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
>>  +/*
>>  + * Copyright (C) 2023 Martin Botka <martin.botka@somainline.org>.
>>  + */
>>  +
>>  +/dts-v1/;
>>  +
>>  +#include "sun50i-h616.dtsi"
>>  +
>>  +#include <dt-bindings/gpio/gpio.h>
>>  +#include <dt-bindings/interrupt-controller/arm-gic.h>
>>  +#include <dt-bindings/leds/common.h>
>>  +
>>  +/ {
>>  +	aliases {
>>  +		ethernet0 = &rtl8189ftv;
>>  +	};
>>  +
>>  +	leds {
>>  +		compatible = "gpio-leds";
>>  +
>>  +		led-0 {
>>  +			function = LED_FUNCTION_STATUS;
>>  +			color = <LED_COLOR_ID_GREEN>;
>>  +			gpios = <&pio 7 5 GPIO_ACTIVE_HIGH>; /* PH5
> */
>>  +		};
>>  +	};
>>  +
>>  +	reg_vcc5v: regulator-vcc5v {
>>  +		/* board wide 5V supply from carrier boards */
>>  +		compatible = "regulator-fixed";
>>  +		regulator-name = "vcc-5v";
>>  +		regulator-min-microvolt = <5000000>;
>>  +		regulator-max-microvolt = <5000000>;
>>  +		regulator-always-on;
>>  +	};
>>  +
>>  +	reg_vcc33_wifi: vcc33-wifi {
>>  +		/* Always on 3.3V regulator for WiFi */
> 
> Please drop the comment. It's pretty obvious from properties.
> 
>>  +		compatible = "regulator-fixed";
>>  +		regulator-name = "vcc33-wifi";
>>  +		regulator-min-microvolt = <3300000>;
>>  +		regulator-max-microvolt = <3300000>;
>>  +		regulator-always-on;
>>  +		vin-supply = <&reg_vcc5v>;
>>  +	};
>>  +
>>  +	reg_vcc_wifi_io: vcc-wifi-io {
>>  +		/* Always on 1.8V/300mA regulator for WiFi */
> 
> Ditto.
> 
> Once fixed, you can add:
> Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> 
> Best regards,
> Jernej
Got it for both comments. Will send V5 tomorrow.

Cheers,
Martin
> 
>>  +		compatible = "regulator-fixed";
>>  +		regulator-name = "vcc-wifi-io";
>>  +		regulator-min-microvolt = <1800000>;
>>  +		regulator-max-microvolt = <1800000>;
>>  +		regulator-always-on;
>>  +		vin-supply = <&reg_vcc33_wifi>;
>>  +	};
>>  +
>>  +	wifi_pwrseq: wifi-pwrseq {
>>  +		compatible = "mmc-pwrseq-simple";
>>  +		clocks = <&rtc 1>;
>>  +		clock-names = "ext_clock";
>>  +		reset-gpios = <&pio 6 18 GPIO_ACTIVE_LOW>; /* PG18 */
>>  +		post-power-on-delay-ms = <200>;
>>  +	};
>>  +};
>>  +
>>  +&mmc0 {
>>  +	vmmc-supply = <&reg_dldo1>;
>>  +	/* Card detection pin is not connected */
>>  +	broken-cd;
>>  +	bus-width = <4>;
>>  +	status = "okay";
>>  +};
>>  +
>>  +&mmc1 {
>>  +	vmmc-supply = <&reg_vcc33_wifi>;
>>  +	vqmmc-supply = <&reg_vcc_wifi_io>;
>>  +	mmc-pwrseq = <&wifi_pwrseq>;
>>  +	bus-width = <4>;
>>  +	non-removable;
>>  +	mmc-ddr-1_8v;
>>  +	status = "okay";
>>  +
>>  +	rtl8189ftv: wifi@1 {
>>  +		reg = <1>;
>>  +	};
>>  +};
>>  +
>>  +&r_i2c {
>>  +	status = "okay";
>>  +
>>  +	axp313a: pmic@36 {
>>  +		compatible = "x-powers,axp313a";
>>  +		reg = <0x36>;
>>  +		interrupt-controller;
>>  +		#interrupt-cells = <1>;
>>  +
>>  +		regulators{
>>  +			reg_dcdc1: dcdc1 {
>>  +				regulator-name = "vdd-gpu-sys";
>>  +				regulator-min-microvolt =
> <810000>;
>>  +				regulator-max-microvolt =
> <990000>;
>>  +				regulator-always-on;
>>  +			};
>>  +
>>  +			reg_dcdc2: dcdc2 {
>>  +				regulator-name = "vdd-cpu";
>>  +				regulator-min-microvolt =
> <810000>;
>>  +				regulator-max-microvolt =
> <1100000>;
>>  +				regulator-ramp-delay = <200>;
>>  +				regulator-always-on;
>>  +			};
>>  +
>>  +			reg_dcdc3: dcdc3 {
>>  +				regulator-name = "vcc-dram";
>>  +				regulator-min-microvolt =
> <1350000>;
>>  +				regulator-max-microvolt =
> <1500000>;
>>  +				regulator-always-on;
>>  +			};
>>  +
>>  +			reg_aldo1: aldo1 {
>>  +				regulator-name = "vcc-1v8-pll";
>>  +				regulator-min-microvolt =
> <1800000>;
>>  +				regulator-max-microvolt =
> <1800000>;
>>  +				regulator-always-on;
>>  +			};
>>  +
>>  +			reg_dldo1: dldo1 {
>>  +				regulator-name = "vcc-3v3-io";
>>  +				regulator-min-microvolt =
> <3300000>;
>>  +				regulator-max-microvolt =
> <3300000>;
>>  +				regulator-always-on;
>>  +			};
>>  +		};
>>  +	};
>>  +};
>>  +
>>  +&usbphy {
>>  +	status = "okay";
>>  +};
> 
> 
> 
> 



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 3/4] arm64: dts: allwinner: h616: Add BigTreeTech CB1 SoM & boards support

[Jernej Škrabec]

Dne nedelja, 13. avgust 2023 ob 18:20:00 CEST je Martin Botka napisal(a):
> On Sun, Aug 13 2023 at 05:52:10 PM +02:00:00, Jernej Škrabec
> 
> <jernej.skrabec@gmail.com> wrote:
> > Hi Martin,
> > 
> > since this will be obviously delayed to 6.7 cycle due to mfd patch
> > not being
> > merged in time, I have few nits below.
> > 
> > Dne ponedeljek, 07. avgust 2023 ob 16:53:23 CEST je Martin Botka
> > 
> > napisal(a):
> >>  From: Martin Botka <martin.botka@somainline.org>
> >>  
> >>  CB1 is Compute Module style board that plugs into Rpi board style
> >> 
> >> adapter or
> >> 
> >>  Manta 3D printer boards (M4P/M8P).
> >>  
> >>  The SoM features:
> >>    - H616 SoC
> >>    - 1GiB of RAM
> >>    - AXP313A PMIC
> >>    - RTL8189FTV WiFi
> >>  
> >>  Boards feature:
> >>    - 4x USB via USB2 hub (usb1 on SoM).
> >>    - SDcard slot for loading images.
> >>    - Ethernet port wired to the internal PHY. (100M)
> >>    - 2x HDMI 2.0. (Only 1 usable on CB1)
> >>    - Power and Status LEDs. (Only Status LED usable on CB1)
> >>    - 40 pin GPIO header
> >>  
> >>  Currently working:
> >>    - Booting
> >>    - USB
> >>    - UART
> >>    - MMC
> >>    - Status LED
> >>    - WiFi (RTL8189FS via out of tree driver)
> >>  
> >>  I didnt want to duplicate things so the manta DTS can also be used
> >> 
> >> on BTT
> >> 
> >>  pi4b adapter. CB1 SoM has its own DTSI file in case other boards
> >> 
> >> shows up
> >> 
> >>  that accept this SoM.
> >>  
> >>  Signed-off-by: Martin Botka <martin.botka@somainline.org>
> >>  Reviewed-by: Andre Przywara <andre.przywara@arm.com>
> >>  ---
> >>  
> >>  Changes in V2:
> >>      - Fixed whitespace errors
> >>      - Move UART into carrier boards and BTT Pi
> >>      - Remove usb1-vbus regulator
> >>      - Fix ranges and naming of AXP313A rails
> >>      - Add comment specifying why broken-cd in mmc0 is needed
> >>      - Rename sdio_wifi to wifi
> >>      - Specify in commit description that USB-OTG doesnt work
> >>  
> >>  Changes in V3:
> >>      - Add missed semicolons
> >>      - Move model string from dtsi to board dts
> >>      - Add cb1 compatible
> >>      - Remove extra empty line
> >>  
> >>  Changed in V4:
> >>      - Extend the range of vcc-dram to 1.5V (1.35V max caused issues
> >> 
> >> with
> >> 
> >>  booting up
> >>  
> >>   arch/arm64/boot/dts/allwinner/Makefile        |   1 +
> >>   .../sun50i-h616-bigtreetech-cb1-manta.dts     |  35 +++++
> >>   .../sun50i-h616-bigtreetech-cb1.dtsi          | 140
> >> 
> >> ++++++++++++++++++
> >> 
> >>   3 files changed, 176 insertions(+)
> >>   create mode 100644
> >>  
> >>  arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1-manta.dts
> >> 
> >> create
> >> 
> >>  mode 100644
> >> 
> >> arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1.dtsi
> >> 
> >>  diff --git a/arch/arm64/boot/dts/allwinner/Makefile
> >>  b/arch/arm64/boot/dts/allwinner/Makefile index
> >> 
> >> 6a96494a2e0a..7b386428510b
> >> 
> >>  100644
> >>  --- a/arch/arm64/boot/dts/allwinner/Makefile
> >>  +++ b/arch/arm64/boot/dts/allwinner/Makefile
> >>  @@ -38,5 +38,6 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64.dtb
> >>  
> >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64-model-b.dtb
> >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb
> >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6-mini.dtb
> >>  
> >>  +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-cb1-manta.dtb
> >>  
> >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb
> >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb
> >>  
> >>  diff --git
> >> 
> >> a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1-manta.dts
> >> 
> >> b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1-manta.dts
> >> new
> >> 
> >>  file mode 100644
> >>  index 000000000000..dbce61b355d6
> >>  --- /dev/null
> >>  +++
> >> 
> >> b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1-manta.dts
> >> 
> >>  @@ -0,0 +1,35 @@
> >>  +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> >>  +/*
> >>  + * Copyright (C) 2023 Martin Botka <martin.botka@somainline.org>.
> >>  + */
> >>  +
> >>  +/dts-v1/;
> >>  +
> >>  +#include "sun50i-h616-bigtreetech-cb1.dtsi"
> >>  +
> >>  +/ {
> >>  +	model = "BigTreeTech CB1";
> >>  +	compatible = "bigtreetech,cb1-manta", "bigtreetech,cb1",
> >>  "allwinner,sun50i-h616"; +
> >>  +	aliases {
> >>  +		serial0 = &uart0;
> >>  +	};
> >>  +
> >>  +	chosen {
> >>  +		stdout-path = "serial0:115200n8";
> >>  +	};
> >>  +};
> >>  +
> >>  +&ehci1 {
> >>  +	status = "okay";
> >>  +};
> >>  +
> >>  +&ohci1 {
> >>  +	status = "okay";
> >>  +};
> >>  +
> >>  +&uart0 {
> >>  +	pinctrl-names = "default";
> >>  +	pinctrl-0 = <&uart0_ph_pins>;
> >>  +	status = "okay";
> >>  +};
> >>  diff --git
> >> 
> >> a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1.dtsi
> >> 
> >>  b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1.dtsi
> >> 
> >> new file
> >> 
> >>  mode 100644
> >>  index 000000000000..5e756f217813
> >>  --- /dev/null
> >>  +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-cb1.dtsi
> >>  @@ -0,0 +1,140 @@
> >>  +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> >>  +/*
> >>  + * Copyright (C) 2023 Martin Botka <martin.botka@somainline.org>.
> >>  + */
> >>  +
> >>  +/dts-v1/;
> >>  +
> >>  +#include "sun50i-h616.dtsi"
> >>  +
> >>  +#include <dt-bindings/gpio/gpio.h>
> >>  +#include <dt-bindings/interrupt-controller/arm-gic.h>
> >>  +#include <dt-bindings/leds/common.h>
> >>  +
> >>  +/ {
> >>  +	aliases {
> >>  +		ethernet0 = &rtl8189ftv;
> >>  +	};
> >>  +
> >>  +	leds {
> >>  +		compatible = "gpio-leds";
> >>  +
> >>  +		led-0 {
> >>  +			function = LED_FUNCTION_STATUS;
> >>  +			color = <LED_COLOR_ID_GREEN>;
> >>  +			gpios = <&pio 7 5 GPIO_ACTIVE_HIGH>; /* PH5
> > 
> > */
> > 
> >>  +		};
> >>  +	};
> >>  +
> >>  +	reg_vcc5v: regulator-vcc5v {
> >>  +		/* board wide 5V supply from carrier boards */
> >>  +		compatible = "regulator-fixed";
> >>  +		regulator-name = "vcc-5v";
> >>  +		regulator-min-microvolt = <5000000>;
> >>  +		regulator-max-microvolt = <5000000>;
> >>  +		regulator-always-on;
> >>  +	};
> >>  +
> >>  +	reg_vcc33_wifi: vcc33-wifi {
> >>  +		/* Always on 3.3V regulator for WiFi */
> > 
> > Please drop the comment. It's pretty obvious from properties.
> > 
> >>  +		compatible = "regulator-fixed";
> >>  +		regulator-name = "vcc33-wifi";
> >>  +		regulator-min-microvolt = <3300000>;
> >>  +		regulator-max-microvolt = <3300000>;
> >>  +		regulator-always-on;
> >>  +		vin-supply = <&reg_vcc5v>;
> >>  +	};
> >>  +
> >>  +	reg_vcc_wifi_io: vcc-wifi-io {
> >>  +		/* Always on 1.8V/300mA regulator for WiFi */
> > 
> > Ditto.
> > 
> > Once fixed, you can add:
> > Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> > 
> > Best regards,
> > Jernej
> 
> Got it for both comments. Will send V5 tomorrow.

You should not send new versions before all discussions are finished, in this 
case for adxl345. If in doubt, ask, but certainly wait on response.

Best regards,
Jernej

> 
> Cheers,
> Martin
> 
> >>  +		compatible = "regulator-fixed";
> >>  +		regulator-name = "vcc-wifi-io";
> >>  +		regulator-min-microvolt = <1800000>;
> >>  +		regulator-max-microvolt = <1800000>;
> >>  +		regulator-always-on;
> >>  +		vin-supply = <&reg_vcc33_wifi>;
> >>  +	};
> >>  +
> >>  +	wifi_pwrseq: wifi-pwrseq {
> >>  +		compatible = "mmc-pwrseq-simple";
> >>  +		clocks = <&rtc 1>;
> >>  +		clock-names = "ext_clock";
> >>  +		reset-gpios = <&pio 6 18 GPIO_ACTIVE_LOW>; /* PG18 */
> >>  +		post-power-on-delay-ms = <200>;
> >>  +	};
> >>  +};
> >>  +
> >>  +&mmc0 {
> >>  +	vmmc-supply = <&reg_dldo1>;
> >>  +	/* Card detection pin is not connected */
> >>  +	broken-cd;
> >>  +	bus-width = <4>;
> >>  +	status = "okay";
> >>  +};
> >>  +
> >>  +&mmc1 {
> >>  +	vmmc-supply = <&reg_vcc33_wifi>;
> >>  +	vqmmc-supply = <&reg_vcc_wifi_io>;
> >>  +	mmc-pwrseq = <&wifi_pwrseq>;
> >>  +	bus-width = <4>;
> >>  +	non-removable;
> >>  +	mmc-ddr-1_8v;
> >>  +	status = "okay";
> >>  +
> >>  +	rtl8189ftv: wifi@1 {
> >>  +		reg = <1>;
> >>  +	};
> >>  +};
> >>  +
> >>  +&r_i2c {
> >>  +	status = "okay";
> >>  +
> >>  +	axp313a: pmic@36 {
> >>  +		compatible = "x-powers,axp313a";
> >>  +		reg = <0x36>;
> >>  +		interrupt-controller;
> >>  +		#interrupt-cells = <1>;
> >>  +
> >>  +		regulators{
> >>  +			reg_dcdc1: dcdc1 {
> >>  +				regulator-name = "vdd-gpu-sys";
> >>  +				regulator-min-microvolt =
> > 
> > <810000>;
> > 
> >>  +				regulator-max-microvolt =
> > 
> > <990000>;
> > 
> >>  +				regulator-always-on;
> >>  +			};
> >>  +
> >>  +			reg_dcdc2: dcdc2 {
> >>  +				regulator-name = "vdd-cpu";
> >>  +				regulator-min-microvolt =
> > 
> > <810000>;
> > 
> >>  +				regulator-max-microvolt =
> > 
> > <1100000>;
> > 
> >>  +				regulator-ramp-delay = <200>;
> >>  +				regulator-always-on;
> >>  +			};
> >>  +
> >>  +			reg_dcdc3: dcdc3 {
> >>  +				regulator-name = "vcc-dram";
> >>  +				regulator-min-microvolt =
> > 
> > <1350000>;
> > 
> >>  +				regulator-max-microvolt =
> > 
> > <1500000>;
> > 
> >>  +				regulator-always-on;
> >>  +			};
> >>  +
> >>  +			reg_aldo1: aldo1 {
> >>  +				regulator-name = "vcc-1v8-pll";
> >>  +				regulator-min-microvolt =
> > 
> > <1800000>;
> > 
> >>  +				regulator-max-microvolt =
> > 
> > <1800000>;
> > 
> >>  +				regulator-always-on;
> >>  +			};
> >>  +
> >>  +			reg_dldo1: dldo1 {
> >>  +				regulator-name = "vcc-3v3-io";
> >>  +				regulator-min-microvolt =
> > 
> > <3300000>;
> > 
> >>  +				regulator-max-microvolt =
> > 
> > <3300000>;
> > 
> >>  +				regulator-always-on;
> >>  +			};
> >>  +		};
> >>  +	};
> >>  +};
> >>  +
> >>  +&usbphy {
> >>  +	status = "okay";
> >>  +};





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v4 4/4] arm64: dts: allwinner: h616: Add BigTreeTech Pi support

[Martin Botka]

The BigTreeTech Pi is an H616 based board based on CB1.
Just in Rpi format board.

It features the same internals as BTT CB1 but adds:
    - Fan port
    - IR receiver
    - ADXL345 Accelerometer connector via SPI
    - 24V DC power supply via terminal plugs
    - USB to CAN module connector (The actual USB to CAN happens on the external module)

List of currently working things is same as BTT CB1 but also:
    - IR receiver
    - ADXL345 connector

Signed-off-by: Martin Botka <martin@biqu3d.com>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
---
Changes in V2:
    - Add UART alongside aliases and chosen for it
    - Add model string
    - Enable IR receiver
    - Enable SPI0 for ADXL345 connector
Changes in V3:
    - Add missing semicolons
    - Add pinctrl for SPI0

 arch/arm64/boot/dts/allwinner/Makefile        |  1 +
 .../allwinner/sun50i-h616-bigtreetech-pi.dts  | 70 +++++++++++++++++++
 2 files changed, 71 insertions(+)
 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts

diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile
index 7b386428510b..0b6232a7f328 100644
--- a/arch/arm64/boot/dts/allwinner/Makefile
+++ b/arch/arm64/boot/dts/allwinner/Makefile
@@ -39,5 +39,6 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64-model-b.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6-mini.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-cb1-manta.dtb
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-pi.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
new file mode 100644
index 000000000000..b0d0386e8f13
--- /dev/null
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
@@ -0,0 +1,70 @@
+// SPDX-License-Identifier: (GPL-2.0+ or MIT)
+/*
+ * Copyright (C) 2023 Martin Botka <martin@biqu3d.com>.
+ */
+
+/dts-v1/;
+
+#include "sun50i-h616-bigtreetech-cb1.dtsi"
+
+/ {
+	model = "BigTreeTech Pi";
+	compatible = "bigtreetech,pi", "allwinner,sun50i-h616";
+
+	aliases {
+		serial0 = &uart0;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+};
+
+&ehci0 {
+	status = "okay";
+};
+
+&ehci1 {
+	status = "okay";
+};
+
+&ehci2 {
+	status = "okay";
+};
+
+&ehci3 {
+	status = "okay";
+};
+
+&ir {
+	status = "okay";
+};
+
+&ohci0 {
+	status = "okay";
+};
+
+&ohci1 {
+	status = "okay";
+};
+
+&ohci2 {
+	status = "okay";
+};
+
+&ohci3 {
+	status = "okay";
+};
+
+&spi0 {
+	/* SPI connection for onboard connector for ADXL345 accelerometer */
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&spi0_pins>, <&spi0_cs0_pin>;
+};
+
+&uart0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&uart0_ph_pins>;
+	status = "okay";
+};
-- 
2.41.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 4/4] arm64: dts: allwinner: h616: Add BigTreeTech Pi support

[Martin Botka]

Forgot to mark it but no changes from v3 in this patch.

On 8/7/23 4:53 PM, Martin Botka wrote:
> The BigTreeTech Pi is an H616 based board based on CB1.
> Just in Rpi format board.
> 
> It features the same internals as BTT CB1 but adds:
>      - Fan port
>      - IR receiver
>      - ADXL345 Accelerometer connector via SPI
>      - 24V DC power supply via terminal plugs
>      - USB to CAN module connector (The actual USB to CAN happens on the external module)
> 
> List of currently working things is same as BTT CB1 but also:
>      - IR receiver
>      - ADXL345 connector
> 
> Signed-off-by: Martin Botka <martin@biqu3d.com>
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>
> ---
> Changes in V2:
>      - Add UART alongside aliases and chosen for it
>      - Add model string
>      - Enable IR receiver
>      - Enable SPI0 for ADXL345 connector
> Changes in V3:
>      - Add missing semicolons
>      - Add pinctrl for SPI0
> 
>   arch/arm64/boot/dts/allwinner/Makefile        |  1 +
>   .../allwinner/sun50i-h616-bigtreetech-pi.dts  | 70 +++++++++++++++++++
>   2 files changed, 71 insertions(+)
>   create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> 
> diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile
> index 7b386428510b..0b6232a7f328 100644
> --- a/arch/arm64/boot/dts/allwinner/Makefile
> +++ b/arch/arm64/boot/dts/allwinner/Makefile
> @@ -39,5 +39,6 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64-model-b.dtb
>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb
>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6-mini.dtb
>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-cb1-manta.dtb
> +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-pi.dtb
>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb
>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> new file mode 100644
> index 000000000000..b0d0386e8f13
> --- /dev/null
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> @@ -0,0 +1,70 @@
> +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> +/*
> + * Copyright (C) 2023 Martin Botka <martin@biqu3d.com>.
> + */
> +
> +/dts-v1/;
> +
> +#include "sun50i-h616-bigtreetech-cb1.dtsi"
> +
> +/ {
> +	model = "BigTreeTech Pi";
> +	compatible = "bigtreetech,pi", "allwinner,sun50i-h616";
> +
> +	aliases {
> +		serial0 = &uart0;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
> +};
> +
> +&ehci0 {
> +	status = "okay";
> +};
> +
> +&ehci1 {
> +	status = "okay";
> +};
> +
> +&ehci2 {
> +	status = "okay";
> +};
> +
> +&ehci3 {
> +	status = "okay";
> +};
> +
> +&ir {
> +	status = "okay";
> +};
> +
> +&ohci0 {
> +	status = "okay";
> +};
> +
> +&ohci1 {
> +	status = "okay";
> +};
> +
> +&ohci2 {
> +	status = "okay";
> +};
> +
> +&ohci3 {
> +	status = "okay";
> +};
> +
> +&spi0 {
> +	/* SPI connection for onboard connector for ADXL345 accelerometer */
> +	status = "okay";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&spi0_pins>, <&spi0_cs0_pin>;
> +};
> +
> +&uart0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&uart0_ph_pins>;
> +	status = "okay";
> +};

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 4/4] arm64: dts: allwinner: h616: Add BigTreeTech Pi support

[Icenowy Zheng]

在 2023-08-07星期一的 16:53 +0200，Martin Botka写道：
> The BigTreeTech Pi is an H616 based board based on CB1.
> Just in Rpi format board.
> 
> It features the same internals as BTT CB1 but adds:
>     - Fan port
>     - IR receiver
>     - ADXL345 Accelerometer connector via SPI
>     - 24V DC power supply via terminal plugs
>     - USB to CAN module connector (The actual USB to CAN happens on
> the external module)
> 
> List of currently working things is same as BTT CB1 but also:
>     - IR receiver
>     - ADXL345 connector
> 
> Signed-off-by: Martin Botka <martin@biqu3d.com>
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>
> ---
> Changes in V2:
>     - Add UART alongside aliases and chosen for it
>     - Add model string
>     - Enable IR receiver
>     - Enable SPI0 for ADXL345 connector
> Changes in V3:
>     - Add missing semicolons
>     - Add pinctrl for SPI0
> 
>  arch/arm64/boot/dts/allwinner/Makefile        |  1 +
>  .../allwinner/sun50i-h616-bigtreetech-pi.dts  | 70
> +++++++++++++++++++
>  2 files changed, 71 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h616-
> bigtreetech-pi.dts
> 
> diff --git a/arch/arm64/boot/dts/allwinner/Makefile
> b/arch/arm64/boot/dts/allwinner/Makefile
> index 7b386428510b..0b6232a7f328 100644
> --- a/arch/arm64/boot/dts/allwinner/Makefile
> +++ b/arch/arm64/boot/dts/allwinner/Makefile
> @@ -39,5 +39,6 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64-
> model-b.dtb
>  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb
>  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6-mini.dtb
>  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-cb1-manta.dtb
> +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-pi.dtb
>  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb
>  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-
> pi.dts b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> new file mode 100644
> index 000000000000..b0d0386e8f13
> --- /dev/null
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> @@ -0,0 +1,70 @@
> +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> +/*
> + * Copyright (C) 2023 Martin Botka <martin@biqu3d.com>.
> + */
> +
> +/dts-v1/;
> +
> +#include "sun50i-h616-bigtreetech-cb1.dtsi"
> +
> +/ {
> +       model = "BigTreeTech Pi";
> +       compatible = "bigtreetech,pi", "allwinner,sun50i-h616";

As you say it's based on CB1 too, why no CB1 compatible here? (although
the manta compatible won't apply)

> +
> +       aliases {
> +               serial0 = &uart0;
> +       };
> +
> +       chosen {
> +               stdout-path = "serial0:115200n8";
> +       };
> +};
> +
> +&ehci0 {
> +       status = "okay";
> +};
> +
> +&ehci1 {
> +       status = "okay";
> +};
> +
> +&ehci2 {
> +       status = "okay";
> +};
> +
> +&ehci3 {
> +       status = "okay";
> +};
> +
> +&ir {
> +       status = "okay";
> +};
> +
> +&ohci0 {
> +       status = "okay";
> +};
> +
> +&ohci1 {
> +       status = "okay";
> +};
> +
> +&ohci2 {
> +       status = "okay";
> +};
> +
> +&ohci3 {
> +       status = "okay";
> +};
> +
> +&spi0 {
> +       /* SPI connection for onboard connector for ADXL345
> accelerometer */
> +       status = "okay";
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&spi0_pins>, <&spi0_cs0_pin>;
> +};
> +
> +&uart0 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&uart0_ph_pins>;
> +       status = "okay";
> +};


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 4/4] arm64: dts: allwinner: h616: Add BigTreeTech Pi support

[Jernej Škrabec]

Dne nedelja, 13. avgust 2023 ob 17:42:10 CEST je Icenowy Zheng napisal(a):
> 在 2023-08-07星期一的 16:53 +0200，Martin Botka写道：
> 
> > The BigTreeTech Pi is an H616 based board based on CB1.
> > Just in Rpi format board.
> > 
> > It features the same internals as BTT CB1 but adds:
> >     - Fan port
> >     - IR receiver
> >     - ADXL345 Accelerometer connector via SPI
> >     - 24V DC power supply via terminal plugs
> >     - USB to CAN module connector (The actual USB to CAN happens on
> > the external module)
> > 
> > List of currently working things is same as BTT CB1 but also:
> >     - IR receiver
> >     - ADXL345 connector
> > 
> > Signed-off-by: Martin Botka <martin@biqu3d.com>
> > Reviewed-by: Andre Przywara <andre.przywara@arm.com>
> > ---
> > Changes in V2:
> >     - Add UART alongside aliases and chosen for it
> >     - Add model string
> >     - Enable IR receiver
> >     - Enable SPI0 for ADXL345 connector
> > Changes in V3:
> >     - Add missing semicolons
> >     - Add pinctrl for SPI0
> > 
> >  arch/arm64/boot/dts/allwinner/Makefile        |  1 +
> >  .../allwinner/sun50i-h616-bigtreetech-pi.dts  | 70
> > +++++++++++++++++++
> >  2 files changed, 71 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h616-
> > bigtreetech-pi.dts
> > 
> > diff --git a/arch/arm64/boot/dts/allwinner/Makefile
> > b/arch/arm64/boot/dts/allwinner/Makefile
> > index 7b386428510b..0b6232a7f328 100644
> > --- a/arch/arm64/boot/dts/allwinner/Makefile
> > +++ b/arch/arm64/boot/dts/allwinner/Makefile
> > @@ -39,5 +39,6 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64-
> > model-b.dtb
> >  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb
> >  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6-mini.dtb
> >  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-cb1-manta.dtb
> > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-pi.dtb
> >  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb
> >  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-
> > pi.dts b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> > new file mode 100644
> > index 000000000000..b0d0386e8f13
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> > @@ -0,0 +1,70 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> > +/*
> > + * Copyright (C) 2023 Martin Botka <martin@biqu3d.com>.
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "sun50i-h616-bigtreetech-cb1.dtsi"
> > +
> > +/ {
> > +       model = "BigTreeTech Pi";
> > +       compatible = "bigtreetech,pi", "allwinner,sun50i-h616";
> 
> As you say it's based on CB1 too, why no CB1 compatible here? (although
> the manta compatible won't apply)

Because it doesn't contain module per se.

Best regards,
Jernej

> 
> > +
> > +       aliases {
> > +               serial0 = &uart0;
> > +       };
> > +
> > +       chosen {
> > +               stdout-path = "serial0:115200n8";
> > +       };
> > +};
> > +
> > +&ehci0 {
> > +       status = "okay";
> > +};
> > +
> > +&ehci1 {
> > +       status = "okay";
> > +};
> > +
> > +&ehci2 {
> > +       status = "okay";
> > +};
> > +
> > +&ehci3 {
> > +       status = "okay";
> > +};
> > +
> > +&ir {
> > +       status = "okay";
> > +};
> > +
> > +&ohci0 {
> > +       status = "okay";
> > +};
> > +
> > +&ohci1 {
> > +       status = "okay";
> > +};
> > +
> > +&ohci2 {
> > +       status = "okay";
> > +};
> > +
> > +&ohci3 {
> > +       status = "okay";
> > +};
> > +
> > +&spi0 {
> > +       /* SPI connection for onboard connector for ADXL345
> > accelerometer */
> > +       status = "okay";
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&spi0_pins>, <&spi0_cs0_pin>;
> > +};
> > +
> > +&uart0 {
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&uart0_ph_pins>;
> > +       status = "okay";
> > +};





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 4/4] arm64: dts: allwinner: h616: Add BigTreeTech Pi support

[Jernej Škrabec]

Dne ponedeljek, 07. avgust 2023 ob 16:53:24 CEST je Martin Botka napisal(a):
> The BigTreeTech Pi is an H616 based board based on CB1.
> Just in Rpi format board.
> 
> It features the same internals as BTT CB1 but adds:
>     - Fan port
>     - IR receiver
>     - ADXL345 Accelerometer connector via SPI
>     - 24V DC power supply via terminal plugs
>     - USB to CAN module connector (The actual USB to CAN happens on the
> external module)
> 
> List of currently working things is same as BTT CB1 but also:
>     - IR receiver
>     - ADXL345 connector
> 
> Signed-off-by: Martin Botka <martin@biqu3d.com>
> Reviewed-by: Andre Przywara <andre.przywara@arm.com>
> ---
> Changes in V2:
>     - Add UART alongside aliases and chosen for it
>     - Add model string
>     - Enable IR receiver
>     - Enable SPI0 for ADXL345 connector
> Changes in V3:
>     - Add missing semicolons
>     - Add pinctrl for SPI0
> 
>  arch/arm64/boot/dts/allwinner/Makefile        |  1 +
>  .../allwinner/sun50i-h616-bigtreetech-pi.dts  | 70 +++++++++++++++++++
>  2 files changed, 71 insertions(+)
>  create mode 100644
> arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> 
> diff --git a/arch/arm64/boot/dts/allwinner/Makefile
> b/arch/arm64/boot/dts/allwinner/Makefile index 7b386428510b..0b6232a7f328
> 100644
> --- a/arch/arm64/boot/dts/allwinner/Makefile
> +++ b/arch/arm64/boot/dts/allwinner/Makefile
> @@ -39,5 +39,6 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64-model-b.dtb
> dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb
>  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6-mini.dtb
>  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-cb1-manta.dtb
> +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-pi.dtb
>  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb
>  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts new file
> mode 100644
> index 000000000000..b0d0386e8f13
> --- /dev/null
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> @@ -0,0 +1,70 @@
> +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> +/*
> + * Copyright (C) 2023 Martin Botka <martin@biqu3d.com>.
> + */
> +
> +/dts-v1/;
> +
> +#include "sun50i-h616-bigtreetech-cb1.dtsi"
> +
> +/ {
> +	model = "BigTreeTech Pi";
> +	compatible = "bigtreetech,pi", "allwinner,sun50i-h616";
> +
> +	aliases {
> +		serial0 = &uart0;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
> +};
> +
> +&ehci0 {
> +	status = "okay";
> +};
> +
> +&ehci1 {
> +	status = "okay";
> +};
> +
> +&ehci2 {
> +	status = "okay";
> +};
> +
> +&ehci3 {
> +	status = "okay";
> +};
> +
> +&ir {
> +	status = "okay";
> +};
> +
> +&ohci0 {
> +	status = "okay";
> +};
> +
> +&ohci1 {
> +	status = "okay";
> +};
> +
> +&ohci2 {
> +	status = "okay";
> +};
> +
> +&ohci3 {
> +	status = "okay";
> +};
> +
> +&spi0 {
> +	/* SPI connection for onboard connector for ADXL345 accelerometer 
*/
> +	status = "okay";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&spi0_pins>, <&spi0_cs0_pin>;

Driver and compatible for ADXL345 already exists, why don't you add child node 
for it?

Best regards,
Jernej

> +};
> +
> +&uart0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&uart0_ph_pins>;
> +	status = "okay";
> +};





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 4/4] arm64: dts: allwinner: h616: Add BigTreeTech Pi support

[Martin Botka]

On Sun, Aug 13 2023 at 05:55:35 PM +02:00:00, Jernej Škrabec 
<jernej.skrabec@gmail.com> wrote:
> Dne ponedeljek, 07. avgust 2023 ob 16:53:24 CEST je Martin Botka 
> napisal(a):
>>  The BigTreeTech Pi is an H616 based board based on CB1.
>>  Just in Rpi format board.
>> 
>>  It features the same internals as BTT CB1 but adds:
>>      - Fan port
>>      - IR receiver
>>      - ADXL345 Accelerometer connector via SPI
>>      - 24V DC power supply via terminal plugs
>>      - USB to CAN module connector (The actual USB to CAN happens on 
>> the
>>  external module)
>> 
>>  List of currently working things is same as BTT CB1 but also:
>>      - IR receiver
>>      - ADXL345 connector
>> 
>>  Signed-off-by: Martin Botka <martin@biqu3d.com>
>>  Reviewed-by: Andre Przywara <andre.przywara@arm.com>
>>  ---
>>  Changes in V2:
>>      - Add UART alongside aliases and chosen for it
>>      - Add model string
>>      - Enable IR receiver
>>      - Enable SPI0 for ADXL345 connector
>>  Changes in V3:
>>      - Add missing semicolons
>>      - Add pinctrl for SPI0
>> 
>>   arch/arm64/boot/dts/allwinner/Makefile        |  1 +
>>   .../allwinner/sun50i-h616-bigtreetech-pi.dts  | 70 
>> +++++++++++++++++++
>>   2 files changed, 71 insertions(+)
>>   create mode 100644
>>  arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
>> 
>>  diff --git a/arch/arm64/boot/dts/allwinner/Makefile
>>  b/arch/arm64/boot/dts/allwinner/Makefile index 
>> 7b386428510b..0b6232a7f328
>>  100644
>>  --- a/arch/arm64/boot/dts/allwinner/Makefile
>>  +++ b/arch/arm64/boot/dts/allwinner/Makefile
>>  @@ -39,5 +39,6 @@ dtb-$(CONFIG_ARCH_SUNXI) += 
>> sun50i-h6-pine-h64-model-b.dtb
>>  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb
>>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6-mini.dtb
>>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-cb1-manta.dtb
>>  +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-pi.dtb
>>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb
>>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb
>>  diff --git 
>> a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
>>  b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts new 
>> file
>>  mode 100644
>>  index 000000000000..b0d0386e8f13
>>  --- /dev/null
>>  +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
>>  @@ -0,0 +1,70 @@
>>  +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
>>  +/*
>>  + * Copyright (C) 2023 Martin Botka <martin@biqu3d.com>.
>>  + */
>>  +
>>  +/dts-v1/;
>>  +
>>  +#include "sun50i-h616-bigtreetech-cb1.dtsi"
>>  +
>>  +/ {
>>  +	model = "BigTreeTech Pi";
>>  +	compatible = "bigtreetech,pi", "allwinner,sun50i-h616";
>>  +
>>  +	aliases {
>>  +		serial0 = &uart0;
>>  +	};
>>  +
>>  +	chosen {
>>  +		stdout-path = "serial0:115200n8";
>>  +	};
>>  +};
>>  +
>>  +&ehci0 {
>>  +	status = "okay";
>>  +};
>>  +
>>  +&ehci1 {
>>  +	status = "okay";
>>  +};
>>  +
>>  +&ehci2 {
>>  +	status = "okay";
>>  +};
>>  +
>>  +&ehci3 {
>>  +	status = "okay";
>>  +};
>>  +
>>  +&ir {
>>  +	status = "okay";
>>  +};
>>  +
>>  +&ohci0 {
>>  +	status = "okay";
>>  +};
>>  +
>>  +&ohci1 {
>>  +	status = "okay";
>>  +};
>>  +
>>  +&ohci2 {
>>  +	status = "okay";
>>  +};
>>  +
>>  +&ohci3 {
>>  +	status = "okay";
>>  +};
>>  +
>>  +&spi0 {
>>  +	/* SPI connection for onboard connector for ADXL345 accelerometer
> */
>>  +	status = "okay";
>>  +	pinctrl-names = "default";
>>  +	pinctrl-0 = <&spi0_pins>, <&spi0_cs0_pin>;
> 
> Driver and compatible for ADXL345 already exists, why don't you add 
> child node
> for it?
> 
> Best regards,
> Jernej
Ah. So the ADXL345 actually wont be driven by kernel.
The SPI connection is enabled so that klipper (3d printer firmware) can
be told to look for ADXL345 at this SPI and use it on its own.

Klipper will initialize and communicate with the ADXL on its own.
> 
>>  +};
>>  +
>>  +&uart0 {
>>  +	pinctrl-names = "default";
>>  +	pinctrl-0 = <&uart0_ph_pins>;
>>  +	status = "okay";
>>  +};
> 
> 
> 
> 



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 4/4] arm64: dts: allwinner: h616: Add BigTreeTech Pi support

[Jernej Škrabec]

Dne nedelja, 13. avgust 2023 ob 18:22:49 CEST je Martin Botka napisal(a):
> On Sun, Aug 13 2023 at 05:55:35 PM +02:00:00, Jernej Škrabec
> 
> <jernej.skrabec@gmail.com> wrote:
> > Dne ponedeljek, 07. avgust 2023 ob 16:53:24 CEST je Martin Botka
> > 
> > napisal(a):
> >>  The BigTreeTech Pi is an H616 based board based on CB1.
> >>  Just in Rpi format board.
> >>  
> >>  It features the same internals as BTT CB1 but adds:
> >>      - Fan port
> >>      - IR receiver
> >>      - ADXL345 Accelerometer connector via SPI
> >>      - 24V DC power supply via terminal plugs
> >>      - USB to CAN module connector (The actual USB to CAN happens on
> >> 
> >> the
> >> 
> >>  external module)
> >>  
> >>  List of currently working things is same as BTT CB1 but also:
> >>      - IR receiver
> >>      - ADXL345 connector
> >>  
> >>  Signed-off-by: Martin Botka <martin@biqu3d.com>
> >>  Reviewed-by: Andre Przywara <andre.przywara@arm.com>
> >>  ---
> >>  
> >>  Changes in V2:
> >>      - Add UART alongside aliases and chosen for it
> >>      - Add model string
> >>      - Enable IR receiver
> >>      - Enable SPI0 for ADXL345 connector
> >>  
> >>  Changes in V3:
> >>      - Add missing semicolons
> >>      - Add pinctrl for SPI0
> >>   
> >>   arch/arm64/boot/dts/allwinner/Makefile        |  1 +
> >>   .../allwinner/sun50i-h616-bigtreetech-pi.dts  | 70
> >> 
> >> +++++++++++++++++++
> >> 
> >>   2 files changed, 71 insertions(+)
> >>   create mode 100644
> >>  
> >>  arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> >>  
> >>  diff --git a/arch/arm64/boot/dts/allwinner/Makefile
> >>  b/arch/arm64/boot/dts/allwinner/Makefile index
> >> 
> >> 7b386428510b..0b6232a7f328
> >> 
> >>  100644
> >>  --- a/arch/arm64/boot/dts/allwinner/Makefile
> >>  +++ b/arch/arm64/boot/dts/allwinner/Makefile
> >>  @@ -39,5 +39,6 @@ dtb-$(CONFIG_ARCH_SUNXI) +=
> >> 
> >> sun50i-h6-pine-h64-model-b.dtb
> >> 
> >>  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb
> >>  
> >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6-mini.dtb
> >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-cb1-manta.dtb
> >>  
> >>  +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-pi.dtb
> >>  
> >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb
> >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb
> >>  
> >>  diff --git
> >> 
> >> a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> >> 
> >>  b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts new
> >> 
> >> file
> >> 
> >>  mode 100644
> >>  index 000000000000..b0d0386e8f13
> >>  --- /dev/null
> >>  +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> >>  @@ -0,0 +1,70 @@
> >>  +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> >>  +/*
> >>  + * Copyright (C) 2023 Martin Botka <martin@biqu3d.com>.
> >>  + */
> >>  +
> >>  +/dts-v1/;
> >>  +
> >>  +#include "sun50i-h616-bigtreetech-cb1.dtsi"
> >>  +
> >>  +/ {
> >>  +	model = "BigTreeTech Pi";
> >>  +	compatible = "bigtreetech,pi", "allwinner,sun50i-h616";
> >>  +
> >>  +	aliases {
> >>  +		serial0 = &uart0;
> >>  +	};
> >>  +
> >>  +	chosen {
> >>  +		stdout-path = "serial0:115200n8";
> >>  +	};
> >>  +};
> >>  +
> >>  +&ehci0 {
> >>  +	status = "okay";
> >>  +};
> >>  +
> >>  +&ehci1 {
> >>  +	status = "okay";
> >>  +};
> >>  +
> >>  +&ehci2 {
> >>  +	status = "okay";
> >>  +};
> >>  +
> >>  +&ehci3 {
> >>  +	status = "okay";
> >>  +};
> >>  +
> >>  +&ir {
> >>  +	status = "okay";
> >>  +};
> >>  +
> >>  +&ohci0 {
> >>  +	status = "okay";
> >>  +};
> >>  +
> >>  +&ohci1 {
> >>  +	status = "okay";
> >>  +};
> >>  +
> >>  +&ohci2 {
> >>  +	status = "okay";
> >>  +};
> >>  +
> >>  +&ohci3 {
> >>  +	status = "okay";
> >>  +};
> >>  +
> >>  +&spi0 {
> >>  +	/* SPI connection for onboard connector for ADXL345 accelerometer
> > 
> > */
> > 
> >>  +	status = "okay";
> >>  +	pinctrl-names = "default";
> >>  +	pinctrl-0 = <&spi0_pins>, <&spi0_cs0_pin>;
> > 
> > Driver and compatible for ADXL345 already exists, why don't you add
> > child node
> > for it?
> > 
> > Best regards,
> > Jernej
> 
> Ah. So the ADXL345 actually wont be driven by kernel.

DT is hardware description, it's not concerned what is done on software side, 
either kernel or user space.

> The SPI connection is enabled so that klipper (3d printer firmware) can
> be told to look for ADXL345 at this SPI and use it on its own.
> 
> Klipper will initialize and communicate with the ADXL on its own.

What do you mean by firmware? User space app? In this case I suppose you'll use 
direct SPI commands from user space? AFAIK that's less and less supported by 
kernel (in contrast to I2C).

Best regards,
Jernej

> 
> >>  +};
> >>  +
> >>  +&uart0 {
> >>  +	pinctrl-names = "default";
> >>  +	pinctrl-0 = <&uart0_ph_pins>;
> >>  +	status = "okay";
> >>  +};





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 4/4] arm64: dts: allwinner: h616: Add BigTreeTech Pi support

[Martin Botka]

On Mon, Aug 14 2023 at 12:26:07 PM +02:00:00, Jernej Škrabec 
<jernej.skrabec@gmail.com> wrote:
> Dne nedelja, 13. avgust 2023 ob 18:22:49 CEST je Martin Botka 
> napisal(a):
>>  On Sun, Aug 13 2023 at 05:55:35 PM +02:00:00, Jernej Škrabec
>> 
>>  <jernej.skrabec@gmail.com> wrote:
>>  > Dne ponedeljek, 07. avgust 2023 ob 16:53:24 CEST je Martin Botka
>>  >
>>  > napisal(a):
>>  >>  The BigTreeTech Pi is an H616 based board based on CB1.
>>  >>  Just in Rpi format board.
>>  >>
>>  >>  It features the same internals as BTT CB1 but adds:
>>  >>      - Fan port
>>  >>      - IR receiver
>>  >>      - ADXL345 Accelerometer connector via SPI
>>  >>      - 24V DC power supply via terminal plugs
>>  >>      - USB to CAN module connector (The actual USB to CAN 
>> happens on
>>  >>
>>  >> the
>>  >>
>>  >>  external module)
>>  >>
>>  >>  List of currently working things is same as BTT CB1 but also:
>>  >>      - IR receiver
>>  >>      - ADXL345 connector
>>  >>
>>  >>  Signed-off-by: Martin Botka <martin@biqu3d.com>
>>  >>  Reviewed-by: Andre Przywara <andre.przywara@arm.com>
>>  >>  ---
>>  >>
>>  >>  Changes in V2:
>>  >>      - Add UART alongside aliases and chosen for it
>>  >>      - Add model string
>>  >>      - Enable IR receiver
>>  >>      - Enable SPI0 for ADXL345 connector
>>  >>
>>  >>  Changes in V3:
>>  >>      - Add missing semicolons
>>  >>      - Add pinctrl for SPI0
>>  >>
>>  >>   arch/arm64/boot/dts/allwinner/Makefile        |  1 +
>>  >>   .../allwinner/sun50i-h616-bigtreetech-pi.dts  | 70
>>  >>
>>  >> +++++++++++++++++++
>>  >>
>>  >>   2 files changed, 71 insertions(+)
>>  >>   create mode 100644
>>  >>
>>  >>  arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
>>  >>
>>  >>  diff --git a/arch/arm64/boot/dts/allwinner/Makefile
>>  >>  b/arch/arm64/boot/dts/allwinner/Makefile index
>>  >>
>>  >> 7b386428510b..0b6232a7f328
>>  >>
>>  >>  100644
>>  >>  --- a/arch/arm64/boot/dts/allwinner/Makefile
>>  >>  +++ b/arch/arm64/boot/dts/allwinner/Makefile
>>  >>  @@ -39,5 +39,6 @@ dtb-$(CONFIG_ARCH_SUNXI) +=
>>  >>
>>  >> sun50i-h6-pine-h64-model-b.dtb
>>  >>
>>  >>  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb
>>  >>
>>  >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6-mini.dtb
>>  >>   dtb-$(CONFIG_ARCH_SUNXI) += 
>> sun50i-h616-bigtreetech-cb1-manta.dtb
>>  >>
>>  >>  +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-pi.dtb
>>  >>
>>  >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb
>>  >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb
>>  >>
>>  >>  diff --git
>>  >>
>>  >> a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
>>  >>
>>  >>  b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts 
>> new
>>  >>
>>  >> file
>>  >>
>>  >>  mode 100644
>>  >>  index 000000000000..b0d0386e8f13
>>  >>  --- /dev/null
>>  >>  +++ 
>> b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
>>  >>  @@ -0,0 +1,70 @@
>>  >>  +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
>>  >>  +/*
>>  >>  + * Copyright (C) 2023 Martin Botka <martin@biqu3d.com>.
>>  >>  + */
>>  >>  +
>>  >>  +/dts-v1/;
>>  >>  +
>>  >>  +#include "sun50i-h616-bigtreetech-cb1.dtsi"
>>  >>  +
>>  >>  +/ {
>>  >>  +	model = "BigTreeTech Pi";
>>  >>  +	compatible = "bigtreetech,pi", "allwinner,sun50i-h616";
>>  >>  +
>>  >>  +	aliases {
>>  >>  +		serial0 = &uart0;
>>  >>  +	};
>>  >>  +
>>  >>  +	chosen {
>>  >>  +		stdout-path = "serial0:115200n8";
>>  >>  +	};
>>  >>  +};
>>  >>  +
>>  >>  +&ehci0 {
>>  >>  +	status = "okay";
>>  >>  +};
>>  >>  +
>>  >>  +&ehci1 {
>>  >>  +	status = "okay";
>>  >>  +};
>>  >>  +
>>  >>  +&ehci2 {
>>  >>  +	status = "okay";
>>  >>  +};
>>  >>  +
>>  >>  +&ehci3 {
>>  >>  +	status = "okay";
>>  >>  +};
>>  >>  +
>>  >>  +&ir {
>>  >>  +	status = "okay";
>>  >>  +};
>>  >>  +
>>  >>  +&ohci0 {
>>  >>  +	status = "okay";
>>  >>  +};
>>  >>  +
>>  >>  +&ohci1 {
>>  >>  +	status = "okay";
>>  >>  +};
>>  >>  +
>>  >>  +&ohci2 {
>>  >>  +	status = "okay";
>>  >>  +};
>>  >>  +
>>  >>  +&ohci3 {
>>  >>  +	status = "okay";
>>  >>  +};
>>  >>  +
>>  >>  +&spi0 {
>>  >>  +	/* SPI connection for onboard connector for ADXL345 
>> accelerometer
>>  >
>>  > */
>>  >
>>  >>  +	status = "okay";
>>  >>  +	pinctrl-names = "default";
>>  >>  +	pinctrl-0 = <&spi0_pins>, <&spi0_cs0_pin>;
>>  >
>>  > Driver and compatible for ADXL345 already exists, why don't you 
>> add
>>  > child node
>>  > for it?
>>  >
>>  > Best regards,
>>  > Jernej
>> 
>>  Ah. So the ADXL345 actually wont be driven by kernel.
> 
> DT is hardware description, it's not concerned what is done on 
> software side,
> either kernel or user space.
Im aware. But this is not a device that is on the board. Its simply a 
connector for the device.
Like Rpi has connectors for camera module :)
> 
>>  The SPI connection is enabled so that klipper (3d printer firmware) 
>> can
>>  be told to look for ADXL345 at this SPI and use it on its own.
>> 
>>  Klipper will initialize and communicate with the ADXL on its own.
> 
> What do you mean by firmware? User space app? In this case I suppose 
> you'll use
> direct SPI commands from user space? AFAIK that's less and less 
> supported by
> kernel (in contrast to I2C).
Firmware as in 3d printer firmware. Klipper runs on the board (CB1 or 
BTT Pi) and is indeed an userspace app.
And indeed uses direct SPI commands to the device.

The reason for this is the flexibility.
If Klipper read the values from kernel or well from the files the ADXL 
driver would create
then it would be unable to communicate with ADXL that is on toolhead 
board. Or would have to have
direct initialization either way for those. Thus it just controls the 
ADXL itself :)

I understand that this may be bit confusing. If there is still 
something not clear im more then happy to explain in
full detail how the userspace and 3D printer communicate :)

Cheers,
Martin.
> 
> Best regards,
> Jernej
> 
>> 
>>  >>  +};
>>  >>  +
>>  >>  +&uart0 {
>>  >>  +	pinctrl-names = "default";
>>  >>  +	pinctrl-0 = <&uart0_ph_pins>;
>>  >>  +	status = "okay";
>>  >>  +};
> 
> 
> 
> 



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 4/4] arm64: dts: allwinner: h616: Add BigTreeTech Pi support

[Martin Botka]

On Mon, Aug 14 2023 at 12:47:59 PM +02:00:00, Martin Botka 
<martin.botka@somainline.org> wrote:
> 
> 
> On Mon, Aug 14 2023 at 12:26:07 PM +02:00:00, Jernej Škrabec 
> <jernej.skrabec@gmail.com> wrote:
>> Dne nedelja, 13. avgust 2023 ob 18:22:49 CEST je Martin Botka 
>> \x7fnapisal(a):
>>>  On Sun, Aug 13 2023 at 05:55:35 PM +02:00:00, Jernej Škrabec
>>> 
>>>  <jernej.skrabec@gmail.com> wrote:
>>>  > Dne ponedeljek, 07. avgust 2023 ob 16:53:24 CEST je Martin Botka
>>>  >
>>>  > napisal(a):
>>>  >>  The BigTreeTech Pi is an H616 based board based on CB1.
>>>  >>  Just in Rpi format board.
>>>  >>
>>>  >>  It features the same internals as BTT CB1 but adds:
>>>  >>      - Fan port
>>>  >>      - IR receiver
>>>  >>      - ADXL345 Accelerometer connector via SPI
>>>  >>      - 24V DC power supply via terminal plugs
>>>  >>      - USB to CAN module connector (The actual USB to CAN 
>>> \x7f\x7fhappens on
>>>  >>
>>>  >> the
>>>  >>
>>>  >>  external module)
>>>  >>
>>>  >>  List of currently working things is same as BTT CB1 but also:
>>>  >>      - IR receiver
>>>  >>      - ADXL345 connector
>>>  >>
>>>  >>  Signed-off-by: Martin Botka <martin@biqu3d.com>
>>>  >>  Reviewed-by: Andre Przywara <andre.przywara@arm.com>
>>>  >>  ---
>>>  >>
>>>  >>  Changes in V2:
>>>  >>      - Add UART alongside aliases and chosen for it
>>>  >>      - Add model string
>>>  >>      - Enable IR receiver
>>>  >>      - Enable SPI0 for ADXL345 connector
>>>  >>
>>>  >>  Changes in V3:
>>>  >>      - Add missing semicolons
>>>  >>      - Add pinctrl for SPI0
>>>  >>
>>>  >>   arch/arm64/boot/dts/allwinner/Makefile        |  1 +
>>>  >>   .../allwinner/sun50i-h616-bigtreetech-pi.dts  | 70
>>>  >>
>>>  >> +++++++++++++++++++
>>>  >>
>>>  >>   2 files changed, 71 insertions(+)
>>>  >>   create mode 100644
>>>  >>
>>>  >>  arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
>>>  >>
>>>  >>  diff --git a/arch/arm64/boot/dts/allwinner/Makefile
>>>  >>  b/arch/arm64/boot/dts/allwinner/Makefile index
>>>  >>
>>>  >> 7b386428510b..0b6232a7f328
>>>  >>
>>>  >>  100644
>>>  >>  --- a/arch/arm64/boot/dts/allwinner/Makefile
>>>  >>  +++ b/arch/arm64/boot/dts/allwinner/Makefile
>>>  >>  @@ -39,5 +39,6 @@ dtb-$(CONFIG_ARCH_SUNXI) +=
>>>  >>
>>>  >> sun50i-h6-pine-h64-model-b.dtb
>>>  >>
>>>  >>  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb
>>>  >>
>>>  >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6-mini.dtb
>>>  >>   dtb-$(CONFIG_ARCH_SUNXI) += 
>>> \x7f\x7fsun50i-h616-bigtreetech-cb1-manta.dtb
>>>  >>
>>>  >>  +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-pi.dtb
>>>  >>
>>>  >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb
>>>  >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb
>>>  >>
>>>  >>  diff --git
>>>  >>
>>>  >> a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
>>>  >>
>>>  >>  b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts 
>>> \x7f\x7fnew
>>>  >>
>>>  >> file
>>>  >>
>>>  >>  mode 100644
>>>  >>  index 000000000000..b0d0386e8f13
>>>  >>  --- /dev/null
>>>  >>  +++ 
>>> \x7f\x7fb/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
>>>  >>  @@ -0,0 +1,70 @@
>>>  >>  +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
>>>  >>  +/*
>>>  >>  + * Copyright (C) 2023 Martin Botka <martin@biqu3d.com>.
>>>  >>  + */
>>>  >>  +
>>>  >>  +/dts-v1/;
>>>  >>  +
>>>  >>  +#include "sun50i-h616-bigtreetech-cb1.dtsi"
>>>  >>  +
>>>  >>  +/ {
>>>  >>  +	model = "BigTreeTech Pi";
>>>  >>  +	compatible = "bigtreetech,pi", "allwinner,sun50i-h616";
>>>  >>  +
>>>  >>  +	aliases {
>>>  >>  +		serial0 = &uart0;
>>>  >>  +	};
>>>  >>  +
>>>  >>  +	chosen {
>>>  >>  +		stdout-path = "serial0:115200n8";
>>>  >>  +	};
>>>  >>  +};
>>>  >>  +
>>>  >>  +&ehci0 {
>>>  >>  +	status = "okay";
>>>  >>  +};
>>>  >>  +
>>>  >>  +&ehci1 {
>>>  >>  +	status = "okay";
>>>  >>  +};
>>>  >>  +
>>>  >>  +&ehci2 {
>>>  >>  +	status = "okay";
>>>  >>  +};
>>>  >>  +
>>>  >>  +&ehci3 {
>>>  >>  +	status = "okay";
>>>  >>  +};
>>>  >>  +
>>>  >>  +&ir {
>>>  >>  +	status = "okay";
>>>  >>  +};
>>>  >>  +
>>>  >>  +&ohci0 {
>>>  >>  +	status = "okay";
>>>  >>  +};
>>>  >>  +
>>>  >>  +&ohci1 {
>>>  >>  +	status = "okay";
>>>  >>  +};
>>>  >>  +
>>>  >>  +&ohci2 {
>>>  >>  +	status = "okay";
>>>  >>  +};
>>>  >>  +
>>>  >>  +&ohci3 {
>>>  >>  +	status = "okay";
>>>  >>  +};
>>>  >>  +
>>>  >>  +&spi0 {
>>>  >>  +	/* SPI connection for onboard connector for ADXL345 
>>> \x7f\x7faccelerometer
>>>  >
>>>  > */
>>>  >
>>>  >>  +	status = "okay";
>>>  >>  +	pinctrl-names = "default";
>>>  >>  +	pinctrl-0 = <&spi0_pins>, <&spi0_cs0_pin>;
>>>  >
>>>  > Driver and compatible for ADXL345 already exists, why don't you 
>>> \x7f\x7fadd
>>>  > child node
>>>  > for it?
>>>  >
>>>  > Best regards,
>>>  > Jernej
>>> 
>>>  Ah. So the ADXL345 actually wont be driven by kernel.
>> 
>> DT is hardware description, it's not concerned what is done on 
>> \x7fsoftware side,
>> either kernel or user space.
> Im aware. But this is not a device that is on the board. Its simply a 
> connector for the device.
> Like Rpi has connectors for camera module :)
>> 
>>>  The SPI connection is enabled so that klipper (3d printer 
>>> firmware) \x7f\x7fcan
>>>  be told to look for ADXL345 at this SPI and use it on its own.
>>> 
>>>  Klipper will initialize and communicate with the ADXL on its own.
>> 
>> What do you mean by firmware? User space app? In this case I suppose 
>> \x7fyou'll use
>> direct SPI commands from user space? AFAIK that's less and less 
>> \x7fsupported by
>> kernel (in contrast to I2C).
> Firmware as in 3d printer firmware. Klipper runs on the board (CB1 or 
> BTT Pi) and is indeed an userspace app.
> And indeed uses direct SPI commands to the device.
> 
> The reason for this is the flexibility.
> If Klipper read the values from kernel or well from the files the 
> ADXL driver would create
> then it would be unable to communicate with ADXL that is on toolhead 
> board. Or would have to have
> direct initialization either way for those. Thus it just controls the 
> ADXL itself :)
> 
> I understand that this may be bit confusing. If there is still 
> something not clear im more then happy to explain in
> full detail how the userspace and 3D printer communicate :)
> 
> Cheers,
> Martin.
Hello,
Jernej any comments on this ?
I would like to resolve this conversation :)
We do have a bunch of time before the new cycle but never hurts to get 
it figured out ahead of time :)

Cheers,
Martin
>> 
>> Best regards,
>> Jernej
>> 
>>> 
>>>  >>  +};
>>>  >>  +
>>>  >>  +&uart0 {
>>>  >>  +	pinctrl-names = "default";
>>>  >>  +	pinctrl-0 = <&uart0_ph_pins>;
>>>  >>  +	status = "okay";
>>>  >>  +};
>> 
>> 
>> 
>> 
> 



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 4/4] arm64: dts: allwinner: h616: Add BigTreeTech Pi support

[Jernej Škrabec]

On Thursday, August 24, 2023 10:48:20 PM CEST Martin Botka wrote:
> On Mon, Aug 14 2023 at 12:47:59 PM +02:00:00, Martin Botka
> 
> <martin.botka@somainline.org> wrote:
> > On Mon, Aug 14 2023 at 12:26:07 PM +02:00:00, Jernej Škrabec
> > 
> > <jernej.skrabec@gmail.com> wrote:
> >> Dne nedelja, 13. avgust 2023 ob 18:22:49 CEST je Martin Botka
> >> 
> >> \x7fnapisal(a):
> >>>  On Sun, Aug 13 2023 at 05:55:35 PM +02:00:00, Jernej Škrabec
> >>>  
> >>>  <jernej.skrabec@gmail.com> wrote:
> >>>  > Dne ponedeljek, 07. avgust 2023 ob 16:53:24 CEST je Martin Botka
> >>>  > 
> >>>  > napisal(a):
> >>>  >>  The BigTreeTech Pi is an H616 based board based on CB1.
> >>>  >>  Just in Rpi format board.
> >>>  >>  
> >>>  >>  It features the same internals as BTT CB1 but adds:
> >>>  >>      - Fan port
> >>>  >>      - IR receiver
> >>>  >>      - ADXL345 Accelerometer connector via SPI
> >>>  >>      - 24V DC power supply via terminal plugs
> >>>  >>      - USB to CAN module connector (The actual USB to CAN
> >>> 
> >>> \x7f\x7fhappens on
> >>> 
> >>>  >> the
> >>>  >> 
> >>>  >>  external module)
> >>>  >>  
> >>>  >>  List of currently working things is same as BTT CB1 but also:
> >>>  >>      - IR receiver
> >>>  >>      - ADXL345 connector
> >>>  >>  
> >>>  >>  Signed-off-by: Martin Botka <martin@biqu3d.com>
> >>>  >>  Reviewed-by: Andre Przywara <andre.przywara@arm.com>
> >>>  >>  ---
> >>>  >>  
> >>>  >>  Changes in V2:
> >>>  >>      - Add UART alongside aliases and chosen for it
> >>>  >>      - Add model string
> >>>  >>      - Enable IR receiver
> >>>  >>      - Enable SPI0 for ADXL345 connector
> >>>  >>  
> >>>  >>  Changes in V3:
> >>>  >>      - Add missing semicolons
> >>>  >>      - Add pinctrl for SPI0
> >>>  >>   
> >>>  >>   arch/arm64/boot/dts/allwinner/Makefile        |  1 +
> >>>  >>   .../allwinner/sun50i-h616-bigtreetech-pi.dts  | 70
> >>>  >> 
> >>>  >> +++++++++++++++++++
> >>>  >> 
> >>>  >>   2 files changed, 71 insertions(+)
> >>>  >>   create mode 100644
> >>>  >>  
> >>>  >>  arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> >>>  >>  
> >>>  >>  diff --git a/arch/arm64/boot/dts/allwinner/Makefile
> >>>  >>  b/arch/arm64/boot/dts/allwinner/Makefile index
> >>>  >> 
> >>>  >> 7b386428510b..0b6232a7f328
> >>>  >> 
> >>>  >>  100644
> >>>  >>  --- a/arch/arm64/boot/dts/allwinner/Makefile
> >>>  >>  +++ b/arch/arm64/boot/dts/allwinner/Makefile
> >>>  >>  @@ -39,5 +39,6 @@ dtb-$(CONFIG_ARCH_SUNXI) +=
> >>>  >> 
> >>>  >> sun50i-h6-pine-h64-model-b.dtb
> >>>  >> 
> >>>  >>  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb
> >>>  >>  
> >>>  >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6-mini.dtb
> >>>  >>   dtb-$(CONFIG_ARCH_SUNXI) +=
> >>> 
> >>> \x7f\x7fsun50i-h616-bigtreetech-cb1-manta.dtb
> >>> 
> >>>  >>  +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-pi.dtb
> >>>  >>  
> >>>  >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb
> >>>  >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb
> >>>  >>  
> >>>  >>  diff --git
> >>>  >> 
> >>>  >> a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> >>>  >> 
> >>>  >>  b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> >>> 
> >>> \x7f\x7fnew
> >>> 
> >>>  >> file
> >>>  >> 
> >>>  >>  mode 100644
> >>>  >>  index 000000000000..b0d0386e8f13
> >>>  >>  --- /dev/null
> >>>  >>  +++
> >>> 
> >>> \x7f\x7fb/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> >>> 
> >>>  >>  @@ -0,0 +1,70 @@
> >>>  >>  +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> >>>  >>  +/*
> >>>  >>  + * Copyright (C) 2023 Martin Botka <martin@biqu3d.com>.
> >>>  >>  + */
> >>>  >>  +
> >>>  >>  +/dts-v1/;
> >>>  >>  +
> >>>  >>  +#include "sun50i-h616-bigtreetech-cb1.dtsi"
> >>>  >>  +
> >>>  >>  +/ {
> >>>  >>  +	model = "BigTreeTech Pi";
> >>>  >>  +	compatible = "bigtreetech,pi", "allwinner,sun50i-h616";
> >>>  >>  +
> >>>  >>  +	aliases {
> >>>  >>  +		serial0 = &uart0;
> >>>  >>  +	};
> >>>  >>  +
> >>>  >>  +	chosen {
> >>>  >>  +		stdout-path = "serial0:115200n8";
> >>>  >>  +	};
> >>>  >>  +};
> >>>  >>  +
> >>>  >>  +&ehci0 {
> >>>  >>  +	status = "okay";
> >>>  >>  +};
> >>>  >>  +
> >>>  >>  +&ehci1 {
> >>>  >>  +	status = "okay";
> >>>  >>  +};
> >>>  >>  +
> >>>  >>  +&ehci2 {
> >>>  >>  +	status = "okay";
> >>>  >>  +};
> >>>  >>  +
> >>>  >>  +&ehci3 {
> >>>  >>  +	status = "okay";
> >>>  >>  +};
> >>>  >>  +
> >>>  >>  +&ir {
> >>>  >>  +	status = "okay";
> >>>  >>  +};
> >>>  >>  +
> >>>  >>  +&ohci0 {
> >>>  >>  +	status = "okay";
> >>>  >>  +};
> >>>  >>  +
> >>>  >>  +&ohci1 {
> >>>  >>  +	status = "okay";
> >>>  >>  +};
> >>>  >>  +
> >>>  >>  +&ohci2 {
> >>>  >>  +	status = "okay";
> >>>  >>  +};
> >>>  >>  +
> >>>  >>  +&ohci3 {
> >>>  >>  +	status = "okay";
> >>>  >>  +};
> >>>  >>  +
> >>>  >>  +&spi0 {
> >>>  >>  +	/* SPI connection for onboard connector for ADXL345
> >>> 
> >>> \x7f\x7faccelerometer
> >>> 
> >>>  > */
> >>>  > 
> >>>  >>  +	status = "okay";
> >>>  >>  +	pinctrl-names = "default";
> >>>  >>  +	pinctrl-0 = <&spi0_pins>, <&spi0_cs0_pin>;
> >>>  > 
> >>>  > Driver and compatible for ADXL345 already exists, why don't you
> >>> 
> >>> \x7f\x7fadd
> >>> 
> >>>  > child node
> >>>  > for it?
> >>>  > 
> >>>  > Best regards,
> >>>  > Jernej
> >>>  
> >>>  Ah. So the ADXL345 actually wont be driven by kernel.
> >> 
> >> DT is hardware description, it's not concerned what is done on
> >> \x7fsoftware side,
> >> either kernel or user space.
> > 
> > Im aware. But this is not a device that is on the board. Its simply a
> > connector for the device.
> > Like Rpi has connectors for camera module :)

Actually it matters only if this other board is firmly connected with base 
board. If it is not, then SPI node should be dropped and be handled with DT 
overlays.

> > 
> >>>  The SPI connection is enabled so that klipper (3d printer
> >>> 
> >>> firmware) \x7f\x7fcan
> >>> 
> >>>  be told to look for ADXL345 at this SPI and use it on its own.
> >>>  
> >>>  Klipper will initialize and communicate with the ADXL on its own.
> >> 
> >> What do you mean by firmware? User space app? In this case I suppose
> >> \x7fyou'll use
> >> direct SPI commands from user space? AFAIK that's less and less
> >> \x7fsupported by
> >> kernel (in contrast to I2C).
> > 
> > Firmware as in 3d printer firmware. Klipper runs on the board (CB1 or
> > BTT Pi) and is indeed an userspace app.
> > And indeed uses direct SPI commands to the device.
> > 
> > The reason for this is the flexibility.
> > If Klipper read the values from kernel or well from the files the
> > ADXL driver would create
> > then it would be unable to communicate with ADXL that is on toolhead
> > board. Or would have to have
> > direct initialization either way for those. Thus it just controls the
> > ADXL itself :)
> > 
> > I understand that this may be bit confusing. If there is still
> > something not clear im more then happy to explain in
> > full detail how the userspace and 3D printer communicate :)

As I said, DT doesn't care about implementation. DT is HW description, so 
either if it's fixed connection (soldered wires), then describe in full, 
otherwise it's considered addon board and thus non-essential, so it should be 
handled with DT overlays.

Can be CB1 bought separately from 3D printer package and thus used without 
ADXL sensor?

> > 
> > Cheers,
> > Martin.
> 
> Hello,
> Jernej any comments on this ?
> I would like to resolve this conversation :)
> We do have a bunch of time before the new cycle but never hurts to get
> it figured out ahead of time :)

Sorry, not enough free time over summer.

Best regards,
Jernej

> 
> Cheers,
> Martin
> 
> >> Best regards,
> >> Jernej
> >> 
> >>>  >>  +};
> >>>  >>  +
> >>>  >>  +&uart0 {
> >>>  >>  +	pinctrl-names = "default";
> >>>  >>  +	pinctrl-0 = <&uart0_ph_pins>;
> >>>  >>  +	status = "okay";
> >>>  >>  +};





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 4/4] arm64: dts: allwinner: h616: Add BigTreeTech Pi support

[Martin Botka]

On Tue, Sep 5 2023 at 10:45:27 PM +02:00:00, Jernej Škrabec 
<jernej.skrabec@gmail.com> wrote:
> On Thursday, August 24, 2023 10:48:20 PM CEST Martin Botka wrote:
>>  On Mon, Aug 14 2023 at 12:47:59 PM +02:00:00, Martin Botka
>> 
>>  <martin.botka@somainline.org> wrote:
>>  > On Mon, Aug 14 2023 at 12:26:07 PM +02:00:00, Jernej Škrabec
>>  >
>>  > <jernej.skrabec@gmail.com> wrote:
>>  >> Dne nedelja, 13. avgust 2023 ob 18:22:49 CEST je Martin Botka
>>  >>
>>  >> \x7fnapisal(a):
>>  >>>  On Sun, Aug 13 2023 at 05:55:35 PM +02:00:00, Jernej Škrabec
>>  >>>
>>  >>>  <jernej.skrabec@gmail.com> wrote:
>>  >>>  > Dne ponedeljek, 07. avgust 2023 ob 16:53:24 CEST je Martin 
>> Botka
>>  >>>  >
>>  >>>  > napisal(a):
>>  >>>  >>  The BigTreeTech Pi is an H616 based board based on CB1.
>>  >>>  >>  Just in Rpi format board.
>>  >>>  >>
>>  >>>  >>  It features the same internals as BTT CB1 but adds:
>>  >>>  >>      - Fan port
>>  >>>  >>      - IR receiver
>>  >>>  >>      - ADXL345 Accelerometer connector via SPI
>>  >>>  >>      - 24V DC power supply via terminal plugs
>>  >>>  >>      - USB to CAN module connector (The actual USB to CAN
>>  >>>
>>  >>> \x7f\x7fhappens on
>>  >>>
>>  >>>  >> the
>>  >>>  >>
>>  >>>  >>  external module)
>>  >>>  >>
>>  >>>  >>  List of currently working things is same as BTT CB1 but 
>> also:
>>  >>>  >>      - IR receiver
>>  >>>  >>      - ADXL345 connector
>>  >>>  >>
>>  >>>  >>  Signed-off-by: Martin Botka <martin@biqu3d.com>
>>  >>>  >>  Reviewed-by: Andre Przywara <andre.przywara@arm.com>
>>  >>>  >>  ---
>>  >>>  >>
>>  >>>  >>  Changes in V2:
>>  >>>  >>      - Add UART alongside aliases and chosen for it
>>  >>>  >>      - Add model string
>>  >>>  >>      - Enable IR receiver
>>  >>>  >>      - Enable SPI0 for ADXL345 connector
>>  >>>  >>
>>  >>>  >>  Changes in V3:
>>  >>>  >>      - Add missing semicolons
>>  >>>  >>      - Add pinctrl for SPI0
>>  >>>  >>
>>  >>>  >>   arch/arm64/boot/dts/allwinner/Makefile        |  1 +
>>  >>>  >>   .../allwinner/sun50i-h616-bigtreetech-pi.dts  | 70
>>  >>>  >>
>>  >>>  >> +++++++++++++++++++
>>  >>>  >>
>>  >>>  >>   2 files changed, 71 insertions(+)
>>  >>>  >>   create mode 100644
>>  >>>  >>
>>  >>>  >>  
>> arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
>>  >>>  >>
>>  >>>  >>  diff --git a/arch/arm64/boot/dts/allwinner/Makefile
>>  >>>  >>  b/arch/arm64/boot/dts/allwinner/Makefile index
>>  >>>  >>
>>  >>>  >> 7b386428510b..0b6232a7f328
>>  >>>  >>
>>  >>>  >>  100644
>>  >>>  >>  --- a/arch/arm64/boot/dts/allwinner/Makefile
>>  >>>  >>  +++ b/arch/arm64/boot/dts/allwinner/Makefile
>>  >>>  >>  @@ -39,5 +39,6 @@ dtb-$(CONFIG_ARCH_SUNXI) +=
>>  >>>  >>
>>  >>>  >> sun50i-h6-pine-h64-model-b.dtb
>>  >>>  >>
>>  >>>  >>  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb
>>  >>>  >>
>>  >>>  >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6-mini.dtb
>>  >>>  >>   dtb-$(CONFIG_ARCH_SUNXI) +=
>>  >>>
>>  >>> \x7f\x7fsun50i-h616-bigtreetech-cb1-manta.dtb
>>  >>>
>>  >>>  >>  +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-pi.dtb
>>  >>>  >>
>>  >>>  >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb
>>  >>>  >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb
>>  >>>  >>
>>  >>>  >>  diff --git
>>  >>>  >>
>>  >>>  >> 
>> a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
>>  >>>  >>
>>  >>>  >>  
>> b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
>>  >>>
>>  >>> \x7f\x7fnew
>>  >>>
>>  >>>  >> file
>>  >>>  >>
>>  >>>  >>  mode 100644
>>  >>>  >>  index 000000000000..b0d0386e8f13
>>  >>>  >>  --- /dev/null
>>  >>>  >>  +++
>>  >>>
>>  >>> \x7f\x7fb/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
>>  >>>
>>  >>>  >>  @@ -0,0 +1,70 @@
>>  >>>  >>  +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
>>  >>>  >>  +/*
>>  >>>  >>  + * Copyright (C) 2023 Martin Botka <martin@biqu3d.com>.
>>  >>>  >>  + */
>>  >>>  >>  +
>>  >>>  >>  +/dts-v1/;
>>  >>>  >>  +
>>  >>>  >>  +#include "sun50i-h616-bigtreetech-cb1.dtsi"
>>  >>>  >>  +
>>  >>>  >>  +/ {
>>  >>>  >>  +	model = "BigTreeTech Pi";
>>  >>>  >>  +	compatible = "bigtreetech,pi", "allwinner,sun50i-h616";
>>  >>>  >>  +
>>  >>>  >>  +	aliases {
>>  >>>  >>  +		serial0 = &uart0;
>>  >>>  >>  +	};
>>  >>>  >>  +
>>  >>>  >>  +	chosen {
>>  >>>  >>  +		stdout-path = "serial0:115200n8";
>>  >>>  >>  +	};
>>  >>>  >>  +};
>>  >>>  >>  +
>>  >>>  >>  +&ehci0 {
>>  >>>  >>  +	status = "okay";
>>  >>>  >>  +};
>>  >>>  >>  +
>>  >>>  >>  +&ehci1 {
>>  >>>  >>  +	status = "okay";
>>  >>>  >>  +};
>>  >>>  >>  +
>>  >>>  >>  +&ehci2 {
>>  >>>  >>  +	status = "okay";
>>  >>>  >>  +};
>>  >>>  >>  +
>>  >>>  >>  +&ehci3 {
>>  >>>  >>  +	status = "okay";
>>  >>>  >>  +};
>>  >>>  >>  +
>>  >>>  >>  +&ir {
>>  >>>  >>  +	status = "okay";
>>  >>>  >>  +};
>>  >>>  >>  +
>>  >>>  >>  +&ohci0 {
>>  >>>  >>  +	status = "okay";
>>  >>>  >>  +};
>>  >>>  >>  +
>>  >>>  >>  +&ohci1 {
>>  >>>  >>  +	status = "okay";
>>  >>>  >>  +};
>>  >>>  >>  +
>>  >>>  >>  +&ohci2 {
>>  >>>  >>  +	status = "okay";
>>  >>>  >>  +};
>>  >>>  >>  +
>>  >>>  >>  +&ohci3 {
>>  >>>  >>  +	status = "okay";
>>  >>>  >>  +};
>>  >>>  >>  +
>>  >>>  >>  +&spi0 {
>>  >>>  >>  +	/* SPI connection for onboard connector for ADXL345
>>  >>>
>>  >>> \x7f\x7faccelerometer
>>  >>>
>>  >>>  > */
>>  >>>  >
>>  >>>  >>  +	status = "okay";
>>  >>>  >>  +	pinctrl-names = "default";
>>  >>>  >>  +	pinctrl-0 = <&spi0_pins>, <&spi0_cs0_pin>;
>>  >>>  >
>>  >>>  > Driver and compatible for ADXL345 already exists, why don't 
>> you
>>  >>>
>>  >>> \x7f\x7fadd
>>  >>>
>>  >>>  > child node
>>  >>>  > for it?
>>  >>>  >
>>  >>>  > Best regards,
>>  >>>  > Jernej
>>  >>>
>>  >>>  Ah. So the ADXL345 actually wont be driven by kernel.
>>  >>
>>  >> DT is hardware description, it's not concerned what is done on
>>  >> \x7fsoftware side,
>>  >> either kernel or user space.
>>  >
>>  > Im aware. But this is not a device that is on the board. Its 
>> simply a
>>  > connector for the device.
>>  > Like Rpi has connectors for camera module :)
> 
> Actually it matters only if this other board is firmly connected with 
> base
> board. If it is not, then SPI node should be dropped and be handled 
> with DT
> overlays.
Got it. Will drop it then.
> 
>>  >
>>  >>>  The SPI connection is enabled so that klipper (3d printer
>>  >>>
>>  >>> firmware) \x7f\x7fcan
>>  >>>
>>  >>>  be told to look for ADXL345 at this SPI and use it on its own.
>>  >>>
>>  >>>  Klipper will initialize and communicate with the ADXL on its 
>> own.
>>  >>
>>  >> What do you mean by firmware? User space app? In this case I 
>> suppose
>>  >> \x7fyou'll use
>>  >> direct SPI commands from user space? AFAIK that's less and less
>>  >> \x7fsupported by
>>  >> kernel (in contrast to I2C).
>>  >
>>  > Firmware as in 3d printer firmware. Klipper runs on the board 
>> (CB1 or
>>  > BTT Pi) and is indeed an userspace app.
>>  > And indeed uses direct SPI commands to the device.
>>  >
>>  > The reason for this is the flexibility.
>>  > If Klipper read the values from kernel or well from the files the
>>  > ADXL driver would create
>>  > then it would be unable to communicate with ADXL that is on 
>> toolhead
>>  > board. Or would have to have
>>  > direct initialization either way for those. Thus it just controls 
>> the
>>  > ADXL itself :)
>>  >
>>  > I understand that this may be bit confusing. If there is still
>>  > something not clear im more then happy to explain in
>>  > full detail how the userspace and 3D printer communicate :)
> 
> As I said, DT doesn't care about implementation. DT is HW 
> description, so
> either if it's fixed connection (soldered wires), then describe in 
> full,
> otherwise it's considered addon board and thus non-essential, so it 
> should be
> handled with DT overlays.
OK
> 
> Can be CB1 bought separately from 3D printer package and thus used 
> without
> ADXL sensor?
Yes
> 
>>  >
>>  > Cheers,
>>  > Martin.
>> 
>>  Hello,
>>  Jernej any comments on this ?
>>  I would like to resolve this conversation :)
>>  We do have a bunch of time before the new cycle but never hurts to 
>> get
>>  it figured out ahead of time :)
> 
> Sorry, not enough free time over summer.
No worries :)

Cheers,
Martin
> 
> Best regards,
> Jernej
> 
>> 
>>  Cheers,
>>  Martin
>> 
>>  >> Best regards,
>>  >> Jernej
>>  >>
>>  >>>  >>  +};
>>  >>>  >>  +
>>  >>>  >>  +&uart0 {
>>  >>>  >>  +	pinctrl-names = "default";
>>  >>>  >>  +	pinctrl-0 = <&uart0_ph_pins>;
>>  >>>  >>  +	status = "okay";
>>  >>>  >>  +};
> 
> 
> 
> 



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 4/4] arm64: dts: allwinner: h616: Add BigTreeTech Pi support

[Andre Przywara]

On Tue, 05 Sep 2023 22:45:27 +0200
Jernej Škrabec <jernej.skrabec@gmail.com> wrote:

Hi,

> On Thursday, August 24, 2023 10:48:20 PM CEST Martin Botka wrote:
> > On Mon, Aug 14 2023 at 12:47:59 PM +02:00:00, Martin Botka
> > 
> > <martin.botka@somainline.org> wrote:  
> > > On Mon, Aug 14 2023 at 12:26:07 PM +02:00:00, Jernej Škrabec
> > > 
> > > <jernej.skrabec@gmail.com> wrote:  
> > >> Dne nedelja, 13. avgust 2023 ob 18:22:49 CEST je Martin Botka
> > >> 
> > >> \x7fnapisal(a):  
> > >>>  On Sun, Aug 13 2023 at 05:55:35 PM +02:00:00, Jernej Škrabec
> > >>>  
> > >>>  <jernej.skrabec@gmail.com> wrote:  
> > >>>  > Dne ponedeljek, 07. avgust 2023 ob 16:53:24 CEST je Martin Botka
> > >>>  > 
> > >>>  > napisal(a):  
> > >>>  >>  The BigTreeTech Pi is an H616 based board based on CB1.
> > >>>  >>  Just in Rpi format board.
> > >>>  >>  
> > >>>  >>  It features the same internals as BTT CB1 but adds:
> > >>>  >>      - Fan port
> > >>>  >>      - IR receiver
> > >>>  >>      - ADXL345 Accelerometer connector via SPI
> > >>>  >>      - 24V DC power supply via terminal plugs
> > >>>  >>      - USB to CAN module connector (The actual USB to CAN  
> > >>> 
> > >>> \x7f\x7fhappens on
> > >>>   
> > >>>  >> the
> > >>>  >> 
> > >>>  >>  external module)
> > >>>  >>  
> > >>>  >>  List of currently working things is same as BTT CB1 but also:
> > >>>  >>      - IR receiver
> > >>>  >>      - ADXL345 connector
> > >>>  >>  
> > >>>  >>  Signed-off-by: Martin Botka <martin@biqu3d.com>
> > >>>  >>  Reviewed-by: Andre Przywara <andre.przywara@arm.com>
> > >>>  >>  ---
> > >>>  >>  
> > >>>  >>  Changes in V2:
> > >>>  >>      - Add UART alongside aliases and chosen for it
> > >>>  >>      - Add model string
> > >>>  >>      - Enable IR receiver
> > >>>  >>      - Enable SPI0 for ADXL345 connector
> > >>>  >>  
> > >>>  >>  Changes in V3:
> > >>>  >>      - Add missing semicolons
> > >>>  >>      - Add pinctrl for SPI0
> > >>>  >>   
> > >>>  >>   arch/arm64/boot/dts/allwinner/Makefile        |  1 +
> > >>>  >>   .../allwinner/sun50i-h616-bigtreetech-pi.dts  | 70
> > >>>  >> 
> > >>>  >> +++++++++++++++++++
> > >>>  >> 
> > >>>  >>   2 files changed, 71 insertions(+)
> > >>>  >>   create mode 100644
> > >>>  >>  
> > >>>  >>  arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> > >>>  >>  
> > >>>  >>  diff --git a/arch/arm64/boot/dts/allwinner/Makefile
> > >>>  >>  b/arch/arm64/boot/dts/allwinner/Makefile index
> > >>>  >> 
> > >>>  >> 7b386428510b..0b6232a7f328
> > >>>  >> 
> > >>>  >>  100644
> > >>>  >>  --- a/arch/arm64/boot/dts/allwinner/Makefile
> > >>>  >>  +++ b/arch/arm64/boot/dts/allwinner/Makefile
> > >>>  >>  @@ -39,5 +39,6 @@ dtb-$(CONFIG_ARCH_SUNXI) +=
> > >>>  >> 
> > >>>  >> sun50i-h6-pine-h64-model-b.dtb
> > >>>  >> 
> > >>>  >>  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb
> > >>>  >>  
> > >>>  >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6-mini.dtb
> > >>>  >>   dtb-$(CONFIG_ARCH_SUNXI) +=  
> > >>> 
> > >>> \x7f\x7fsun50i-h616-bigtreetech-cb1-manta.dtb
> > >>>   
> > >>>  >>  +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-pi.dtb
> > >>>  >>  
> > >>>  >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb
> > >>>  >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb
> > >>>  >>  
> > >>>  >>  diff --git
> > >>>  >> 
> > >>>  >> a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> > >>>  >> 
> > >>>  >>  b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts  
> > >>> 
> > >>> \x7f\x7fnew
> > >>>   
> > >>>  >> file
> > >>>  >> 
> > >>>  >>  mode 100644
> > >>>  >>  index 000000000000..b0d0386e8f13
> > >>>  >>  --- /dev/null
> > >>>  >>  +++  
> > >>> 
> > >>> \x7f\x7fb/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> > >>>   
> > >>>  >>  @@ -0,0 +1,70 @@
> > >>>  >>  +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> > >>>  >>  +/*
> > >>>  >>  + * Copyright (C) 2023 Martin Botka <martin@biqu3d.com>.
> > >>>  >>  + */
> > >>>  >>  +
> > >>>  >>  +/dts-v1/;
> > >>>  >>  +
> > >>>  >>  +#include "sun50i-h616-bigtreetech-cb1.dtsi"
> > >>>  >>  +
> > >>>  >>  +/ {
> > >>>  >>  +	model = "BigTreeTech Pi";
> > >>>  >>  +	compatible = "bigtreetech,pi", "allwinner,sun50i-h616";
> > >>>  >>  +
> > >>>  >>  +	aliases {
> > >>>  >>  +		serial0 = &uart0;
> > >>>  >>  +	};
> > >>>  >>  +
> > >>>  >>  +	chosen {
> > >>>  >>  +		stdout-path = "serial0:115200n8";
> > >>>  >>  +	};
> > >>>  >>  +};
> > >>>  >>  +
> > >>>  >>  +&ehci0 {
> > >>>  >>  +	status = "okay";
> > >>>  >>  +};
> > >>>  >>  +
> > >>>  >>  +&ehci1 {
> > >>>  >>  +	status = "okay";
> > >>>  >>  +};
> > >>>  >>  +
> > >>>  >>  +&ehci2 {
> > >>>  >>  +	status = "okay";
> > >>>  >>  +};
> > >>>  >>  +
> > >>>  >>  +&ehci3 {
> > >>>  >>  +	status = "okay";
> > >>>  >>  +};
> > >>>  >>  +
> > >>>  >>  +&ir {
> > >>>  >>  +	status = "okay";
> > >>>  >>  +};
> > >>>  >>  +
> > >>>  >>  +&ohci0 {
> > >>>  >>  +	status = "okay";
> > >>>  >>  +};
> > >>>  >>  +
> > >>>  >>  +&ohci1 {
> > >>>  >>  +	status = "okay";
> > >>>  >>  +};
> > >>>  >>  +
> > >>>  >>  +&ohci2 {
> > >>>  >>  +	status = "okay";
> > >>>  >>  +};
> > >>>  >>  +
> > >>>  >>  +&ohci3 {
> > >>>  >>  +	status = "okay";
> > >>>  >>  +};
> > >>>  >>  +
> > >>>  >>  +&spi0 {
> > >>>  >>  +	/* SPI connection for onboard connector for ADXL345  
> > >>> 
> > >>> \x7f\x7faccelerometer
> > >>>   
> > >>>  > */
> > >>>  >   
> > >>>  >>  +	status = "okay";
> > >>>  >>  +	pinctrl-names = "default";
> > >>>  >>  +	pinctrl-0 = <&spi0_pins>, <&spi0_cs0_pin>;  
> > >>>  > 
> > >>>  > Driver and compatible for ADXL345 already exists, why don't you  
> > >>> 
> > >>> \x7f\x7fadd
> > >>>   
> > >>>  > child node
> > >>>  > for it?
> > >>>  > 
> > >>>  > Best regards,
> > >>>  > Jernej  
> > >>>  
> > >>>  Ah. So the ADXL345 actually wont be driven by kernel.  
> > >> 
> > >> DT is hardware description, it's not concerned what is done on
> > >> \x7fsoftware side,
> > >> either kernel or user space.  
> > > 
> > > Im aware. But this is not a device that is on the board. Its simply a
> > > connector for the device.
> > > Like Rpi has connectors for camera module :)  
> 
> Actually it matters only if this other board is firmly connected with base 
> board. If it is not, then SPI node should be dropped and be handled with DT 
> overlays.

So I do understand the reasoning behind not describing those generic pin
header connectors, where people could hook up anything, and use it as a
GPIO or as a special function device, but just wanted to check on this
situation:
Don't we even describe pins dedicated to those custom connectors,
especially if there is an "obvious" external device to connect to? Is it
the same situation like with these FPC camera connectors?

Cheers,
Andre

> > >>>  The SPI connection is enabled so that klipper (3d printer
> > >>> 
> > >>> firmware) \x7f\x7fcan
> > >>> 
> > >>>  be told to look for ADXL345 at this SPI and use it on its own.
> > >>>  
> > >>>  Klipper will initialize and communicate with the ADXL on its own.  
> > >> 
> > >> What do you mean by firmware? User space app? In this case I suppose
> > >> \x7fyou'll use
> > >> direct SPI commands from user space? AFAIK that's less and less
> > >> \x7fsupported by
> > >> kernel (in contrast to I2C).  
> > > 
> > > Firmware as in 3d printer firmware. Klipper runs on the board (CB1 or
> > > BTT Pi) and is indeed an userspace app.
> > > And indeed uses direct SPI commands to the device.
> > > 
> > > The reason for this is the flexibility.
> > > If Klipper read the values from kernel or well from the files the
> > > ADXL driver would create
> > > then it would be unable to communicate with ADXL that is on toolhead
> > > board. Or would have to have
> > > direct initialization either way for those. Thus it just controls the
> > > ADXL itself :)
> > > 
> > > I understand that this may be bit confusing. If there is still
> > > something not clear im more then happy to explain in
> > > full detail how the userspace and 3D printer communicate :)  
> 
> As I said, DT doesn't care about implementation. DT is HW description, so 
> either if it's fixed connection (soldered wires), then describe in full, 
> otherwise it's considered addon board and thus non-essential, so it should be 
> handled with DT overlays.
> 
> Can be CB1 bought separately from 3D printer package and thus used without 
> ADXL sensor?
> 
> > > 
> > > Cheers,
> > > Martin.  
> > 
> > Hello,
> > Jernej any comments on this ?
> > I would like to resolve this conversation :)
> > We do have a bunch of time before the new cycle but never hurts to get
> > it figured out ahead of time :)  
> 
> Sorry, not enough free time over summer.
> 
> Best regards,
> Jernej
> 
> > 
> > Cheers,
> > Martin
> >   
> > >> Best regards,
> > >> Jernej
> > >>   
> > >>>  >>  +};
> > >>>  >>  +
> > >>>  >>  +&uart0 {
> > >>>  >>  +	pinctrl-names = "default";
> > >>>  >>  +	pinctrl-0 = <&uart0_ph_pins>;
> > >>>  >>  +	status = "okay";
> > >>>  >>  +};  
> 
> 
> 
> 
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 4/4] arm64: dts: allwinner: h616: Add BigTreeTech Pi support

[Jernej Škrabec]

Dne sreda, 06. september 2023 ob 12:24:34 CEST je Andre Przywara napisal(a):
> On Tue, 05 Sep 2023 22:45:27 +0200
> Jernej Škrabec <jernej.skrabec@gmail.com> wrote:
> 
> Hi,
> 
> > On Thursday, August 24, 2023 10:48:20 PM CEST Martin Botka wrote:
> > > On Mon, Aug 14 2023 at 12:47:59 PM +02:00:00, Martin Botka
> > > 
> > > <martin.botka@somainline.org> wrote:
> > > > On Mon, Aug 14 2023 at 12:26:07 PM +02:00:00, Jernej Škrabec
> > > > 
> > > > <jernej.skrabec@gmail.com> wrote:
> > > >> Dne nedelja, 13. avgust 2023 ob 18:22:49 CEST je Martin Botka
> > > >> 
> > > >> \x7fnapisal(a):
> > > >>>  On Sun, Aug 13 2023 at 05:55:35 PM +02:00:00, Jernej Škrabec
> > > >>>  
> > > >>>  <jernej.skrabec@gmail.com> wrote:
> > > >>>  > Dne ponedeljek, 07. avgust 2023 ob 16:53:24 CEST je Martin Botka
> > > >>>  > 
> > > >>>  > napisal(a):
> > > >>>  >>  The BigTreeTech Pi is an H616 based board based on CB1.
> > > >>>  >>  Just in Rpi format board.
> > > >>>  >>  
> > > >>>  >>  It features the same internals as BTT CB1 but adds:
> > > >>>  >>      - Fan port
> > > >>>  >>      - IR receiver
> > > >>>  >>      - ADXL345 Accelerometer connector via SPI
> > > >>>  >>      - 24V DC power supply via terminal plugs
> > > >>>  >>      - USB to CAN module connector (The actual USB to CAN
> > > >>> 
> > > >>> \x7f\x7fhappens on
> > > >>> 
> > > >>>  >> the
> > > >>>  >> 
> > > >>>  >>  external module)
> > > >>>  >>  
> > > >>>  >>  List of currently working things is same as BTT CB1 but also:
> > > >>>  >>      - IR receiver
> > > >>>  >>      - ADXL345 connector
> > > >>>  >>  
> > > >>>  >>  Signed-off-by: Martin Botka <martin@biqu3d.com>
> > > >>>  >>  Reviewed-by: Andre Przywara <andre.przywara@arm.com>
> > > >>>  >>  ---
> > > >>>  >>  
> > > >>>  >>  Changes in V2:
> > > >>>  >>      - Add UART alongside aliases and chosen for it
> > > >>>  >>      - Add model string
> > > >>>  >>      - Enable IR receiver
> > > >>>  >>      - Enable SPI0 for ADXL345 connector
> > > >>>  >>  
> > > >>>  >>  Changes in V3:
> > > >>>  >>      - Add missing semicolons
> > > >>>  >>      - Add pinctrl for SPI0
> > > >>>  >>   
> > > >>>  >>   arch/arm64/boot/dts/allwinner/Makefile        |  1 +
> > > >>>  >>   .../allwinner/sun50i-h616-bigtreetech-pi.dts  | 70
> > > >>>  >> 
> > > >>>  >> +++++++++++++++++++
> > > >>>  >> 
> > > >>>  >>   2 files changed, 71 insertions(+)
> > > >>>  >>   create mode 100644
> > > >>>  >>  
> > > >>>  >>  arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> > > >>>  >>  
> > > >>>  >>  diff --git a/arch/arm64/boot/dts/allwinner/Makefile
> > > >>>  >>  b/arch/arm64/boot/dts/allwinner/Makefile index
> > > >>>  >> 
> > > >>>  >> 7b386428510b..0b6232a7f328
> > > >>>  >> 
> > > >>>  >>  100644
> > > >>>  >>  --- a/arch/arm64/boot/dts/allwinner/Makefile
> > > >>>  >>  +++ b/arch/arm64/boot/dts/allwinner/Makefile
> > > >>>  >>  @@ -39,5 +39,6 @@ dtb-$(CONFIG_ARCH_SUNXI) +=
> > > >>>  >> 
> > > >>>  >> sun50i-h6-pine-h64-model-b.dtb
> > > >>>  >> 
> > > >>>  >>  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6.dtb
> > > >>>  >>  
> > > >>>  >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-tanix-tx6-mini.dtb
> > > >>>  >>   dtb-$(CONFIG_ARCH_SUNXI) +=
> > > >>> 
> > > >>> \x7f\x7fsun50i-h616-bigtreetech-cb1-manta.dtb
> > > >>> 
> > > >>>  >>  +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-pi.dtb
> > > >>>  >>  
> > > >>>  >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb
> > > >>>  >>   dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb
> > > >>>  >>  
> > > >>>  >>  diff --git
> > > >>>  >> 
> > > >>>  >> a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> > > >>>  >> 
> > > >>>  >>  b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> > > >>> 
> > > >>> \x7f\x7fnew
> > > >>> 
> > > >>>  >> file
> > > >>>  >> 
> > > >>>  >>  mode 100644
> > > >>>  >>  index 000000000000..b0d0386e8f13
> > > >>>  >>  --- /dev/null
> > > >>>  >>  +++
> > > >>> 
> > > >>> \x7f\x7fb/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts
> > > >>> 
> > > >>>  >>  @@ -0,0 +1,70 @@
> > > >>>  >>  +// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> > > >>>  >>  +/*
> > > >>>  >>  + * Copyright (C) 2023 Martin Botka <martin@biqu3d.com>.
> > > >>>  >>  + */
> > > >>>  >>  +
> > > >>>  >>  +/dts-v1/;
> > > >>>  >>  +
> > > >>>  >>  +#include "sun50i-h616-bigtreetech-cb1.dtsi"
> > > >>>  >>  +
> > > >>>  >>  +/ {
> > > >>>  >>  +	model = "BigTreeTech Pi";
> > > >>>  >>  +	compatible = "bigtreetech,pi", "allwinner,sun50i-
h616";
> > > >>>  >>  +
> > > >>>  >>  +	aliases {
> > > >>>  >>  +		serial0 = &uart0;
> > > >>>  >>  +	};
> > > >>>  >>  +
> > > >>>  >>  +	chosen {
> > > >>>  >>  +		stdout-path = "serial0:115200n8";
> > > >>>  >>  +	};
> > > >>>  >>  +};
> > > >>>  >>  +
> > > >>>  >>  +&ehci0 {
> > > >>>  >>  +	status = "okay";
> > > >>>  >>  +};
> > > >>>  >>  +
> > > >>>  >>  +&ehci1 {
> > > >>>  >>  +	status = "okay";
> > > >>>  >>  +};
> > > >>>  >>  +
> > > >>>  >>  +&ehci2 {
> > > >>>  >>  +	status = "okay";
> > > >>>  >>  +};
> > > >>>  >>  +
> > > >>>  >>  +&ehci3 {
> > > >>>  >>  +	status = "okay";
> > > >>>  >>  +};
> > > >>>  >>  +
> > > >>>  >>  +&ir {
> > > >>>  >>  +	status = "okay";
> > > >>>  >>  +};
> > > >>>  >>  +
> > > >>>  >>  +&ohci0 {
> > > >>>  >>  +	status = "okay";
> > > >>>  >>  +};
> > > >>>  >>  +
> > > >>>  >>  +&ohci1 {
> > > >>>  >>  +	status = "okay";
> > > >>>  >>  +};
> > > >>>  >>  +
> > > >>>  >>  +&ohci2 {
> > > >>>  >>  +	status = "okay";
> > > >>>  >>  +};
> > > >>>  >>  +
> > > >>>  >>  +&ohci3 {
> > > >>>  >>  +	status = "okay";
> > > >>>  >>  +};
> > > >>>  >>  +
> > > >>>  >>  +&spi0 {
> > > >>>  >>  +	/* SPI connection for onboard connector for ADXL345
> > > >>> 
> > > >>> \x7f\x7faccelerometer
> > > >>> 
> > > >>>  > */
> > > >>>  > 
> > > >>>  >>  +	status = "okay";
> > > >>>  >>  +	pinctrl-names = "default";
> > > >>>  >>  +	pinctrl-0 = <&spi0_pins>, <&spi0_cs0_pin>;
> > > >>>  > 
> > > >>>  > Driver and compatible for ADXL345 already exists, why don't you
> > > >>> 
> > > >>> \x7f\x7fadd
> > > >>> 
> > > >>>  > child node
> > > >>>  > for it?
> > > >>>  > 
> > > >>>  > Best regards,
> > > >>>  > Jernej
> > > >>>  
> > > >>>  Ah. So the ADXL345 actually wont be driven by kernel.
> > > >> 
> > > >> DT is hardware description, it's not concerned what is done on
> > > >> \x7fsoftware side,
> > > >> either kernel or user space.
> > > > 
> > > > Im aware. But this is not a device that is on the board. Its simply a
> > > > connector for the device.
> > > > Like Rpi has connectors for camera module :)
> > 
> > Actually it matters only if this other board is firmly connected with base
> > board. If it is not, then SPI node should be dropped and be handled with
> > DT
> > overlays.
> 
> So I do understand the reasoning behind not describing those generic pin
> header connectors, where people could hook up anything, and use it as a
> GPIO or as a special function device, but just wanted to check on this
> situation:
> Don't we even describe pins dedicated to those custom connectors,
> especially if there is an "obvious" external device to connect to? Is it
> the same situation like with these FPC camera connectors?

I would say yes. SPI connector can still be used as GPIOs or anything else, 
since there is no device soldered directly to it.

Best regards,
Jernej

> 
> Cheers,
> Andre
> 
> > > >>>  The SPI connection is enabled so that klipper (3d printer
> > > >>> 
> > > >>> firmware) \x7f\x7fcan
> > > >>> 
> > > >>>  be told to look for ADXL345 at this SPI and use it on its own.
> > > >>>  
> > > >>>  Klipper will initialize and communicate with the ADXL on its own.
> > > >> 
> > > >> What do you mean by firmware? User space app? In this case I suppose
> > > >> \x7fyou'll use
> > > >> direct SPI commands from user space? AFAIK that's less and less
> > > >> \x7fsupported by
> > > >> kernel (in contrast to I2C).
> > > > 
> > > > Firmware as in 3d printer firmware. Klipper runs on the board (CB1 or
> > > > BTT Pi) and is indeed an userspace app.
> > > > And indeed uses direct SPI commands to the device.
> > > > 
> > > > The reason for this is the flexibility.
> > > > If Klipper read the values from kernel or well from the files the
> > > > ADXL driver would create
> > > > then it would be unable to communicate with ADXL that is on toolhead
> > > > board. Or would have to have
> > > > direct initialization either way for those. Thus it just controls the
> > > > ADXL itself :)
> > > > 
> > > > I understand that this may be bit confusing. If there is still
> > > > something not clear im more then happy to explain in
> > > > full detail how the userspace and 3D printer communicate :)
> > 
> > As I said, DT doesn't care about implementation. DT is HW description, so
> > either if it's fixed connection (soldered wires), then describe in full,
> > otherwise it's considered addon board and thus non-essential, so it should
> > be handled with DT overlays.
> > 
> > Can be CB1 bought separately from 3D printer package and thus used without
> > ADXL sensor?
> > 
> > > > Cheers,
> > > > Martin.
> > > 
> > > Hello,
> > > Jernej any comments on this ?
> > > I would like to resolve this conversation :)
> > > We do have a bunch of time before the new cycle but never hurts to get
> > > it figured out ahead of time :)
> > 
> > Sorry, not enough free time over summer.
> > 
> > Best regards,
> > Jernej
> > 
> > > Cheers,
> > > Martin
> > > 
> > > >> Best regards,
> > > >> Jernej
> > > >> 
> > > >>>  >>  +};
> > > >>>  >>  +
> > > >>>  >>  +&uart0 {
> > > >>>  >>  +	pinctrl-names = "default";
> > > >>>  >>  +	pinctrl-0 = <&uart0_ph_pins>;
> > > >>>  >>  +	status = "okay";
> > > >>>  >>  +};





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel