* [PATCH 1/2] arm64: dts: imx8mp: Move funnel outside from soc
@ 2023-09-06 11:54 Fabio Estevam
2023-09-06 11:54 ` [PATCH 2/2] arm64: dts: imx8mq: " Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Fabio Estevam @ 2023-09-06 11:54 UTC (permalink / raw)
To: shawnguo
Cc: linux-arm-kernel, devicetree, krzysztof.kozlowski+dt, robh+dt,
conor+dt, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
The 'funnel' node does not contain a register range, so it should
be placed outside of the soc node to fix schema warnings from
simple-bus.yaml.
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 107 +++++++++++-----------
1 file changed, 54 insertions(+), 53 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 6f2f50e1639c..ee92043a4052 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -202,6 +202,60 @@ clk_ext4: clock-ext4 {
clock-output-names = "clk_ext4";
};
+ funnel {
+ /*
+ * non-configurable funnel don't show up on the AMBA
+ * bus. As such no need to add "arm,primecell".
+ */
+ compatible = "arm,coresight-static-funnel";
+
+ in-ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ ca_funnel_in_port0: endpoint {
+ remote-endpoint = <&etm0_out_port>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ ca_funnel_in_port1: endpoint {
+ remote-endpoint = <&etm1_out_port>;
+ };
+ };
+
+ port@2 {
+ reg = <2>;
+
+ ca_funnel_in_port2: endpoint {
+ remote-endpoint = <&etm2_out_port>;
+ };
+ };
+
+ port@3 {
+ reg = <3>;
+
+ ca_funnel_in_port3: endpoint {
+ remote-endpoint = <&etm3_out_port>;
+ };
+ };
+ };
+
+ out-ports {
+ port {
+
+ ca_funnel_out_port0: endpoint {
+ remote-endpoint = <&hugo_funnel_in_port0>;
+ };
+ };
+ };
+ };
+
reserved-memory {
#address-cells = <2>;
#size-cells = <2>;
@@ -368,59 +422,6 @@ etm3_out_port: endpoint {
};
};
- funnel {
- /*
- * non-configurable funnel don't show up on the AMBA
- * bus. As such no need to add "arm,primecell".
- */
- compatible = "arm,coresight-static-funnel";
-
- in-ports {
- #address-cells = <1>;
- #size-cells = <0>;
-
- port@0 {
- reg = <0>;
-
- ca_funnel_in_port0: endpoint {
- remote-endpoint = <&etm0_out_port>;
- };
- };
-
- port@1 {
- reg = <1>;
-
- ca_funnel_in_port1: endpoint {
- remote-endpoint = <&etm1_out_port>;
- };
- };
-
- port@2 {
- reg = <2>;
-
- ca_funnel_in_port2: endpoint {
- remote-endpoint = <&etm2_out_port>;
- };
- };
-
- port@3 {
- reg = <3>;
-
- ca_funnel_in_port3: endpoint {
- remote-endpoint = <&etm3_out_port>;
- };
- };
- };
-
- out-ports {
- port {
- ca_funnel_out_port0: endpoint {
- remote-endpoint = <&hugo_funnel_in_port0>;
- };
- };
- };
- };
-
funnel@28c03000 {
compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
reg = <0x28c03000 0x1000>;
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] arm64: dts: imx8mq: Move funnel outside from soc
2023-09-06 11:54 [PATCH 1/2] arm64: dts: imx8mp: Move funnel outside from soc Fabio Estevam
@ 2023-09-06 11:54 ` Fabio Estevam
2023-09-07 6:43 ` Alexander Stein
2023-09-07 6:42 ` [PATCH 1/2] arm64: dts: imx8mp: " Alexander Stein
2023-09-25 1:41 ` Shawn Guo
2 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2023-09-06 11:54 UTC (permalink / raw)
To: shawnguo
Cc: linux-arm-kernel, devicetree, krzysztof.kozlowski+dt, robh+dt,
conor+dt, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
The 'funnel' node does not contain a register range, so it should
be placed outside of the soc node to fix schema warnings from
simple-bus.yaml.
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 106 +++++++++++-----------
1 file changed, 53 insertions(+), 53 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 35f07dfb4ca8..4b1ce9fc1758 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -225,6 +225,59 @@ opp-1500000000 {
};
};
+ funnel {
+ /*
+ * non-configurable funnel don't show up on the AMBA
+ * bus. As such no need to add "arm,primecell".
+ */
+ compatible = "arm,coresight-static-funnel";
+
+ in-ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ ca_funnel_in_port0: endpoint {
+ remote-endpoint = <&etm0_out_port>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ ca_funnel_in_port1: endpoint {
+ remote-endpoint = <&etm1_out_port>;
+ };
+ };
+
+ port@2 {
+ reg = <2>;
+
+ ca_funnel_in_port2: endpoint {
+ remote-endpoint = <&etm2_out_port>;
+ };
+ };
+
+ port@3 {
+ reg = <3>;
+
+ ca_funnel_in_port3: endpoint {
+ remote-endpoint = <&etm3_out_port>;
+ };
+ };
+ };
+
+ out-ports {
+ port {
+ ca_funnel_out_port0: endpoint {
+ remote-endpoint = <&hugo_funnel_in_port0>;
+ };
+ };
+ };
+ };
+
pmu {
compatible = "arm,cortex-a53-pmu";
interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
@@ -394,59 +447,6 @@ etm3_out_port: endpoint {
};
};
- funnel {
- /*
- * non-configurable funnel don't show up on the AMBA
- * bus. As such no need to add "arm,primecell".
- */
- compatible = "arm,coresight-static-funnel";
-
- in-ports {
- #address-cells = <1>;
- #size-cells = <0>;
-
- port@0 {
- reg = <0>;
-
- ca_funnel_in_port0: endpoint {
- remote-endpoint = <&etm0_out_port>;
- };
- };
-
- port@1 {
- reg = <1>;
-
- ca_funnel_in_port1: endpoint {
- remote-endpoint = <&etm1_out_port>;
- };
- };
-
- port@2 {
- reg = <2>;
-
- ca_funnel_in_port2: endpoint {
- remote-endpoint = <&etm2_out_port>;
- };
- };
-
- port@3 {
- reg = <3>;
-
- ca_funnel_in_port3: endpoint {
- remote-endpoint = <&etm3_out_port>;
- };
- };
- };
-
- out-ports {
- port {
- ca_funnel_out_port0: endpoint {
- remote-endpoint = <&hugo_funnel_in_port0>;
- };
- };
- };
- };
-
funnel@28c03000 {
compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
reg = <0x28c03000 0x1000>;
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] arm64: dts: imx8mq: Move funnel outside from soc
2023-09-06 11:54 ` [PATCH 2/2] arm64: dts: imx8mq: " Fabio Estevam
@ 2023-09-07 6:43 ` Alexander Stein
0 siblings, 0 replies; 5+ messages in thread
From: Alexander Stein @ 2023-09-07 6:43 UTC (permalink / raw)
To: shawnguo, linux-arm-kernel
Cc: linux-arm-kernel, devicetree, krzysztof.kozlowski+dt, robh+dt,
conor+dt, Fabio Estevam, Fabio Estevam
Am Mittwoch, 6. September 2023, 13:54:44 CEST schrieb Fabio Estevam:
> From: Fabio Estevam <festevam@denx.de>
>
> The 'funnel' node does not contain a register range, so it should
> be placed outside of the soc node to fix schema warnings from
> simple-bus.yaml.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
I noticed the warning in dtbs_check as well. LGTM
Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 106 +++++++++++-----------
> 1 file changed, 53 insertions(+), 53 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mq.dtsi index
> 35f07dfb4ca8..4b1ce9fc1758 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -225,6 +225,59 @@ opp-1500000000 {
> };
> };
>
> + funnel {
> + /*
> + * non-configurable funnel don't show up on the AMBA
> + * bus. As such no need to add "arm,primecell".
> + */
> + compatible = "arm,coresight-static-funnel";
> +
> + in-ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> +
> + ca_funnel_in_port0: endpoint {
> + remote-endpoint =
<&etm0_out_port>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> +
> + ca_funnel_in_port1: endpoint {
> + remote-endpoint =
<&etm1_out_port>;
> + };
> + };
> +
> + port@2 {
> + reg = <2>;
> +
> + ca_funnel_in_port2: endpoint {
> + remote-endpoint =
<&etm2_out_port>;
> + };
> + };
> +
> + port@3 {
> + reg = <3>;
> +
> + ca_funnel_in_port3: endpoint {
> + remote-endpoint =
<&etm3_out_port>;
> + };
> + };
> + };
> +
> + out-ports {
> + port {
> + ca_funnel_out_port0: endpoint {
> + remote-endpoint =
<&hugo_funnel_in_port0>;
> + };
> + };
> + };
> + };
> +
> pmu {
> compatible = "arm,cortex-a53-pmu";
> interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
> @@ -394,59 +447,6 @@ etm3_out_port: endpoint {
> };
> };
>
> - funnel {
> - /*
> - * non-configurable funnel don't show up on the
AMBA
> - * bus. As such no need to add "arm,primecell".
> - */
> - compatible = "arm,coresight-static-funnel";
> -
> - in-ports {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - port@0 {
> - reg = <0>;
> -
> - ca_funnel_in_port0: endpoint
{
> - remote-endpoint =
<&etm0_out_port>;
> - };
> - };
> -
> - port@1 {
> - reg = <1>;
> -
> - ca_funnel_in_port1: endpoint
{
> - remote-endpoint =
<&etm1_out_port>;
> - };
> - };
> -
> - port@2 {
> - reg = <2>;
> -
> - ca_funnel_in_port2: endpoint
{
> - remote-endpoint =
<&etm2_out_port>;
> - };
> - };
> -
> - port@3 {
> - reg = <3>;
> -
> - ca_funnel_in_port3: endpoint
{
> - remote-endpoint =
<&etm3_out_port>;
> - };
> - };
> - };
> -
> - out-ports {
> - port {
> - ca_funnel_out_port0:
endpoint {
> - remote-endpoint =
<&hugo_funnel_in_port0>;
> - };
> - };
> - };
> - };
> -
> funnel@28c03000 {
> compatible = "arm,coresight-dynamic-funnel",
"arm,primecell";
> reg = <0x28c03000 0x1000>;
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] arm64: dts: imx8mp: Move funnel outside from soc
2023-09-06 11:54 [PATCH 1/2] arm64: dts: imx8mp: Move funnel outside from soc Fabio Estevam
2023-09-06 11:54 ` [PATCH 2/2] arm64: dts: imx8mq: " Fabio Estevam
@ 2023-09-07 6:42 ` Alexander Stein
2023-09-25 1:41 ` Shawn Guo
2 siblings, 0 replies; 5+ messages in thread
From: Alexander Stein @ 2023-09-07 6:42 UTC (permalink / raw)
To: shawnguo, linux-arm-kernel, Fabio Estevam
Cc: linux-arm-kernel, devicetree, krzysztof.kozlowski+dt, robh+dt,
conor+dt, Fabio Estevam
Hi Fabio,
Am Mittwoch, 6. September 2023, 13:54:43 CEST schrieb Fabio Estevam:
> From: Fabio Estevam <festevam@denx.de>
>
> The 'funnel' node does not contain a register range, so it should
> be placed outside of the soc node to fix schema warnings from
> simple-bus.yaml.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
I noticed the warning in dtbs_check as well. LGTM
Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 107 +++++++++++-----------
> 1 file changed, 54 insertions(+), 53 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index
> 6f2f50e1639c..ee92043a4052 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -202,6 +202,60 @@ clk_ext4: clock-ext4 {
> clock-output-names = "clk_ext4";
> };
>
> + funnel {
> + /*
> + * non-configurable funnel don't show up on the AMBA
> + * bus. As such no need to add "arm,primecell".
> + */
> + compatible = "arm,coresight-static-funnel";
> +
> + in-ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> +
> + ca_funnel_in_port0: endpoint {
> + remote-endpoint =
<&etm0_out_port>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> +
> + ca_funnel_in_port1: endpoint {
> + remote-endpoint =
<&etm1_out_port>;
> + };
> + };
> +
> + port@2 {
> + reg = <2>;
> +
> + ca_funnel_in_port2: endpoint {
> + remote-endpoint =
<&etm2_out_port>;
> + };
> + };
> +
> + port@3 {
> + reg = <3>;
> +
> + ca_funnel_in_port3: endpoint
{
> + remote-endpoint =
<&etm3_out_port>;
> + };
> + };
> + };
> +
> + out-ports {
> + port {
> +
> + ca_funnel_out_port0: endpoint {
> + remote-endpoint =
<&hugo_funnel_in_port0>;
> + };
> + };
> + };
> + };
> +
> reserved-memory {
> #address-cells = <2>;
> #size-cells = <2>;
> @@ -368,59 +422,6 @@ etm3_out_port: endpoint {
> };
> };
>
> - funnel {
> - /*
> - * non-configurable funnel don't show up on the
AMBA
> - * bus. As such no need to add "arm,primecell".
> - */
> - compatible = "arm,coresight-static-funnel";
> -
> - in-ports {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - port@0 {
> - reg = <0>;
> -
> - ca_funnel_in_port0: endpoint
{
> - remote-endpoint =
<&etm0_out_port>;
> - };
> - };
> -
> - port@1 {
> - reg = <1>;
> -
> - ca_funnel_in_port1: endpoint
{
> - remote-endpoint =
<&etm1_out_port>;
> - };
> - };
> -
> - port@2 {
> - reg = <2>;
> -
> - ca_funnel_in_port2: endpoint
{
> - remote-endpoint =
<&etm2_out_port>;
> - };
> - };
> -
> - port@3 {
> - reg = <3>;
> -
> - ca_funnel_in_port3: endpoint
{
> - remote-endpoint =
<&etm3_out_port>;
> - };
> - };
> - };
> -
> - out-ports {
> - port {
> - ca_funnel_out_port0:
endpoint {
> - remote-endpoint =
<&hugo_funnel_in_port0>;
> - };
> - };
> - };
> - };
> -
> funnel@28c03000 {
> compatible = "arm,coresight-dynamic-funnel",
"arm,primecell";
> reg = <0x28c03000 0x1000>;
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] arm64: dts: imx8mp: Move funnel outside from soc
2023-09-06 11:54 [PATCH 1/2] arm64: dts: imx8mp: Move funnel outside from soc Fabio Estevam
2023-09-06 11:54 ` [PATCH 2/2] arm64: dts: imx8mq: " Fabio Estevam
2023-09-07 6:42 ` [PATCH 1/2] arm64: dts: imx8mp: " Alexander Stein
@ 2023-09-25 1:41 ` Shawn Guo
2 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2023-09-25 1:41 UTC (permalink / raw)
To: Fabio Estevam
Cc: linux-arm-kernel, devicetree, krzysztof.kozlowski+dt, robh+dt,
conor+dt, Fabio Estevam
On Wed, Sep 06, 2023 at 08:54:43AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> The 'funnel' node does not contain a register range, so it should
> be placed outside of the soc node to fix schema warnings from
> simple-bus.yaml.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Applied both, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-09-25 1:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-06 11:54 [PATCH 1/2] arm64: dts: imx8mp: Move funnel outside from soc Fabio Estevam
2023-09-06 11:54 ` [PATCH 2/2] arm64: dts: imx8mq: " Fabio Estevam
2023-09-07 6:43 ` Alexander Stein
2023-09-07 6:42 ` [PATCH 1/2] arm64: dts: imx8mp: " Alexander Stein
2023-09-25 1:41 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).