From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0C5EEE14BC for ; Wed, 6 Sep 2023 17:25:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=fOmgD0tkLawFncSqbJUNEawAun1lnOAtJFSC3TXEt10=; b=ST7fkkP+ktjPFQ LxdRKUecxb2th5d7DCdE3xf1ZMS+9e4csBi+osrnjyQUQKtmis6GC4fXztWD/H+eONr4KvSolK8VV UpmyRSBbc1hAFg+DhN8slc0FRaw9gUYSATEOT9ok0SzfwkzyVZNTfX/W//zs43jyNjchjx7ywrJYR /ATUQMinfqsnVP8TSGnpPg0YvExbnqOd4drOfHgbtd1ClmbWq0SuHyR4yYKkN89TzNPYOrBpNgYuZ u+p1x+lnwsM+icY5IzoaYBF1ekDQ7vXYN8fRJ51HUgHEbaTLWqpAybnuAYP0kGopkCzVXj+kcRIz/ kZJESvzCv+ZQwa54765g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qdwH7-00AbHs-26; Wed, 06 Sep 2023 17:25:09 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qdwH4-00AbHQ-1A for linux-arm-kernel@lists.infradead.org; Wed, 06 Sep 2023 17:25:08 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 00BC2B81B3B; Wed, 6 Sep 2023 17:25:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83100C433C7; Wed, 6 Sep 2023 17:25:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694021102; bh=EsgPusO5EdsCzpzdBeCjyhX7ExG7A6ZCjf1GCZSV5sw=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=PW8akcPROFzYnawVvMzQrcWGjSx2pO615gbZZuMYTcWzXxcTvb3QLGUbytZoQoyc0 0LPyzBQ7Fl1VsC2LFO1kPQuv59SsEqXLjiNPtjX8pP4Zmp5r4tvWyGPc5Lubhm4+cs wr8ynjUlU/Vf0OOrcSWAxsp3mOU8YU8QzU6C75QSzPl4oqRIz4T4s/HAschxl/GXEe FTYQbd1rck3WtNYmIAJ2Xj23DyRqZpW7sC6syrVV/VH1uwo+JsdsSEf5q/REHg2WNS etqaXz4Xa2gWiomyPMcoz1a1SKv2BtGVlV/9vIXZsSa4o8vE/hGZmYH5RfAnA7hkWp Ml7VbTUYiXwbw== Date: Wed, 6 Sep 2023 12:25:00 -0500 From: Bjorn Helgaas To: Thippeswamy Havalige Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bhelgaas@google.com, krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, robh@kernel.org, conor+dt@kernel.org, michal.simek@amd.com, bharat.kumar.gogada@amd.com Subject: Re: [PATCH v7 3/3] PCI: xilinx-xdma: Add Xilinx XDMA Root Port driver Message-ID: <20230906172500.GA231799@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230830090707.278136-4-thippeswamy.havalige@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230906_102506_566366_57EFAA16 X-CRM114-Status: GOOD ( 15.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 30, 2023 at 02:37:07PM +0530, Thippeswamy Havalige wrote: > Add support for Xilinx XDMA Soft IP core as Root Port. > > The Zynq UltraScale+ MPSoCs devices support XDMA soft IP module in > programmable logic. > > The integrated XDMA soft IP block has integrated bridge function that > can act as PCIe Root Port. > + if (!pci_is_root_bus(bus)) { > + /* Checking whether the link is up is the last line of > + * defense, and this check is inherently racy by definition. > + * Sending a PIO request to a downstream device when the link is > + * down causes an unrecoverable error, and a reset of the entire > + * PCIe controller will be needed. We can reduce the likelihood > + * of that unrecoverable error by checking whether the link is > + * up, but we can't completely prevent it because the link may > + * go down between the link-up check and the PIO request. > + */ Looks fine to me. If Lorenzo or Krzysztof thinks this is ready to go, maybe they will tidy the comment above, i.e., /* * Checking whether ... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel