From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16E6AEC8758 for ; Thu, 7 Sep 2023 20:55:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=r7nq2rCa/O6TU2AVh9o4wfhC70OS6T72nBavP+O0Vh8=; b=nlZetB0uutaq51du2+FcT8iu/X sKK6EN47wUERIGt4NOi/2wHRa6i6gv5iSKK1pfeB5CM4qN7BaXFgsHKdlnmOjj0tINq/jQwygianQ PrLe3aMhPDEV+/PSyG49pFKUtO8GgZLlJJO0BHCymRSGfRlaXhXnNALZ1HkmzqP6OtS4eT5Tv+wyM AcWdA76b4RpxPIyI0YCn9km8GUTlOQhyCZCkQuhl3LfxEkrmvZ6ES18fzQwWfZRHgVp3mn9uAVucj ACiZ359hdUfZb0ZrJ0i0pA2aSosg4X8QntEUhTgDHnnrRdoOHcCttuOUvPY2lX6a5g8Ec2743sIOU Phedr+7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qeM1Q-00Cg18-0h; Thu, 07 Sep 2023 20:54:40 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qeM1M-00Cg01-0k for linux-arm-kernel@lists.infradead.org; Thu, 07 Sep 2023 20:54:39 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qeM1F-0000v9-A8; Thu, 07 Sep 2023 22:54:29 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1qeM1E-004jKK-HG; Thu, 07 Sep 2023 22:54:28 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qeM1D-00HHCn-Tg; Thu, 07 Sep 2023 22:54:27 +0200 Date: Thu, 7 Sep 2023 22:54:27 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Dhruva Gole Cc: Nishanth Menon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tero Kristo , Santosh Shilimkar , Vignesh Raghavendra , vibhore@ti.com Subject: Re: [PATCH] firmware: ti_sci: Mark driver as non removable Message-ID: <20230907205427.tilwp6fk2q7hpfof@pengutronix.de> References: <20230907171700.1922453-1-d-gole@ti.com> MIME-Version: 1.0 In-Reply-To: <20230907171700.1922453-1-d-gole@ti.com> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230907_135436_264648_D8D81576 X-CRM114-Status: GOOD ( 18.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7245324592694652780==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7245324592694652780== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="eqnbnfzxrnfhtna3" Content-Disposition: inline --eqnbnfzxrnfhtna3 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, On Thu, Sep 07, 2023 at 10:47:00PM +0530, Dhruva Gole wrote: > The TI-SCI message protocol provides a way to communicate between > various compute processors with a central system controller entity. It > provides the fundamental device management capability and clock control > in the SOCs that it's used in. >=20 Maybe add: The remove function failed to do all the necessary cleanup if there are registered users. Some things are freed however which likely results in an oops later on. > Ensure that the driver isn't unbound by suppressing its bind and unbind > sysfs attributes. As the driver is built-in there is no way to remove > device once bound. >=20 > We can also remove the ti_sci_remove call along with the > ti_sci_debugfs_destroy as there are no callers for it any longer. >=20 > Fixes: aa276781a64a ("firmware: Add basic support for TI System Control I= nterface (TI-SCI) protocol") > Suggested-by: Uwe Kleine-K=F6nig > Signed-off-by: Dhruva Gole While this isn't the most elegant solution, this is probably the most feasible one. Acked-by: Uwe Kleine-K=F6nig (with or without the suggested addition to the commit log above). Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --eqnbnfzxrnfhtna3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmT6OIIACgkQj4D7WH0S /k7uigf9Fy8T7gOB8S67eFUtrBxEwOgLrSnRVjGZhrTS3UeJlOQ7evLsrZc4kRcW qwmGgBvPh3hoTo0gdMaamwUM8QGzxhv4LHHHkRUnv6jWyJ/u/x76oCqbWG48WmKt ueOcYNhYhy9L/EU6hI/GbnUzJ+aG9T0SzhqNjIGpM6v3BmzpJXdDSMK66f3Wb8t5 +8dafVVNdWjVFot/2f9s4se4lS2aVgXPJUkMeWpa88BlW8ufzQW4p7SsIh7fwqut lomS3u5bL6WWB3nVkV12urlhDzMIZtxmnkyFf4aYBtPgdvAmO0Tb02WMRjuWE0zN RmYk2GC9MDS+lDWAbfQSSWVYT282Kg== =b4Jr -----END PGP SIGNATURE----- --eqnbnfzxrnfhtna3-- --===============7245324592694652780== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7245324592694652780==--