From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C1CDEEB57A for ; Sat, 9 Sep 2023 01:11:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wh1g2lk0cx8XwlSz3MGVuobFAsLlIwbGURbeS9ZLwGs=; b=ZAgrrfnGQrgbfg KJuQbvAsfqqTCqhN76xYO4W53u3az3OFQpSkQtZUVWRDmGthf/c1W6WfyJFC8zi9TcSdZAkpxIzYX gmiZF2V1fFa2Butbqtechpn1v1cv79ojXXKFuhJo9XNkU6A3Uj7s0pPad7jqGoU3C2yiMgzKuLrPD mbLCJ1WOTTe1+oPv3jKDkFd0Oh0qUWQOrIT33NLvRtGIIXs5pqj1h9MU//4j6IY8MdZHeW8toaa8Z yTuLpXKtkj0H7ffHB4U2adFT82WKkqrozcjXESg4masMBuXIuMFMVGAyM9ShFUa0DKsnpk1KRHJ1P q/oYkfL4E20Ba7kgdeXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qemUb-00EpM4-24; Sat, 09 Sep 2023 01:10:33 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qemUY-00EpL6-0q for linux-arm-kernel@lists.infradead.org; Sat, 09 Sep 2023 01:10:31 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A0A4FB8206A; Sat, 9 Sep 2023 01:10:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE70CC433C7; Sat, 9 Sep 2023 01:10:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694221827; bh=kML9hZ7IDaG4XktJeZe7x8+x5w4mrLeBCCe8e1QV/lA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aEY6pwn2Yeo9yuQW7sBAUzeurEYWQEbrf1TSbgln+HHTWG2SjmzWtPJWHaHU99PfG 1BLtxCba3iXLP+xbQMnKCeyxTW3DGV38psO0doZlALLot6WZQrHgVjPr0A/nX2aSar 4rgXfcrn0IGyPPCM4E04o9hO62JO06oAISyEMBma7xcryXYfRcNsX+nmtQ26/Gw+fe AMmzV+Wh/Ld+j2+sJKSPVkaHZ26G1h+CSZgJI0tADDe+HUuxk9/LWAy6Kzw9zNjhKP NMvEbS3Qz1JqlBcTo9LtxPyeffaLqkoYq3X3XFif28aWLJXAxL1Pg8bPGDEyKJjBoJ s4JnLD6DaGwqg== Date: Fri, 8 Sep 2023 18:10:25 -0700 From: Jakub Kicinski To: Felix Fietkau Cc: Vincent Whitchurch , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Paolo Abeni , Maxime Coquelin , Maxim Mikityanskiy , , , , , Subject: Re: [PATCH net v2] net: stmmac: fix handling of zero coalescing tx-usecs Message-ID: <20230908181025.5a38c4f5@kernel.org> In-Reply-To: <20230907-stmmac-coaloff-v2-1-38ccfac548b9@axis.com> References: <20230907-stmmac-coaloff-v2-1-38ccfac548b9@axis.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230908_181030_463148_16E7D2E9 X-CRM114-Status: GOOD ( 12.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 7 Sep 2023 12:46:31 +0200 Vincent Whitchurch wrote: > Setting ethtool -C eth0 tx-usecs 0 is supposed to disable the use of the > coalescing timer but currently it gets programmed with zero delay > instead. > > Disable the use of the coalescing timer if tx-usecs is zero by > preventing it from being restarted. Note that to keep things simple we > don't start/stop the timer when the coalescing settings are changed, but > just let that happen on the next transmit or timer expiry. > > Fixes: 8fce33317023 ("net: stmmac: Rework coalesce timer and fix multi-queue races") > Signed-off-by: Vincent Whitchurch Felix, good enough? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel