From: Nishanth Menon <nm@ti.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Russell King (Oracle)" <linux@armlinux.org.uk>,
Andrew Davis <afd@ti.com>, Zhizhou Zhang <zhizhou.zh@gmail.com>,
<rppt@kernel.org>, <akpm@linux-foundation.org>,
<vishal.moola@gmail.com>, <arnd@arndb.de>,
<wangkefeng.wang@huawei.com>, <willy@infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Zhizhou Zhang <zhizhouzhang@asrmicro.com>
Subject: Re: [PATCH] ARM: mm: fix stack corruption when CONFIG_ARM_PV_FIXUP=y
Date: Mon, 11 Sep 2023 08:04:31 -0500 [thread overview]
Message-ID: <20230911130431.k35xp7gszgwqigl4@vendetta> (raw)
In-Reply-To: <CACRpkdYdf9H=LNRZMPurzTcA+bqoOHC1n-8TeCnVdz_iF7H+NA@mail.gmail.com>
On 23:00-20230908, Linus Walleij wrote:
> On Fri, Sep 8, 2023 at 3:50 PM Russell King (Oracle)
> <linux@armlinux.org.uk> wrote:
>
> > However, it makes a total nonsense of the comment, which explains
> > precisely why the flush_cache_all() is where it is. Moving it before
> > that comment means that the comment is now rediculous.
>
> Zhizhou, can you look over the comment placement?
>
> > So, please don't put it in the patch system.
> >
> > The patch certainly needs to be tested on TI Keystone which is the
> > primary user of this code.
>
> Added Andrew Davis and Nishanth Menon to the thread:
> can you folks review and test this for Keystone?
next-20230911 alone: (boots fine):
https://gist.github.com/nmenon/c097b4a7ce3971964a5a56a34b018c4d
With
https://lore.kernel.org/all/20230907143302.4940-1-zhizhou.zh@gmail.com/
applied on top (fails to boot):
https://gist.github.com/nmenon/308cfeb84098f41d340cd0e61845a507
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-09-11 13:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 14:33 [PATCH] ARM: mm: fix stack corruption when CONFIG_ARM_PV_FIXUP=y Zhizhou Zhang
2023-09-08 12:58 ` Linus Walleij
2023-09-08 13:50 ` Russell King (Oracle)
2023-09-08 21:00 ` Linus Walleij
2023-09-09 8:23 ` Zhi-zhou Zhang
2023-10-02 14:17 ` Andrew Davis
2023-09-11 13:04 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230911130431.k35xp7gszgwqigl4@vendetta \
--to=nm@ti.com \
--cc=afd@ti.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=rppt@kernel.org \
--cc=vishal.moola@gmail.com \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=zhizhou.zh@gmail.com \
--cc=zhizhouzhang@asrmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox