From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74735CA0ECF for ; Tue, 12 Sep 2023 13:23:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IqdH6qqWprrWAsA+/tcytpsMxc3muSDjlJq8M43nVvg=; b=POSQ9oDP6ZJ1Sv Vep2a9Fm5k8L60lrTCibyqqtky7gslgBoDt1EADgbt4ddfKI65q/X1ENsRwDbCfS4PQFKYZg+9IPi 1cYktUDVEqVUbP4W0rEidlnZG7djIfxAClEQHal0Zgo+jGAj6NKhhhi4J6825rLl+ZxSIymVVLyG6 gr7tbDoysHEsQ/oyW5+Kh8sxJj9FsyZXdrHzhoLGUmTK93y/MJXW+LGckycXPAmU7x2rHan0aVF+L uZdFmNCdihIPrsPGtMgaYzGjtqeSL8AuHMQv8V7/SNpD9HAOx4jI6srg5LBHHg1zqH3vXA007hmBT lGNSGYi74m5EDLeETneA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qg3MS-003Po2-2f; Tue, 12 Sep 2023 13:23:24 +0000 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qg3MQ-003PnP-1F for linux-arm-kernel@lists.infradead.org; Tue, 12 Sep 2023 13:23:23 +0000 Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2bcbfb3705dso91148211fa.1 for ; Tue, 12 Sep 2023 06:23:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694524997; x=1695129797; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/rdjcDFmrM63pX6o+x+Wwy98XUc20ZcXO5zPneEUmMY=; b=Kbl/7uIidaXsib9gcpvm8kw+Ij4GOQuyCdkKq7q+iSVNS5DmWYmsEV1xSRKbxk8TCW 8zPkcs0vH4H1HuuYr36WWQrKbN3a/t0QLkBOjRKRDqpaTrZfgAhCuMs8QX92SGmcceZl 8gD5YhHwlAOyzvz/XrBydNx7QMxBG9k1wVTxRfFlK+Iza6F4P/7d7gAauWh07rpBfUDZ yfAv+juxcCGY7tLTYtKX3KDTPy7IkphWg18oQA1u7jBD+YY53VTcooa5hydnNzgEp4LU 4IBobGq1xGGffTWWfQL0P8Eun3Ynusj1RMBr935ZrFlVLFCHOGBifFSYMjduE4LEATMH xkKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694524997; x=1695129797; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/rdjcDFmrM63pX6o+x+Wwy98XUc20ZcXO5zPneEUmMY=; b=PAb6e21i5RFfERsUMaGfXnAdqdb9A1oBWQYZo3ky5WTuANjQZIKtV+58uBgd2avoTH 3cKMGvaC0r4/sjq+z2XmXS1XAVs7iikVl9nSXUn3XppuIvI2anLS4Yj2fmpixg+k8bVD tsAIy4jgbMczK0hl9wi8CQFZqgFaPGLhka8JikB9D3Aw3DqdgcRSyPHiC2wvpRVVI75W i4wUUVQbhUsfyf3oTEUQ6iI1yZNbCMII9g8967Sx14YEfipyM5gqrMHH2puDSUo+h1GK Sf88Ade0LZtAZXTRDU583Ia+gFmqj2oA31DhBeTKI7XxMzrliMApHi+PvEx6PYQWcLZ9 Knmg== X-Gm-Message-State: AOJu0YywY5aUl6vUw/U3rsaiOqICZmwkKgC9NQlO4XFBCnhyCxY14Y++ W+3HzrQqTE2330EOK6QVfJz+TQ== X-Google-Smtp-Source: AGHT+IHip61uATl8A4os+5TIhcQA0bDFe3GF4eFWFFDcQjJvR8/iudTHyjqeXDEJuZT1P8RSLA1COw== X-Received: by 2002:a2e:3316:0:b0:2bc:d6a8:1ef2 with SMTP id d22-20020a2e3316000000b002bcd6a81ef2mr10876126ljc.12.1694524997477; Tue, 12 Sep 2023 06:23:17 -0700 (PDT) Received: from rayden (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id b1-20020a2e8941000000b002b6db0ed72fsm2007167ljk.48.2023.09.12.06.23.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 06:23:16 -0700 (PDT) Date: Tue, 12 Sep 2023 15:23:14 +0200 From: Jens Wiklander To: Sudeep Holla Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lucian Paul-Trifu , Marc Bonnici , Coboy Chen Subject: Re: [PATCH RFT 05/12] firmware: arm_ffa: Implement the FFA_NOTIFICATION_SET interface Message-ID: <20230912132314.GA4160483@rayden> References: <20230803-ffa_v1-1_notif-v1-0-6613ff2b1f81@arm.com> <20230803-ffa_v1-1_notif-v1-5-6613ff2b1f81@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230803-ffa_v1-1_notif-v1-5-6613ff2b1f81@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230912_062322_442687_144D5FCE X-CRM114-Status: GOOD ( 21.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 03, 2023 at 08:02:09PM +0100, Sudeep Holla wrote: > The framework provides an interface to the sender to specify the > notification to signal to the receiver. A sender signals a notification > by requesting its partition manager to set the corresponding bit in the > notifications bitmap of the receiver invoking FFA_NOTIFICATION_SET. > > Implement the FFA_NOTIFICATION_SET to enable the caller(sender) to send > the notifications for any other partitions in the system. > > Signed-off-by: Sudeep Holla > --- > drivers/firmware/arm_ffa/driver.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c > index 41171ae7f63a..492f5bfa3751 100644 > --- a/drivers/firmware/arm_ffa/driver.c > +++ b/drivers/firmware/arm_ffa/driver.c > @@ -604,6 +604,26 @@ static int ffa_notification_bind_common(u16 dst_id, u64 bitmap, > return 0; > } > > +static > +int ffa_notification_set(u16 src_id, u16 dst_id, u32 flags, u64 bitmap) > +{ > + ffa_value_t ret; > + u32 src_dst_ids = PACK_TARGET_INFO(dst_id, src_id); dst_id and src_id should be swapped in the argument to PACK_TARGET_INFO(). Thanks, Jens > + > + invoke_ffa_fn((ffa_value_t) { > + .a0 = FFA_NOTIFICATION_SET, .a1 = src_dst_ids, .a2 = flags, > + .a3 = NOTIFICATION_BITMAP_LOW(bitmap), > + .a4 = NOTIFICATION_BITMAP_HIGH(bitmap), > + }, &ret); > + > + if (ret.a0 == FFA_ERROR) > + return ffa_to_linux_errno((int)ret.a2); > + else if (ret.a0 != FFA_SUCCESS) > + return -EINVAL; > + > + return 0; > +} > + > static int ffa_run(struct ffa_device *dev, u16 vcpu) > { > ffa_value_t ret; > > -- > 2.41.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel