From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE256CA0ECA for ; Tue, 12 Sep 2023 13:24:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u8LBPgoTu3651WzKzr2ePgW7f/CaiPoMM65Zlln+ylY=; b=o7oA31VXgXRdvu oFcbyvNp9E8A4dpg+f/Ks8BWc6xiEyEX03WRxSRIqUeN4ka0tBsqmULj3d95CzIGGTG3ybwYw0+Qb +IHoyr6MEAnsk1e1NlkACjooI8uEL++F8yTtptoBOXmo5xsPKTwL1ONn7WadrgULvpbrYj+/o51ff UsEzfhcLM8/+1QzY3JjmZSregFa/IZ92Q4vTeRXu38JkIdIKSmZzfN5Tpv2LsRgoswHfzopUwR65P hlJ2cQ5114m95iUZJP1sjFNV2/Ym0yWE6ukLotHsy0blBccmTgza3pcWQ4XpNPjkndkK5VJHKbXW5 IfgpVShILZetbvyx4UMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qg3N4-003Pt8-2o; Tue, 12 Sep 2023 13:24:02 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qg3N2-003Ps5-0J for linux-arm-kernel@lists.infradead.org; Tue, 12 Sep 2023 13:24:01 +0000 Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-502a4f33440so6114509e87.1 for ; Tue, 12 Sep 2023 06:23:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694525036; x=1695129836; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ji5s4rY/qOWA8pBh6XFjmkTyUce8JjhErHwecttqKIc=; b=oNVzsihf4gxvP+bbGxtq1MkrI88bgapfdXFGZm04PBsmHlncqa/2CeP+KPVqpa2O/o a40XN6J1caSkaZUCqP3+IeOy4XosdcvBHRizVVTIjHDzGGC0ZwBvDnM34h6CjMyFlRfN o6p/8bTKQdHbcYa4PC1aZ6gp/MsLFMLp8thWNlt1AVanJzcru7Vj3xc58uHhhfFwkuK3 1ajw2+bfGXmuY8tlZqlSJKJkxPZBNsjrMYiFc+AflDjq1EY226U1fq21v9POlLvl1Nof jy0vcy8Ejy4471xS3AcPjtwTfFphqgqWWYjHli0Fii8/fy9no1xhIAlVMnK34Q+00FlM DqdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694525036; x=1695129836; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ji5s4rY/qOWA8pBh6XFjmkTyUce8JjhErHwecttqKIc=; b=oiO0OnHPb3W6WZKDPgg3rASFSlydZKd7yL58PHeF8nWe/azYz7CQGb/X6V4AcmytUl xH7drKDYsF2hEoPiStbG9PLncJq8w0QDTo/eQ7rkYR8ZEx1Thj5IIgvwCaorno3d/z7v ++NAaRKEivU58xo9Vln1eiUBgsNXDMKG40ZXi1PqWVZHyPYdtEY15khvl/7XF9w8/fdI qAV3ViPKNG+TyMnhkpouqpyoH4My59Gwzq8hxY9f5DYUkMI6qStCt99EpbiZq7DjOZ5J 6lB7XVuWus5GvBurqNzVvLcYvNkqpOs4Vt1qexSEadsqFSNtMTLbXjHQ8AuU9+9g7E5R mggA== X-Gm-Message-State: AOJu0YzgRckvuI26pEAZyzQaWVSYSUMifOdJy8SZpPvoW8Ld1s66UEUJ 7cQ2aHsXH8ec77mClbdcsWKibw== X-Google-Smtp-Source: AGHT+IEa6Sz35ObmVh1HWZMNF/J0B3zF+9+fj8aKuRprl8HwfRhfCZW84FmsV0uJKp2PRGQf8dg50g== X-Received: by 2002:ac2:4ac7:0:b0:4fe:3364:6c20 with SMTP id m7-20020ac24ac7000000b004fe33646c20mr9809821lfp.16.1694525035844; Tue, 12 Sep 2023 06:23:55 -0700 (PDT) Received: from rayden (h-46-59-78-111.A175.priv.bahnhof.se. [46.59.78.111]) by smtp.gmail.com with ESMTPSA id x16-20020ac24890000000b004ffa451074dsm1749568lfc.50.2023.09.12.06.23.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 06:23:55 -0700 (PDT) Date: Tue, 12 Sep 2023 15:23:53 +0200 From: Jens Wiklander To: Sudeep Holla Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lucian Paul-Trifu , Marc Bonnici , Coboy Chen Subject: Re: [PATCH RFT 03/12] firmware: arm_ffa: Implement the notification bind and unbind interface Message-ID: <20230912132353.GB4160483@rayden> References: <20230803-ffa_v1-1_notif-v1-0-6613ff2b1f81@arm.com> <20230803-ffa_v1-1_notif-v1-3-6613ff2b1f81@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230803-ffa_v1-1_notif-v1-3-6613ff2b1f81@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230912_062400_135419_B1CE8D32 X-CRM114-Status: GOOD ( 25.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 03, 2023 at 08:02:07PM +0100, Sudeep Holla wrote: > A receiver endpoint must bind a notification to any sender endpoint > before the latter can signal the notification to the former. The receiver > assigns one or more doorbells to a specific sender. Only the sender can > ring these doorbells. > > A receiver uses the FFA_NOTIFICATION_BIND interface to bind one or more > notifications to the sender. A receiver un-binds a notification from a > sender endpoint to stop the notification from being signaled. It uses > the FFA_NOTIFICATION_UNBIND interface to do this. > > Allow the FF-A driver to be able to bind and unbind a given notification > ID to a specific partition ID. This will be used to register and > unregister notification callbacks from the FF-A client drivers. > > Signed-off-by: Sudeep Holla > --- > drivers/firmware/arm_ffa/driver.c | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c > index 022c893c9e06..a76e5d3a2422 100644 > --- a/drivers/firmware/arm_ffa/driver.c > +++ b/drivers/firmware/arm_ffa/driver.c > @@ -575,6 +575,35 @@ static int ffa_notification_bitmap_destroy(void) > return 0; > } > > +#define NOTIFICATION_LOW_MASK GENMASK(31, 0) > +#define NOTIFICATION_HIGH_MASK GENMASK(63, 32) > +#define NOTIFICATION_BITMAP_HIGH(x) \ > + ((u32)(FIELD_GET(NOTIFICATION_HIGH_MASK, (x)))) > +#define NOTIFICATION_BITMAP_LOW(x) \ > + ((u32)(FIELD_GET(NOTIFICATION_LOW_MASK, (x)))) > + > +static int ffa_notification_bind_common(u16 dst_id, u64 bitmap, > + u32 flags, bool is_bind) > +{ > + ffa_value_t ret; > + u32 func, src_dst_ids = PACK_TARGET_INFO(dst_id, drv_info->vm_id); dst_id and drv_info->vm_id should be swapped in the argument to PACK_TARGET_INFO(). Thanks, Jens > + > + func = is_bind ? FFA_NOTIFICATION_BIND : FFA_NOTIFICATION_UNBIND; > + > + invoke_ffa_fn((ffa_value_t){ > + .a0 = func, .a1 = src_dst_ids, .a2 = flags, > + .a3 = NOTIFICATION_BITMAP_LOW(bitmap), > + .a4 = NOTIFICATION_BITMAP_HIGH(bitmap), > + }, &ret); > + > + if (ret.a0 == FFA_ERROR) > + return ffa_to_linux_errno((int)ret.a2); > + else if (ret.a0 != FFA_SUCCESS) > + return -EINVAL; > + > + return 0; > +} > + > static void ffa_set_up_mem_ops_native_flag(void) > { > if (!ffa_features(FFA_FN_NATIVE(MEM_LEND), 0, NULL, NULL) || > > -- > 2.41.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel