From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8393EE0202 for ; Wed, 13 Sep 2023 18:31:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=81D1PwUDt5HgRUI6vLhkp3Cwx2r8qM76pn0ASkClpag=; b=ToYYwFcInTwNKLZVxRnsIXhZHq 25tVXQ4JOPWfkChghYaWB79fSK8lhi4xYyb+5RSCjjxAFkpsXcCJILn6JYB4CT1kco5E72qn7guaO Xa8ZPPZLPaSvVMtth5F+it+N4XRWZr8sJWkYb2rAMJTTykgi9FF+f1PoCgPmvxebqlpv4HH2oml3s FvXrGoTN3/DpEz70DxaoR9YI2SpYuUgxKLH8ji1ib9//VYkMcJrwWdgBdJYIsgzV58i6bgth+vk58 IiJkNbj0xyu6HVwh9G9zQqML/4hncfzlwos35X4m/x574ki6yUClt/jF8ScwK+1DzJ07EOgZUleGr bx15QoyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qgUdH-006Xth-1z; Wed, 13 Sep 2023 18:30:35 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qgUdD-006Xsz-2K for linux-arm-kernel@lists.infradead.org; Wed, 13 Sep 2023 18:30:33 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 2DF3ACE231B; Wed, 13 Sep 2023 18:30:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FB50C433C7; Wed, 13 Sep 2023 18:30:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694629827; bh=31I+vvfgxK2RhSOo9RhuKS344PF5cuX3/n6t1MBZpzo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MCFNq3tlLXBYEdwM2SebVUys4XPCNqAteJLX8meljGy/43fW9KgqlC5NrbO/EK9VX nB8jd6URfw0oaYQXALu8Id/brV27/zfSdcCMdAaohnUnGG2BAt3l7M6r5zyCR/072a FjSI1Zw1fwB01Hwe5scQfa9WnHJ8oDLEibDp0LYrYSSAxhPjj0AxNFI0XZJjbWkj1v a84rr5RFBuSSvgHUNXInn69Je4vSP4lFSawZ/p8fPiwQEjCRJmdCICyjjwN4uTc84Y Aq+Nf2tzKXlqmWdAZVYmsSGknWTlDyntQqblNoS7mbVaVSNo0AglWbi/sn61UZ0eIT BmBQu0zWuUEgw== Date: Wed, 13 Sep 2023 19:30:22 +0100 From: Conor Dooley To: Romain Perier Cc: Alessandro Zummo , Alexandre Belloni , Daniel Palmer , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/3] dt-bindings: rtc: Add Mstar SSD202D RTC Message-ID: <20230913-depress-bootlace-6b88bfd83966@spud> References: <20230913151606.69494-1-romain.perier@gmail.com> <20230913151606.69494-3-romain.perier@gmail.com> MIME-Version: 1.0 In-Reply-To: <20230913151606.69494-3-romain.perier@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230913_113032_117478_636F136A X-CRM114-Status: GOOD ( 21.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============9200000806219874129==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============9200000806219874129== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zSIJHToUSvODMYzW" Content-Disposition: inline --zSIJHToUSvODMYzW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 13, 2023 at 05:16:05PM +0200, Romain Perier wrote: > Add YAML bindings for Mstar SSD202D RTC. >=20 > Signed-off-by: Romain Perier > --- > .../bindings/rtc/mstar,ssd202d-rtc.yaml | 35 +++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/mstar,ssd202d-r= tc.yaml >=20 > diff --git a/Documentation/devicetree/bindings/rtc/mstar,ssd202d-rtc.yaml= b/Documentation/devicetree/bindings/rtc/mstar,ssd202d-rtc.yaml > new file mode 100644 > index 000000000000..4c1f22ef5a2c > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/mstar,ssd202d-rtc.yaml > @@ -0,0 +1,35 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/mstar,ssd202d-rtc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mstar SSD202D Real Time Clock > + > +maintainers: > + - Daniel Palmer > + - Romain Perier > + > +allOf: > + - $ref: rtc.yaml# > + > +properties: > + compatible: > + enum: > + - mstar,ssd202d-rtc > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg So, this seems fine to me in isolation, but isn't this now the sort of thing that can be documented in trivial-rtc.yaml? Its only got compatible & reg, which seems to fit the bill for that. Apologies if I am missing something, Conor. > + > +unevaluatedProperties: false > + > +examples: > + - | > + rtc@6800 { > + compatible =3D "mstar,ssd202d-rtc"; > + reg =3D <0x6800 0x200>; > + }; > +... > --=20 > 2.39.2 >=20 --zSIJHToUSvODMYzW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZQH/vgAKCRB4tDGHoIJi 0kNuAPsEvE8AqBxe+MoFCB0pt3YnCSej+vAgfRprRQ+KRYy1yQD+Lzs9ukZ+5ELi q1HOYU3/VRN5LYUIQ75IqFUXkGmnXAA= =Oj2N -----END PGP SIGNATURE----- --zSIJHToUSvODMYzW-- --===============9200000806219874129== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============9200000806219874129==--