From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 828F0CA5507 for ; Wed, 13 Sep 2023 08:26:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LPrzleaeeTihUb2oCqEzOEf7QBMeVCY2YKlePByAuBk=; b=ms2+iNwODDeCig REO5oFlG095wKWFWiKefc6Ba8YnPnbul8pe62LLn2WYoCJmASNWTcF8VdogNBr9HMlvrWcnHcqb9e KsfgJticGiAghs+PdBMVyYbELKGgJ+uF8STopCWRNHj+8m5o9dJfPJ4AawTnuwnBGEYaI78ErNw3x 2XIGFJfiuWbXrHks5RThbiKxRfCdX/dl9PwJOqYFtp9dOXK3KKaDAaZPtkHKcKIDyOPz/U4d3AzPv j52RilhW1KQrVi8s+/my4DKUcJNRUuFNt6kBNIWaVZzmkwLr9GF2fVWM7NtgDwMQUHiXduWraONdm QND2wTPjeEnFDrp3aJFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qgLCh-0055ix-0B; Wed, 13 Sep 2023 08:26:31 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qgLCd-0055hC-1m for linux-arm-kernel@lists.infradead.org; Wed, 13 Sep 2023 08:26:29 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id BDC618088; Wed, 13 Sep 2023 08:26:23 +0000 (UTC) Date: Wed, 13 Sep 2023 11:26:22 +0300 From: Tony Lindgren To: Kevin Hilman Cc: Dhruva Gole , linux-omap@vger.kernel.org, Greg Kroah-Hartman , Keerthy , Nishanth Menon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, vibhore@ti.com Subject: Re: [PATCH] bus: ti-sysc: Fix SYSC_QUIRK_SWSUP_SIDLE_ACT handling for uart wake-up Message-ID: <20230913082622.GG5285@atomide.com> References: <20230907055441.19476-1-tony@atomide.com> <20230907062231.muwzvje726wlqnqw@dhruva.dhcp.ti.com> <7hsf7j582o.fsf@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7hsf7j582o.fsf@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230913_012627_629148_E38E2AA4 X-CRM114-Status: GOOD ( 23.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Kevin Hilman [230912 22:40]: > Dhruva Gole writes: > > > On Sep 07, 2023 at 08:54:41 +0300, Tony Lindgren wrote: > >> The uarts should be tagged with SYSC_QUIRK_SWSUP_SIDLE instead of > >> SYSC_QUIRK_SWSUP_SIDLE_ACT. The difference is that SYSC_QUIRK_SWSUP_SIDLE > >> is used to force idle target modules rather than block idle during usage. > >> > >> The SYSC_QUIRK_SWSUP_SIDLE_ACT should disable autoidle and wake-up when > >> a target module is active, and configure autoidle and wake-up when a > >> target module is inactive. We are missing configuring the target module > >> on sysc_disable_module(), and missing toggling of the wake-up bit. > >> > >> Let's fix the issue to allow uart wake-up to work. > >> > >> Fixes: fb685f1c190e ("bus: ti-sysc: Handle swsup idle mode quirks") > >> Signed-off-by: Tony Lindgren > >> --- > >> drivers/bus/ti-sysc.c | 22 +++++++++++++++++----- > >> 1 file changed, 17 insertions(+), 5 deletions(-) > >> > >> diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c > >> --- a/drivers/bus/ti-sysc.c > >> +++ b/drivers/bus/ti-sysc.c > > > > Thanks for the fix Tony, > > I have tested this on a TI SK-AM62x with deepsleep and am able to wakeup > > with keypress on the wake_uart. > > > > For anyone else who wants to give this a shot, the required patches for > > deepsleep and DT related changes have been pushed to my branch on github > > [0]. > > > > Hence, > > Tested-by: Dhruva Gole > > > > [0] https://github.com/DhruvaG2000/v-linux/commits/v6.5-rc7_wkuart > > Also tested on k3-am625-sk using Dhruval's branch. > > Tested-by: Kevin Hilman Thanks for testing, applied into fixes. Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel