From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49713CA5508 for ; Wed, 13 Sep 2023 08:36:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Tyrro9JsrhtiiRYrgsjBTSNkaB3oyGJeTWAS4WN4TcE=; b=lZi/kCkceKWyD0 KZJHHKcuiBXzKgTY6+u7xwj5se6jtMAWVw1B+9pb3EE1O75T4k+5xBdAEeSilP3VEBF1h8G6/uPiH 7HjkjmeeTxOn2Hz7u/M8Ue3cpZy3qSEfdbXED9O2kmxyrkQZtNuTnmqOHoqdJQO/VbDwG4HErDruA 9N73jDb+Zdpz3AVSXZKM/j/oUCxhxNk/bgTL8/6IJHkYCtAteA+podyCAZJBeNSqFUxZ/CUhWMN3v 21pS0DU7R9kOSnNKCjD+BUhYjfaUoJM4TKBw7dh9eqfdmPnRk9MqNdBfVvLRkCM/rxP+ue00sAiPv Qqv80K9UmwnbdpBYIteQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qgLLV-0057Mh-2z; Wed, 13 Sep 2023 08:35:37 +0000 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qgLLS-0057KM-35 for linux-arm-kernel@lists.infradead.org; Wed, 13 Sep 2023 08:35:36 +0000 Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-9aa0495f9cfso148127266b.1 for ; Wed, 13 Sep 2023 01:35:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1694594132; x=1695198932; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vzZ6MgD3pf8m+rx1Xv6RC5XGWASwhi1UIBmWgNbxJHM=; b=tBDA8IS7xSehHID2i62GvbpQ6Q0pwj5Vase24FObQE568j3Y28yHnvowsOTJkUNUb0 3ZVsCLTI7w93bTooW+ONRZhzOMf5UfakOJA48QVm3rBj/c1ifB3qm9BHskRTaX9tH3sI cY6VsesOyRcMOp1/Zd6mj+whI9/2uzZBtP75TbWSLCme6dcyV6rt4rDOI9tdxdaY6yd5 NxvVO90rAH7eUSnaqUrc+QHtV2+mhljrMWgPo7j5ykCrunMnfOi+atAAJso8SVedbY/Z whMVbRo2WQQwRKK0iJIiUDkLsMeIHzbk6SOZrqFpshtB5DJO4T4GzFyfKRAYTUkyCIM7 NvVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694594132; x=1695198932; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vzZ6MgD3pf8m+rx1Xv6RC5XGWASwhi1UIBmWgNbxJHM=; b=WZWT3O52vThx5hOkNg8yy9Qb8EByOSSMPs5k7fGcPQs0mLPuK3CQ/QgcQOIdyhf73N CxYetkxmNcoKULYljBLAU8k1bbYZPWA8dyXBS81kZiu9Ah+9PvyquKVX0+L6qAVEjbzL vo+r5yuEmpqq6GH50Iot+tqMB3+JAwot+hOWMjXrtzVh9WpKp0KO9G3kbqmxJXhvVijJ y7BDhTjXN72kzcdouj6iwjgZrB75UVF78NYpCX/vsAdiLlLGbQxbtdtr7XRyMNANOqtA Ab/oQJob9dv6A548CqHrpZ1FSrcaSXLvr3Q70Sfw4CgnY0ixPbIli3YxwjEjMgVpKLgR vFYw== X-Gm-Message-State: AOJu0Yx1JfEdQrmo/2AEMMGity6yLX3Sy/cvTRPFurwngI/C0B00Jyag CoagYY/V58BPGtG35qqbs15Dvg== X-Google-Smtp-Source: AGHT+IGZ4W6oHcVWa6n5e3HT26skU4k3V7FAnm2BWzLS+1RwRT1pMvQIlK0HWxcVOFIXwB+8acOF1Q== X-Received: by 2002:a17:906:c112:b0:9a4:11a3:c32b with SMTP id do18-20020a170906c11200b009a411a3c32bmr7346391ejc.29.1694594132177; Wed, 13 Sep 2023 01:35:32 -0700 (PDT) Received: from blmsp ([2001:4091:a246:82a0:6611:d59a:8ba3:9a66]) by smtp.gmail.com with ESMTPSA id lz5-20020a170906fb0500b0098e78ff1a87sm7990464ejb.120.2023.09.13.01.35.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 01:35:30 -0700 (PDT) Date: Wed, 13 Sep 2023 10:35:29 +0200 From: Markus Schneider-Pargmann To: Frank Wunderlich Cc: linux-mediatek@lists.infradead.org, Frank Wunderlich , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Matthias Brugger , AngeloGioacchino Del Regno , Daniel Golle , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org Subject: Re: [PATCH] thermal/drivers/mediatek: Fix control buffer enablement on MT7896 Message-ID: <20230913083529.3bgjl6rvfmixgjnd@blmsp> References: <20230907112018.52811-1-linux@fw-web.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230907112018.52811-1-linux@fw-web.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230913_013534_991657_A2AC516F X-CRM114-Status: GOOD ( 18.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 07, 2023 at 01:20:18PM +0200, Frank Wunderlich wrote: > From: Frank Wunderlich > > Reading thermal sensor on mt7986 devices returns invalid temperature: > > bpi-r3 ~ # cat /sys/class/thermal/thermal_zone0/temp > -274000 > > Fix this by adding missing members in mtk_thermal_data struct which were > used in mtk_thermal_turn_on_buffer after commit 33140e668b10. > > Cc: stable@vger.kernel.org > Fixes: 33140e668b10 ("thermal/drivers/mediatek: Control buffer enablement tweaks") > Signed-off-by: Frank Wunderlich Reviewed-by: Markus Schneider-Pargmann Thanks for fixing! Best, Markus > --- > drivers/thermal/mediatek/auxadc_thermal.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/thermal/mediatek/auxadc_thermal.c b/drivers/thermal/mediatek/auxadc_thermal.c > index 843214d30bd8..967b9a1aead4 100644 > --- a/drivers/thermal/mediatek/auxadc_thermal.c > +++ b/drivers/thermal/mediatek/auxadc_thermal.c > @@ -690,6 +690,9 @@ static const struct mtk_thermal_data mt7986_thermal_data = { > .adcpnp = mt7986_adcpnp, > .sensor_mux_values = mt7986_mux_values, > .version = MTK_THERMAL_V3, > + .apmixed_buffer_ctl_reg = APMIXED_SYS_TS_CON1, > + .apmixed_buffer_ctl_mask = GENMASK(31, 6) | BIT(3), > + .apmixed_buffer_ctl_set = BIT(0), > }; > > static bool mtk_thermal_temp_is_valid(int temp) > -- > 2.34.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel