From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46BBFEDEC40 for ; Wed, 13 Sep 2023 11:29:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Iza01shsXOPIZtp9hnGqRfpJhp7MF/9ZpMm8hcBe4+U=; b=PzbJPGgiPk7Or8 edbi4RdIUWlB6s1fdviCEpNXtzf0v1svmjQ92gZlnyFbxAXSg3Oa9AZMVxBIlJuImLuxJrd3RauHQ JS5/miQVGWK3jgm+ezcxSw2dSkLr0e7PiAfjQanhpsZKi3PkPPkQrQAC9zrWjCB9oEdQ6ugPEJyzV 5PxppAcUYRPEd9Q6BGEakdhjxnPYEvWCzndH21pUOa2TzgWnTD12AEeT2fLv8HR7zS4acgoYSdqv5 POg+FoT0/ORitHCCBlBTLBrK0ufifJ0IXhePR0M5QItfKcuSRG8GvC60/RMpp7RFyywl/rIrXgt8E V+Px7upokEB+GAJZcsaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qgO2q-005k11-24; Wed, 13 Sep 2023 11:28:32 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qgO2n-005jzp-08 for linux-arm-kernel@lists.infradead.org; Wed, 13 Sep 2023 11:28:30 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 38DBSOm3003054; Wed, 13 Sep 2023 06:28:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1694604504; bh=lPBlKm6971IjTYMi/EZXsKwtVnDwVd301Kkc6UIPRkI=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=BPwnS3T4ssvtjJG5KOmFsym1IjtjrpyZtohTjFl/OpW+xSrN5IkneaA61LGtP1r1B pn/qyefvtVYcIcy9SGDhqozpty+FatIRZhROFS8crGCQi0vH75dmDjxRgt5Q1GJLP4 0zUTpddFe1Pi7CMP6vrxAPqXKLuvuOjp4GHUYo4Q= Received: from DLEE102.ent.ti.com (dlee102.ent.ti.com [157.170.170.32]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 38DBSN0Z082517 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 13 Sep 2023 06:28:23 -0500 Received: from DLEE112.ent.ti.com (157.170.170.23) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 13 Sep 2023 06:28:23 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 13 Sep 2023 06:28:23 -0500 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 38DBSNOY008291; Wed, 13 Sep 2023 06:28:23 -0500 Date: Wed, 13 Sep 2023 06:28:23 -0500 From: Nishanth Menon To: Neha Malcom Francis CC: Thejasvi Konduru , , , Santosh Shilimkar , Tero Kristo , Grygorii Strashko , Lokesh Vutla , Apurva Nandan , Udit Kumar Subject: Re: [PATCH] soc: ti: k3-socinfo: Fix the silicon revision misprint Message-ID: <20230913112823.prv5dmasvv4nt6qv@nuclear> References: <20230607080349.26671-1-t-konduru@ti.com> <20230607104304.iengykppptr3fxe6@reflected> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230913_042829_174938_5D84A64E X-CRM114-Status: GOOD ( 18.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12:07-20230912, Neha Malcom Francis wrote: [...] > > > +void > > > +k3_chipinfo_silicon_rev(unsigned int variant, > > > + struct soc_device_attribute *soc_dev_attr) > > > +{ > > > + const char *family_name = soc_dev_attr->family; > > > + int j721e_lookup_arr_size = ARRAY_SIZE(soc_revision_j721e); > > > + > > > + if (!strcmp(family_name, "J721E") && variant < j721e_lookup_arr_size) { > > > + soc_dev_attr->revision = kasprintf(GFP_KERNEL, "SR%s", soc_revision_j721e[variant]); > > > + } else { > > > + variant++; > > > + soc_dev_attr->revision = kasprintf(GFP_KERNEL, "SR%x.0", variant); > > > + } > > > > I am not comfortable with if else here. Why not extend k3_soc_id > > structure to include the variant LuT? Are there exceptions to this rule > > (Say AM65x?), those would make sense to handle with a compare against > > the partno? > > > > Trying to revive this patch, I see what you are saying is similar to the way > detection has already been implemented in U-Boot (drivers/soc/soc_ti_k3.c) > if I'm not mistaken. Yes. > > But I can't find any existing exception to this "family --> version" rule > that forces us to use "partno --> version". Checked through all AM65x device > TRMs available in ti.com; all seem to use common partno. So maybe I am not > on the same page, did you mean something else? https://www.ti.com/lit/ug/spruid7e/spruid7e.pdf CTRLMMR_WKUP_JTAGID:: VARIANT field: SR2.0: 1h SR1.0: 0h Latest data sheet: https://www.ti.com/lit/ds/symlink/am6548.pdf indicates SR 2.1 How is this detected? What I indicated is a LUT table similar to https://git.ti.com/cgit/k3conf/k3conf/tree/common/socinfo.c#n382 This allows a switch statement to handle custom SR handling schemes or use LUT with variants that use VARIANT field to handle things properly. [...] -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel