From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFFFBEDE998 for ; Thu, 14 Sep 2023 08:52:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NMWUv81jzttZ8UZnVg1KaGKdZVHxmuFOiJbB1EwO2r4=; b=jl6WN8I+8juGLr G9Mu5z6eIvnUGCCd9fKgsTKC7L1EUD/4MP054FNfGi/9J09RZ9MdzyM0PLDR7gVF9n6wK6Qo6dYzF eSM6wkb91cSiyM3CPYijsramOE5D6NT8QXYqUH0ix8vjNxNVb6TpSdALiwyBjs2EroA45TMoWDnVm i+Prhe+e7w58hEnVEB0ZVHt0YgIfqY/CPuYexYIlRmWkvskegRYa3Ww0SjJE8aGo0kLJDa+7XCV5v 620IMiN9EvV2wQ+C2wof10vy6GILL6uysApZnUy5xU9qL4Qm/7hnsRluojiJ7MMPp62yiUZ6KX0ed dJZGeyPYZcjlt1mBw85A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qgi5E-007ksQ-2I; Thu, 14 Sep 2023 08:52:20 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qgi5C-007krR-21 for linux-arm-kernel@lists.infradead.org; Thu, 14 Sep 2023 08:52:19 +0000 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-31aeedbb264so614047f8f.0 for ; Thu, 14 Sep 2023 01:52:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1694681535; x=1695286335; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lMUcG5dET7EFobfbAHbzg2lwyOfsWQ8F2tpkEXeY8DY=; b=Jo+9z/w9R5Me5YO2t/D+iVFKNEaFPsEEK33zCdeU1JntRBK33fSha8CgXXuxFjxjoa 2Ut6F0ZIZh7azrbOtk7drzHcI3G2bFerrsYxEXTM+CUHj2GIyygFz9/wfEfOdaQrs1S7 EmwOoMRZ6GFu5U/MVZ9n8Ug2ynb/NkUV5fhfl/0BxDeaZF1AlPEsvOofdt0mKfFtgRZ3 Jn1gZWOp6ouuzNNPnY/tjrHp/w+2xXVb12lTejAsAnkwD1ZKhHUDg8UmWuW7mSkDC+j6 FgfU8PY+eDG7aC1YtU+Gtih3wowG9bM5g8G1lEnc0JL8H0iuYpRJUdn7Rus54d3y4bx7 YAaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694681535; x=1695286335; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lMUcG5dET7EFobfbAHbzg2lwyOfsWQ8F2tpkEXeY8DY=; b=XjSzmyQFwWYkXRbj8UrB2r6/aASbxqSaUdiysxWKpofPqubq9qZvMuMM9F7u5+cfX/ oo/4FakKs0PmPxjEkWg+2BLj56Tw3vGhxwdi5/ZYPYq51Zc2FyJJ+wZDTK5szgY2RvhN gthmx3oAHUcPqio1z5PNK/+7Oxe8XJzMr9OlaDvBi4hG7uuXIpAZQri/x2MAXLUtFFL+ VFYyGU43OrVO7axJlrqaYN+ErXAt2ICUEnFXQKMYLt/EqGu6uKennALB03z5qknwgcc+ 9khDD2c2hjHD3TXIr3QNcZFYfp+wBiVYiejTbo41FPHSzJaByHV+3DTHliKJGwk7LmXQ Zwqw== X-Gm-Message-State: AOJu0Yxj0D1wDtcipKQNUqUzbR5s6yb2J0GuNvJLmQv/KyYTrx4yRTv8 VZHYtXOHLMcSi/FTuGOznkn1Vw== X-Google-Smtp-Source: AGHT+IF/71ROIOoJExJf8FEqPIRkV7f1W6lv97o8MVa7W5dAed2t55G5dPLBGqXoAtZVnyXGa4aJ8Q== X-Received: by 2002:a5d:4f88:0:b0:319:83e4:bbbf with SMTP id d8-20020a5d4f88000000b0031983e4bbbfmr4097683wru.20.1694681535355; Thu, 14 Sep 2023 01:52:15 -0700 (PDT) Received: from localhost (cst2-173-16.cust.vodafone.cz. [31.30.173.16]) by smtp.gmail.com with ESMTPSA id r8-20020a5d4e48000000b0031ad2f9269dsm1137143wrt.40.2023.09.14.01.52.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 01:52:14 -0700 (PDT) Date: Thu, 14 Sep 2023 10:52:08 +0200 From: Andrew Jones To: Haibo Xu Cc: xiaobo55x@gmail.com, Paul Walmsley , Palmer Dabbelt , Albert Ou , Paolo Bonzini , Shuah Khan , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Anup Patel , Atish Patra , Sean Christopherson , Ricardo Koller , Vishal Annapurve , Peter Xu , Vipin Sharma , David Matlack , Colton Lewis , Aaron Lewis , Thomas Huth , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org Subject: Re: [PATCH v3 5/9] KVM: riscv: selftests: Switch to use macro from csr.h Message-ID: <20230914-18bfe93b679e290188e70307@orel> References: <6cdda82518977c67004ee01a767bc67962352c13.1694421911.git.haibo1.xu@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6cdda82518977c67004ee01a767bc67962352c13.1694421911.git.haibo1.xu@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230914_015218_685055_C611F41A X-CRM114-Status: GOOD ( 15.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 14, 2023 at 09:36:59AM +0800, Haibo Xu wrote: > Signed-off-by: Haibo Xu > --- > tools/testing/selftests/kvm/include/riscv/processor.h | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/tools/testing/selftests/kvm/include/riscv/processor.h b/tools/testing/selftests/kvm/include/riscv/processor.h > index 5b62a3d2aa9b..67766baed4f7 100644 > --- a/tools/testing/selftests/kvm/include/riscv/processor.h > +++ b/tools/testing/selftests/kvm/include/riscv/processor.h > @@ -8,6 +8,7 @@ > #define SELFTEST_KVM_PROCESSOR_H > > #include "kvm_util.h" > +#include > #include nit: Usually we try to keep the order of our includes separated into five categories, listed below, where each category is sorted alphabetically. Of course any dependencies the includes have on each other need to be considered too. "local-includes" > > static inline uint64_t __kvm_reg_id(uint64_t type, uint64_t idx, > @@ -95,13 +96,6 @@ static inline uint64_t __kvm_reg_id(uint64_t type, uint64_t idx, > #define PGTBL_PAGE_SIZE PGTBL_L0_BLOCK_SIZE > #define PGTBL_PAGE_SIZE_SHIFT PGTBL_L0_BLOCK_SHIFT > > -#define SATP_PPN _AC(0x00000FFFFFFFFFFF, UL) > -#define SATP_MODE_39 _AC(0x8000000000000000, UL) > -#define SATP_MODE_48 _AC(0x9000000000000000, UL) > -#define SATP_ASID_BITS 16 > -#define SATP_ASID_SHIFT 44 > -#define SATP_ASID_MASK _AC(0xFFFF, UL) > - > #define SBI_EXT_EXPERIMENTAL_START 0x08000000 > #define SBI_EXT_EXPERIMENTAL_END 0x08FFFFFF > > -- > 2.34.1 > Assuming the CONFIG_64BIT patch will come before this, then Reviewed-by: Andrew Jones Thanks, drew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel