From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93639EDE996 for ; Thu, 14 Sep 2023 08:47:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qW+eq8VeyA4vTG/2eX4gKNxYnSrDxa0Zy7wqLhSQr58=; b=yoPJWp8de3So8x qeIBu6iAQaSgIZUvg7DO/qZVmtnCCCfqoJaMYxMtp58FN0Nq4Z/+WKFTSbFH31vdgFhx8lZwLc6AX tHnKRqG6xi/1s5L3a+BC8le6krg0QHJJy171Q4P7TbXo2heREDP2xMzFiDZqvCdua6mlDC2MpMpmX nWhCQcq8MV94kAWSiCPvgFlIzcka6NBP8P4BVgOAECaGGZBcfJMmrONcvM4ZJ24tWUXs3mKRzR/or uCR3k9Et2CQQv36DRxZKBXQOFZ5xnHqpJHA6nxPRhrTyLFk6WA0/6ga05jVFl6axAsxv3MIr2dMHh 7E1x/9cb5uUPHV32wcgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qghzh-007jy6-0C; Thu, 14 Sep 2023 08:46:37 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qghze-007jwM-1d for linux-arm-kernel@lists.infradead.org; Thu, 14 Sep 2023 08:46:35 +0000 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-317c3ac7339so589440f8f.0 for ; Thu, 14 Sep 2023 01:46:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1694681191; x=1695285991; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KQEPjdH4Gli9KAKRohOP4WFvJ7BvjQDzxENQGkakYUo=; b=KfygEY62H6AY7X38ceG6nGF4f1EbZygIPE+motOkDiQU/fsTYduMdnw6dfq11jR8zQ BLMnwkyivCErXc6Svn3hWEr8KCZA+jp6NbQSiRfVHcVSrBkG66PbegHRdwb63pc9LHIt v6zEwqpsjwhpqCXjetYM9pPkyduyHPEC0ZRVfmsEsgR74Idv5jHisCdwnOZhpAVJyk+H Y8ObYJ+CdCAyF0uFb2IVaxoQCZ1XxtZKZE5Q5ujSrsd6tEHhux0RPdpTqh3tB4774fmf Xep2fKm8n61F12AcV++UXhpe+X9ANcmc/+zGjya7HhMWcDIHff2kwQwF8Nt0FXnfkGZU 7QXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694681191; x=1695285991; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KQEPjdH4Gli9KAKRohOP4WFvJ7BvjQDzxENQGkakYUo=; b=Lm++8JhkctIr6oEmxco1iVyts95PQQ3va2U/jWkmsKhp2wBQmp+1MFfh0udXnb55Bx fkg17ue2LOswG97hbOgAB9P/Le2uoRiUT5AfeK6YExNyxAtkrRCA7KrHUwj/kKOBozjL 1jRRnQzg3Ht0V3dKYID4PU9dgCE09gGZN9pl3oRvELfcC3OouQ6xwUweouXFmGNkYdaL D+n4o5gpadX0wUDdJr9/H9aktl0e1CqV5X5bkKLsLw4KqBtYkUKvKe6XMpen8LnRGov8 /vjV+teHsZaygB6EMqo0HIJizpuLhTlpadVtx2EqsY2kXeJ7v9Bj1mqH95N0JGihf5dE 4leg== X-Gm-Message-State: AOJu0Yx8mRslBT5eF75SwefXDimU1bWAL5HvPqr455Vw85Q0ESQdP1hB 7aVDvjYy1z2mu6GPKJ3oq+2j7A== X-Google-Smtp-Source: AGHT+IEirTjVMIzTLjC7sB1QXwQuxnOxm1+1fH/gEKNI6n9l8wkInADFzO37/+IpdsjO1bWWulPatg== X-Received: by 2002:a5d:6105:0:b0:319:8427:d221 with SMTP id v5-20020a5d6105000000b003198427d221mr4297904wrt.62.1694681191504; Thu, 14 Sep 2023 01:46:31 -0700 (PDT) Received: from localhost (cst2-173-16.cust.vodafone.cz. [31.30.173.16]) by smtp.gmail.com with ESMTPSA id y14-20020a5d4ace000000b003176eab8868sm1157269wrs.82.2023.09.14.01.46.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 01:46:31 -0700 (PDT) Date: Thu, 14 Sep 2023 10:46:30 +0200 From: Andrew Jones To: Haibo Xu Cc: xiaobo55x@gmail.com, Paul Walmsley , Palmer Dabbelt , Albert Ou , Paolo Bonzini , Shuah Khan , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Anup Patel , Atish Patra , Sean Christopherson , Ricardo Koller , Vishal Annapurve , Vipin Sharma , David Matlack , Aaron Lewis , Colton Lewis , Thomas Huth , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org Subject: Re: [PATCH v3 2/9] KVM: selftests: Unify the makefile rule for split targets Message-ID: <20230914-393dcb077c664af16c4830e4@orel> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230914_014634_544454_A8D4487A X-CRM114-Status: GOOD ( 15.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 14, 2023 at 09:36:56AM +0800, Haibo Xu wrote: > A separate makefile rule was used for split targets which was added > in patch(KVM: arm64: selftests: Split get-reg-list test code). This > could be avoided by minor changes to the recipes of current rule. > > Signed-off-by: Haibo Xu > --- > tools/testing/selftests/kvm/Makefile | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile > index a3bb36fb3cfc..7972269e8c5f 100644 > --- a/tools/testing/selftests/kvm/Makefile > +++ b/tools/testing/selftests/kvm/Makefile > @@ -249,13 +249,10 @@ TEST_DEP_FILES += $(patsubst %.o, %.d, $(SPLIT_TESTS_OBJS)) > -include $(TEST_DEP_FILES) > > $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED): %: %.o > - $(CC) $(CFLAGS) $(CPPFLAGS) $(LDFLAGS) $(TARGET_ARCH) $< $(LIBKVM_OBJS) $(LDLIBS) -o $@ > + $(CC) $(CFLAGS) $(CPPFLAGS) $(LDFLAGS) $(TARGET_ARCH) $^ $(LDLIBS) -o $@ > $(TEST_GEN_OBJ): $(OUTPUT)/%.o: %.c > $(CC) $(CFLAGS) $(CPPFLAGS) $(TARGET_ARCH) -c $< -o $@ > > -$(SPLIT_TESTS_TARGETS): %: %.o $(SPLIT_TESTS_OBJS) > - $(CC) $(CFLAGS) $(CPPFLAGS) $(LDFLAGS) $(TARGET_ARCH) $^ $(LDLIBS) -o $@ > - > EXTRA_CLEAN += $(LIBKVM_OBJS) $(TEST_DEP_FILES) $(TEST_GEN_OBJ) $(SPLIT_TESTS_OBJS) cscope.* > > x := $(shell mkdir -p $(sort $(dir $(LIBKVM_C_OBJ) $(LIBKVM_S_OBJ)))) > @@ -274,6 +271,7 @@ $(LIBKVM_STRING_OBJ): $(OUTPUT)/%.o: %.c > x := $(shell mkdir -p $(sort $(dir $(TEST_GEN_PROGS)))) > $(TEST_GEN_PROGS): $(LIBKVM_OBJS) > $(TEST_GEN_PROGS_EXTENDED): $(LIBKVM_OBJS) > +$(SPLIT_TESTS_TARGETS): $(OUTPUT)/%: $(ARCH_DIR)/%.o > > cscope: include_paths = $(LINUX_TOOL_INCLUDE) $(LINUX_HDR_PATH) include lib .. > cscope: > -- > 2.34.1 > Nice. Reviewed-by: Andrew Jones Thanks, drew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel