From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB525EDE9AD for ; Thu, 14 Sep 2023 12:00:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:CC:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jxeR8jCFsfwh0qEijYztoyp/hkP4steMVY6U1f6IefM=; b=fod8TLlXZPYqL8jkCN/wo5vRBW CKszj8BXugK7ZE92HRDLANCRNygUFnJDyeDPVHmQvyO4/gjFGlkvCZaQ/r1yRsFgD6x3IjV6ubx/0 vIT4g8q9pRBpRZKmBChFIEQ1DpYetbwAj/QO/mxJy+SWiiWSHJ/WiH8V8NYPcimWlKgnGbitwIbWK 3VuOQnr6Q+GMJ/CIDVDQ4KQ9wzYu+vrnt2rfSZ1jMeNhilI6Ze9Q9LhuXKNLDyuyUDxIt9jIOcZ+d bGs4HNcpYQZ59s04O4siSx3h/GY7WUpQJvYn5iwsT+nPIaXNGi7MzaiToTZHO4xx3Fky3lk8R2LDj 095tIP7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qgl11-008HRC-1P; Thu, 14 Sep 2023 12:00:11 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qgl0y-008HPn-1s for linux-arm-kernel@lists.infradead.org; Thu, 14 Sep 2023 12:00:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1694692809; x=1726228809; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=uG+F151bn68ScYDGWITqHNnwQWlUdsnNin/8aUVHZQI=; b=O8DIg80HocAfPoWS8Ky1SnyAvARg8NOdJ8kgWXqSP4WcHCgVBaR78qRi VxHqa943J7dBnm3X/Wewe8JXR/ytZzdee3uuw/yscq7oBSCz3kd3E0SEW J15Z1fQBhKKTmn8eRXuVwpuIh+Toq4lrRtlBOjA7N33DLNI+jUfTHE5QH rv/zM24I8St0d0J5qdahnqDDBCsLYYn1IULBMMXf4721ibxdisO2/byKx UFkj+tDUQe1n08vFnf1cD19m+61LYqei1PpkWcdPit+aywtTXi5LA5gBv ZrQqmMHLKRs71MZCxSTuLM0w6usxwI5voGyqrrwD5EU0tKJRa5cC0gRZ5 w==; X-CSE-ConnectionGUID: ws0ewmwgSamnGX1tUsKhPQ== X-CSE-MsgGUID: /eszNVWGQ2CCv9ifskaUFA== X-ThreatScanner-Verdict: Negative X-IronPort-AV: E=Sophos;i="6.02,146,1688454000"; d="asc'?scan'208";a="4651647" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Sep 2023 05:00:07 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 14 Sep 2023 04:59:56 -0700 Received: from wendy (10.10.85.11) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 14 Sep 2023 04:59:54 -0700 Date: Thu, 14 Sep 2023 12:59:38 +0100 From: Conor Dooley To: Ulf Hansson CC: Arnd Bergmann , Olof Johansson , , , , Walker Chen , Conor Dooley Subject: Re: [PATCH 13/17] pmdomain: starfive: Move Kconfig file to the pmdomain subsystem Message-ID: <20230914-delegator-dimple-51b9414caa28@wendy> References: <20230914111904.586744-1-ulf.hansson@linaro.org> MIME-Version: 1.0 In-Reply-To: <20230914111904.586744-1-ulf.hansson@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230914_050008_810301_D9EF55EB X-CRM114-Status: GOOD ( 23.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0015434476408116858==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0015434476408116858== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2kgF3gAKLh1ZoVxp" Content-Disposition: inline --2kgF3gAKLh1ZoVxp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hey, On Thu, Sep 14, 2023 at 01:19:04PM +0200, Ulf Hansson wrote: > The Kconfig belongs closer to the corresponding implementation, hence let= 's > move it from the soc subsystem to the pmdomain subsystem. >=20 > Cc: Walker Chen > Cc: Conor Dooley > Signed-off-by: Ulf Hansson Thanks for doing this, saved me having to! The series appears to have broken threading though, which can be seen pretty easily on lore: https://lore.kernel.org/all/20230914111904.586744-1-ulf.hansson@linaro.org/ Dunno if something is borked with your process while sending patches to only a subset of the total recipient list. > --- > MAINTAINERS | 2 +- > drivers/pmdomain/Kconfig | 1 + > drivers/{soc =3D> pmdomain}/starfive/Kconfig | 0 > drivers/soc/Kconfig | 1 - > 4 files changed, 2 insertions(+), 2 deletions(-) > rename drivers/{soc =3D> pmdomain}/starfive/Kconfig (100%) >=20 > diff --git a/MAINTAINERS b/MAINTAINERS > index 6b491ebcf790..b8eae18f0fb1 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -20523,7 +20523,7 @@ M: Conor Dooley > S: Maintained > T: git https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/ > F: Documentation/devicetree/bindings/soc/starfive/ > -F: drivers/soc/starfive/ > +F: drivers/pmdomain/starfive/ This isn't the correct change, just remove the drivers/soc/starfive bit entirely from this entry.=20 I've just been doing some review & sending PRs to Arnd for this stuff (or failing to send the PRs as you saw), I don't have particular interest in this driver other than helping out the starfive people with actually getting the code merged. Instead I think you should generalise the existing entry for the driver to cover the whole directory, so that it includes the Kconfig bits too: diff --git a/MAINTAINERS b/MAINTAINERS index fa7487b7729b..22c1a5e5b130 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -20564,7 +20564,7 @@ M: Walker Chen M: Changhuang Liang S: Supported F: Documentation/devicetree/bindings/power/starfive* -F: drivers/pmdomain/starfive/jh71xx-pmu.c +F: drivers/pmdomain/starfive/ F: include/dt-bindings/power/starfive,jh7110-pmu.h =20 STARFIVE SOC DRIVERS Thanks, Conor. > =20 > STARFIVE TRNG DRIVER > M: Jia Jie Ho > diff --git a/drivers/pmdomain/Kconfig b/drivers/pmdomain/Kconfig > index cfe9ea754062..67049ebf7265 100644 > --- a/drivers/pmdomain/Kconfig > +++ b/drivers/pmdomain/Kconfig > @@ -12,5 +12,6 @@ source "drivers/pmdomain/renesas/Kconfig" > source "drivers/pmdomain/rockchip/Kconfig" > source "drivers/pmdomain/samsung/Kconfig" > source "drivers/pmdomain/st/Kconfig" > +source "drivers/pmdomain/starfive/Kconfig" > =20 > endmenu > diff --git a/drivers/soc/starfive/Kconfig b/drivers/pmdomain/starfive/Kco= nfig > similarity index 100% > rename from drivers/soc/starfive/Kconfig > rename to drivers/pmdomain/starfive/Kconfig > diff --git a/drivers/soc/Kconfig b/drivers/soc/Kconfig > index 8b46da40f107..10a9ff84ff41 100644 > --- a/drivers/soc/Kconfig > +++ b/drivers/soc/Kconfig > @@ -23,7 +23,6 @@ source "drivers/soc/renesas/Kconfig" > source "drivers/soc/rockchip/Kconfig" > source "drivers/soc/samsung/Kconfig" > source "drivers/soc/sifive/Kconfig" > -source "drivers/soc/starfive/Kconfig" > source "drivers/soc/sunxi/Kconfig" > source "drivers/soc/tegra/Kconfig" > source "drivers/soc/ti/Kconfig" > --=20 > 2.34.1 >=20 --2kgF3gAKLh1ZoVxp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZQL1qgAKCRB4tDGHoIJi 0rVzAP9FY/ohd7on51vpfRecEpZAePbMsVUzl1EtVecCPOByggD/QiEkAxaXSUc9 B0yAQH4pjtfwzPASaPXW/nVoCDWDSQk= =22dE -----END PGP SIGNATURE----- --2kgF3gAKLh1ZoVxp-- --===============0015434476408116858== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0015434476408116858==--