From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A116DEDE9A1 for ; Thu, 14 Sep 2023 11:00:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Muv9sMzbG+TEskJCXZtiznOqcTTHyIm4nUtVv2YzG6A=; b=4RD3VVw+srzH/n Vkl227hd4HcoABLLbjOif/8g/aAfC8rvmzrjAk9exhGGDviq+nUFgI/ZNxP91Kaw/Py8sLna1IVYe gTZS8jIyPnfxUZa+xWMFSb+8KLD/rZQHjZlXTLeuZTP0F+MDeot9lHmjn3AtmpXUucEDYY+59gKhM uRccNMPTw9GBMD9j8m8CEAc3mfHopQ1ntdI9Yt2JncIdDHBwiWGOy9Dcgwf41P1/jn2MQD3npI4Zj ftjP8OsqhrKPHKZEXpqMR5yREfYa4K2lrsKRwXoCmE3Q+VJ9UWXkvEZCB+Z2srWdHjOzySEJOOcq5 qhl3MU4z9goas1Z6X1Iw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qgk5C-0086TL-0m; Thu, 14 Sep 2023 11:00:26 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qgk59-0086QU-10; Thu, 14 Sep 2023 11:00:24 +0000 Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4RmZ7B5FLBz6HJdN; Thu, 14 Sep 2023 18:58:30 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Thu, 14 Sep 2023 12:00:15 +0100 Date: Thu, 14 Sep 2023 12:00:14 +0100 From: Jonathan Cameron To: James Morse CC: , , , , , , , , , Salil Mehta , Russell King , Jean-Philippe Brucker , , Subject: Re: [RFC PATCH v2 03/35] drivers: base: Allow parts of GENERIC_CPU_DEVICES to be overridden Message-ID: <20230914120014.00002866@Huawei.com> In-Reply-To: <20230913163823.7880-4-james.morse@arm.com> References: <20230913163823.7880-1-james.morse@arm.com> <20230913163823.7880-4-james.morse@arm.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100004.china.huawei.com (7.191.162.219) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230914_040023_494463_34E0BFDE X-CRM114-Status: GOOD ( 12.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 13 Sep 2023 16:37:51 +0000 James Morse wrote: > Architectures often have extra per-cpu work that needs doing > before a CPU is registered, often to determine if a CPU is > hotpluggable. > > To allow the ACPI architectures to use GENERIC_CPU_DEVICES, move > the cpu_register() call into arch_register_cpu(), which is made __weak > so architectures with extra work can override it. > This aligns with the way x86, ia64 and loongarch register hotplug CPUs > when they become present. > > Signed-off-by: James Morse > --- > Changes since RFC: > * Dropped __init from x86/ia64 arch_register_cpu() Confused... > diff --git a/arch/ia64/kernel/topology.c b/arch/ia64/kernel/topology.c > index 94a848b06f15..741863a187a6 100644 > --- a/arch/ia64/kernel/topology.c > +++ b/arch/ia64/kernel/topology.c > @@ -59,7 +59,7 @@ void __ref arch_unregister_cpu(int num) > } > EXPORT_SYMBOL(arch_unregister_cpu); > #else > -static int __init arch_register_cpu(int num) > +int __init arch_register_cpu(int num) Still seems to be here... > { > return register_cpu(&sysfs_cpus[num].cpu, num); > } Even more confused because the block wasn't in the RFC at all. Maybe dropped static? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel