From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D097EDE9A8 for ; Thu, 14 Sep 2023 11:41:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wajiWVVZ1+FUHCtZXZiuWRcpguunD/f2w2IIwGNxcI4=; b=Qyg+AYsyNcXjYR oTA9j74h3bviL4LakGhhMzv1veSWWaQqRW8ewNB+R44Q3C25Luqk77gejIgJINYb9c8NJTRbmx9Xc EMMoc+kB94I6HX0PUnI15JxbR4ppO8LJWWcfObNHLRnhE7+gUF8H66wh2uzQdHUtnCkAJYLkUTiiW 3ok4ckUZLUmTjvs4Wn1V/gElZAsbYq6yZNf4mEHeNzoDAp3ts24Jj8oEs2eMJlCIPKFJRhaPlPyDY truEaF3pG0w2eCTTUiZIWcuGCwZOzlGtgbG8Tfe0TqXVBSV05HXHZ0yPTd16vC1/mkyq6JG8WdAnt ZCu9etODXRqG1KwUNQVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qgki2-008Fq3-2H; Thu, 14 Sep 2023 11:40:34 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qgkhz-008Fp5-2I; Thu, 14 Sep 2023 11:40:33 +0000 Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4RmZy93y83z6J6kK; Thu, 14 Sep 2023 19:35:45 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Thu, 14 Sep 2023 12:40:25 +0100 Date: Thu, 14 Sep 2023 12:40:25 +0100 From: Jonathan Cameron To: James Morse CC: , , , , , , , , , Salil Mehta , Russell King , Jean-Philippe Brucker , , Subject: Re: [RFC PATCH v2 08/35] x86/topology: Switch over to GENERIC_CPU_DEVICES Message-ID: <20230914124025.00006396@Huawei.com> In-Reply-To: <20230913163823.7880-9-james.morse@arm.com> References: <20230913163823.7880-1-james.morse@arm.com> <20230913163823.7880-9-james.morse@arm.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100006.china.huawei.com (7.191.160.224) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230914_044031_897303_2EA483B8 X-CRM114-Status: GOOD ( 16.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 13 Sep 2023 16:37:56 +0000 James Morse wrote: > Now that GENERIC_CPU_DEVICES calls arch_register_cpu(), which can be > overridden by the arch code, switch over to this to allow common code > to choose when the register_cpu() call is made. > > x86's struct cpus come from struct x86_cpu, which has no other members > or users. Remove this and use the version defined by common code. > > This is an intermediate step to the logic being moved to drivers/acpi, > where GENERIC_CPU_DEVICES will do the work when booting with acpi=off. > > Signed-off-by: James Morse > ---- > Changes since RFC: > * Fixed the second copy of arch_register_cpu() used for non-hotplug Hi James, See below for comment on this. Upshot - I think you can delete that function instead and rely on the weak version. If you can't because of a later change, useful to call that out in this patch description for those like me who read an review in a linear fashion! ... > EXPORT_SYMBOL(arch_unregister_cpu); > #else /* CONFIG_HOTPLUG_CPU */ > > -int __init arch_register_cpu(int num) > +int arch_register_cpu(int num) > { > - return register_cpu(&per_cpu(cpu_devices, num).cpu, num); > + return register_cpu(&per_cpu(cpu_devices, num), num); > } Looks like the weak version introduced in patch 3. Can this implementation go away and fallback to that? > #endif /* CONFIG_HOTPLUG_CPU */ > - > -static int __init topology_init(void) > -{ > - int i; > - > - for_each_present_cpu(i) > - arch_register_cpu(i); > - > - return 0; > -} > -subsys_initcall(topology_init); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel