From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DF33C2BA12 for ; Sat, 16 Sep 2023 20:56:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j6AqHzN8l9N6JHpD/wedIq5f0EsDY6+yWTQKCQrbbCw=; b=CKKnZGWEiMzJCn zel1stKmd83hTyzuBc4wrIc9U8gLXix8KSBJSEmJ9gUjKb10+kz9Ps1lbqeMApONO+BjiFIERdiZu My5fUbUKBFLSP3VSnDk/g3HliMfP8KQxFhcP3LY91bFaV52o4yRoofChDZxAuG7GKrfB3tFCEXN+W WMMXTt/TQWP43sjap4cx6p37YTkx+vFpC1+KuMy2mqBujP5immEyDgMWEE1UFifxsvF3d2P7pTucr OgOMu6LepDgbL+19RyORDamdoHEtLygnQ2rK6vuTqoe2YjLLuuAs5YQ+kphfhx1hCGIIw3QGpjyNd zNxn69KExaCMWOrSXCkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qhcKZ-00Cp6M-0O; Sat, 16 Sep 2023 20:55:55 +0000 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qhcKW-00Cp5v-1D for linux-arm-kernel@lists.infradead.org; Sat, 16 Sep 2023 20:55:54 +0000 Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-50300e9e75bso1194643e87.1 for ; Sat, 16 Sep 2023 13:55:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1694897749; x=1695502549; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OtXy98myC9Xeki202X9z45U3TYQHZBLtWJzwGTAcxHE=; b=A6imnmTfJdXUyLnQRr0zx5RE4USzo4Dy4yfnF+DBlIFB31eNJqJlFKTQvTAwroYLcf oDei4j0bUi06pFpksaAs5oosk0p31MdTct7jkYQrcp6J3YpL/2wCvGQ9W81/N9aDL6Us iDCRhlfh1TknVMcApiX+9+Stx9vYTQVZNckpzvPVMlgI4UUVPcHy90ky/egB29TwRSFb YjfD1wKGk5agd0LrH25yZpWwKQyliWl9SsJwHLxnDS6TwFIsetI/DWe7npZ6pnYd7VBk CDp1ULwnXl9uSuMbo1A9DGKoDOJi4k4vJ/eMTru0LhIAeCPmykWu7bVZCqjNoD6dP5jR Dhlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694897749; x=1695502549; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OtXy98myC9Xeki202X9z45U3TYQHZBLtWJzwGTAcxHE=; b=HUYdAvLYJ3wIsSnF592jsxeGm4QsVKRSto0+Gq1Cg+GrhosFu897YInA5oiB9VqUNn vzZcRwnPLOTN7JuiDTwfPoLRHcyKkRywsS3+f+GMymbifJtY88Jgfeh00svPEDdWoreF lYfiHtGT+/fBMCkZWmUWIEpTWu3BqLGM8PVnEIUbB0+EgvV23vZWAF77DLIT6QWwge8x lqyz0SOXzBuF8FCrPpHo0Y/+iXYF2DFfvxR2GBJ/j2ajsxwPZhn0/5kUJTEYZazyTzC7 Xv/fWXsGjF1rnJscvj15xEfabdXH90q9+SlHWCfH68h0eiJW/JTZupmmmY2hF8G/jmFH 7nKQ== X-Gm-Message-State: AOJu0YyAK1Hk5pnwlJWc0RVp2ztNk6zWfHQA5rxJ9ggWnWtNeYql+p+h xqkw02EijkkLVH8a+BdngDNDvqQ5EiqguA== X-Google-Smtp-Source: AGHT+IHLF2BDHMY5EQ2cLRGY88cc4GRtF1HNeGRvKmupJtgipgh1Tp2VYUmzRaB1Rid1OduuxyxRJA== X-Received: by 2002:a05:6512:2fc:b0:4f8:77db:1d9e with SMTP id m28-20020a05651202fc00b004f877db1d9emr4255346lfq.12.1694897749352; Sat, 16 Sep 2023 13:55:49 -0700 (PDT) Received: from localhost.localdomain ([78.37.168.140]) by smtp.gmail.com with ESMTPSA id br19-20020a056512401300b00502fd9110ffsm454504lfb.294.2023.09.16.13.55.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Sep 2023 13:55:48 -0700 (PDT) From: Ivan Bornyakov To: sebastian.fricke@collabora.com Cc: Ivan Bornyakov , bob.beckett@collabora.com, conor+dt@kernel.org, devicetree@vger.kernel.org, festevam@gmail.com, hverkuil@xs4all.nl, jackson.lee@chipsnmedia.com, kernel@collabora.com, kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, mchehab@kernel.org, nas.chung@chipsnmedia.com, nicolas.dufresne@collabora.com, p.zabel@pengutronix.de, robh+dt@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org Subject: Re: [PATCH v12 5/7] media: chips-media: wave5: Add the v4l2 layer Date: Sat, 16 Sep 2023 23:55:40 +0300 Message-ID: <20230916205542.9410-1-brnkv.i1@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230915-wave5_v12_on_media_master-v12-5-92fc66cd685d@collabora.com> References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230916_135552_439903_B15E6327 X-CRM114-Status: GOOD ( 22.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Sebastian, On Fri, Sep 15, 2023 at 23:11:34 +0200, Sebastian Fricke wrote: > From: Nas Chung > > Add the decoder and encoder implementing the v4l2 > API. This patch also adds the Makefile and the VIDEO_WAVE_VPU config > > Signed-off-by: Sebastian Fricke > Signed-off-by: Nicolas Dufresne > Signed-off-by: Robert Beckett > Signed-off-by: Dafna Hirschfeld > Signed-off-by: Nas Chung [...] > diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu.c b/drivers/media/platform/chips-media/wave5/wave5-vpu.c > new file mode 100644 > index 000000000000..a13d968f5d04 > --- /dev/null > +++ b/drivers/media/platform/chips-media/wave5/wave5-vpu.c [...] > +static void wave5_vpu_get_interrupt_for_inst(struct vpu_instance *inst, u32 status) > +{ > + struct vpu_device *dev = inst->dev; > + u32 seq_done; > + u32 cmd_done; > + int val; > + > + seq_done = wave5_vdi_read_register(dev, W5_RET_SEQ_DONE_INSTANCE_INFO); > + cmd_done = wave5_vdi_read_register(dev, W5_RET_QUEUE_CMD_DONE_INST); > + > + if (status & BIT(INT_WAVE5_INIT_SEQ)) { > + if (seq_done & BIT(inst->id)) { > + seq_done &= ~BIT(inst->id); > + wave5_vdi_write_register(dev, W5_RET_SEQ_DONE_INSTANCE_INFO, seq_done); > + val = BIT(INT_WAVE5_INIT_SEQ); > + kfifo_in(&inst->irq_status, &val, sizeof(int)); > + } > + } > + if (status & BIT(INT_WAVE5_ENC_SET_PARAM)) { > + if (seq_done & BIT(inst->id)) { > + seq_done &= ~BIT(inst->id); > + wave5_vdi_write_register(dev, W5_RET_SEQ_DONE_INSTANCE_INFO, seq_done); > + val = BIT(INT_WAVE5_ENC_SET_PARAM); > + kfifo_in(&inst->irq_status, &val, sizeof(int)); > + } > + } > + if (status & BIT(INT_WAVE5_DEC_PIC) || > + status & BIT(INT_WAVE5_ENC_PIC)) { > + if (cmd_done & BIT(inst->id)) { > + cmd_done &= ~BIT(inst->id); > + wave5_vdi_write_register(dev, W5_RET_QUEUE_CMD_DONE_INST, cmd_done); > + val = BIT(INT_WAVE5_DEC_PIC); > + kfifo_in(&inst->irq_status, &val, sizeof(int)); > + } > + } > +} > + > +static irqreturn_t wave5_vpu_irq(int irq, void *dev_id) > +{ > + struct vpu_device *dev = dev_id; > + > + if (wave5_vdi_read_register(dev, W5_VPU_VPU_INT_STS)) { > + struct vpu_instance *inst; > + u32 irq_status = wave5_vdi_read_register(dev, W5_VPU_VINT_REASON); > + > + list_for_each_entry(inst, &dev->instances, list) { > + wave5_vpu_get_interrupt_for_inst(inst, irq_status); > + } > + > + wave5_vdi_write_register(dev, W5_VPU_VINT_REASON_CLR, irq_status); > + wave5_vdi_write_register(dev, W5_VPU_VINT_CLEAR, 0x1); > + > + return IRQ_WAKE_THREAD; > + } > + > + return IRQ_HANDLED; > +} > + > +static irqreturn_t wave5_vpu_irq_thread(int irq, void *dev_id) > +{ > + struct vpu_device *dev = dev_id; > + struct vpu_instance *inst; > + int irq_status, ret; > + > + list_for_each_entry(inst, &dev->instances, list) { > + while (kfifo_len(&inst->irq_status)) { > + ret = kfifo_out(&inst->irq_status, &irq_status, sizeof(int)); > + if (!ret) > + break; > + > + if (irq_status == BIT(INT_WAVE5_INIT_SEQ) || > + irq_status == BIT(INT_WAVE5_ENC_SET_PARAM)) > + complete(&inst->irq_done); > + else /* DEC/ENC_PIC */ > + inst->ops->finish_process(inst); > + > + wave5_vpu_clear_interrupt(inst, irq_status); > + } > + } > + > + return IRQ_HANDLED; > +} I believe, instead of wave5_vpu_irq() + wave5_vpu_get_interrupt_for_inst() + wave5_vpu_irq_thread() you can reduce interrupt handling to only threaded part with something like this: static irqreturn_t wave5_vpu_irq_thread(int irq, void *dev_id) { u32 irq_status, seq_done, cmd_done; struct vpu_device *dev = dev_id; struct vpu_instance *inst; while (wave5_vdi_read_register(dev, W5_VPU_VPU_INT_STS)) { irq_status = wave5_vdi_read_register(dev, W5_VPU_VINT_REASON); seq_done = wave5_vdi_read_register(dev, W5_RET_SEQ_DONE_INSTANCE_INFO); cmd_done = wave5_vdi_read_register(dev, W5_RET_QUEUE_CMD_DONE_INST); list_for_each_entry(inst, &dev->instances, list) { if (irq_status & BIT(INT_WAVE5_INIT_SEQ) || irq_status & BIT(INT_WAVE5_ENC_SET_PARAM)) { if (seq_done & BIT(inst->id)) { seq_done &= ~BIT(inst->id); wave5_vdi_write_register(dev, W5_RET_SEQ_DONE_INSTANCE_INFO, seq_done); complete(&inst->irq_done); } } if (status & BIT(INT_WAVE5_DEC_PIC) || status & BIT(INT_WAVE5_ENC_PIC)) { if (cmd_done & BIT(inst->id)) { cmd_done &= ~BIT(inst->id); wave5_vdi_write_register(dev, W5_RET_QUEUE_CMD_DONE_INST, cmd_done); inst->ops->finish_process(inst); } } wave5_vpu_clear_interrupt(inst, irq_status); } wave5_vdi_write_register(dev, W5_VPU_VINT_REASON_CLR, irq_status); wave5_vdi_write_register(dev, W5_VPU_VINT_CLEAR, 0x1); } return IRQ_HANDLED; } Is it better? [...] > +static int wave5_vpu_probe(struct platform_device *pdev) > +{ > + int ret; > + struct vpu_device *dev; > + const struct wave5_match_data *match_data; > + u32 fw_revision; > + > + match_data = device_get_match_data(&pdev->dev); > + if (!match_data) { > + dev_err(&pdev->dev, "missing device match data\n"); > + return -EINVAL; > + } > + > + /* physical addresses limited to 32 bits */ > + dma_set_mask(&pdev->dev, DMA_BIT_MASK(32)); > + dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32)); dma_set_mask_and_coherent()? Also error check? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel