From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4049DCD37B0 for ; Mon, 18 Sep 2023 10:52:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XbTxnnfMrKjS392Sprh49FrSBE08TBbpc/mUQCBZfB4=; b=f5nLPWrqxaN7rb V2KNu7A8fiP4hLY+OeHIqkBvI347mIeB81cUlQb8qe01Zm5o9NrmmtzYjne5md+ErZupxwxfFrrxh iHTa8Lp2uNlgoL1pCodqado1a4qijlioUf8z+FXlw4bJvp8Ndg5B1H7dOqLdOWcF8psXv7Jqtfwk5 m1Tbn5M1a9Q7IFp5GKEB2/ie7oif+wPZX8twLARI4sjn/HzEfAcBJna6is6m1EJkO5mNSwkfbRPf7 EzVxZevuDKmiS/e+CJFIUNny6cmPphDX1QVUMQ4Dfj5caHuK40m1jHb5/XEDV5EpECceSx5SPcolW Pw/Sp9fu7U/U1WipVrSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qiBrh-00FGXP-1i; Mon, 18 Sep 2023 10:52:29 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qiBre-00FGX0-23 for linux-arm-kernel@lists.infradead.org; Mon, 18 Sep 2023 10:52:27 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3EFCD1FB; Mon, 18 Sep 2023 03:53:02 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B01713F67D; Mon, 18 Sep 2023 03:52:23 -0700 (PDT) Date: Mon, 18 Sep 2023 11:52:21 +0100 From: Sudeep Holla To: Oza Pawandeep Cc: catalin.marinas@arm.com, will@kernel.org, rafael@kernel.org, lenb@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v7] cpuidle, ACPI: Evaluate LPI arch_flags for broadcast timer Message-ID: <20230918105221.msuwbo2deya6rdim@bogus> References: <20230915202511.1452091-1-quic_poza@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230915202511.1452091-1-quic_poza@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230918_035226_742572_1CAEE01C X-CRM114-Status: GOOD ( 14.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 15, 2023 at 01:25:11PM -0700, Oza Pawandeep wrote: > Arm=AE Functional Fixed Hardware Specification defines LPI states, > which provide an architectural context loss flags field that can > be used to describe the context that might be lost when an LPI > state is entered. > = > - Core context Lost > - General purpose registers. > - Floating point and SIMD registers. > - System registers, include the System register based > - generic timer for the core. > - Debug register in the core power domain. > - PMU registers in the core power domain. > - Trace register in the core power domain. > - Trace context loss > - GICR > - GICD > = > Qualcomm's custom CPUs preserves the architectural state, > including keeping the power domain for local timers active. > when core is power gated, the local timers are sufficient to > wake the core up without needing broadcast timer. > = > The patch fixes the evaluation of cpuidle arch_flags, and moves only to > broadcast timer if core context lost is defined in ACPI LPI. > = > Fixes: a36a7fecfe607 ("Add support for Low Power Idle(LPI) states") > Reviewed-by: Sudeep Holla > Signed-off-by: Oza Pawandeep > --- > = > Notes: > Will/Catalin: Rafael has acked and he prefers to take it via arm64 tr= ee You need to add the tags received. You have added my review tag but not the Rafael's Acked-by tag. -- = Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel