From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0972DC46CA1 for ; Mon, 18 Sep 2023 15:18:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7NPk+aloPUFf5fmGR3xPhWorRyI58gnZZt+fMDahOiE=; b=JHPRtWBiC+lWvZ Kn9wE3A0mTo5UGNddCn2hJgbY8U/iwJVy+S8/prZLg/viBdLdZWWM+/mc67loeH13q8mrpYnbJE/b UCyZ/9UIalkpYthEpFRMm43ibjMoa7aO13NngZAYH5WzwZwVQFnT+zrldgvLzNhl3eYJ81fJzJTpI wyM+Mx3SWJonNqcK4oyOLW/X29HL0BerfzR7i4n5ME4Xk7BPsbdUaxh5Q9SxYmiEaV9QUQ3F+E/RS lI4hHprADopvO3jhPQo7tbz8DzMPcHiMAz9AnYnaCbUgL1lWxUq356LXYUoLG8bGjZNaLrtbQM0sg QYlZZWbzGAM1zG5vKXsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qiG0r-00Fjoj-12; Mon, 18 Sep 2023 15:18:13 +0000 Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qiG0m-00FjkN-1d for linux-arm-kernel@lists.infradead.org; Mon, 18 Sep 2023 15:18:10 +0000 Received: by mail-qk1-x72e.google.com with SMTP id af79cd13be357-76dc77fd024so300974185a.3 for ; Mon, 18 Sep 2023 08:18:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1695050286; x=1695655086; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=skILK3+RqLs29/E8NIb2upQKKLhMeBuYLpBX+o8j0o8=; b=n6jL8wh9yZ+YgRCLkcZ7AcXMqtF/+gWvKXPg79MBnBzPl+oy3YGjGVxJHE0oTf+grK 4eBpJn2CkNmuZLQ6JXhw8gi92dSULrCQ68cbue+gfH+gI3TMpgvflAe41qWA/H9yl5y0 F2Tk3h5NyUF0vt7XtXH1LTU0D7CgV7suKA1JRT0DuAsvJ6fPGd7yorKBW3ptnFHR4qzB jsZT9Id1Wp2BRJBHPTFDuG/lxCbfoGl3a+x5R2K82rt6xJCAY5ivDf2AZKoD5bN4Gx2N mXINTA8WpsFcfrKuOoZ+9Vp7cu+6pKubcCsD+0lb3X0mfbUdaZwjU9LS50fLmW0+Ml/6 WqMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695050286; x=1695655086; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=skILK3+RqLs29/E8NIb2upQKKLhMeBuYLpBX+o8j0o8=; b=CbxHu4527v+nXRG8tN8fVKb0+Uact34dhJ2WzGF+PB/oUxwpCpo8ZGhVVAi0M9mdJL H+qE9asgC27VjMdgg6PJNwou3by6gCoGp0K43nJvW6Jo2FNmSPBuL9tnfa00ZdpjCGkt 11wTp14Bo8QSOBGapK66fj1bwPCU0doHkVVcoNw49id6vkPjjlLl28PPDGJBAA8rI/uu WgYSJi8BjKA0RNxaxeNcHKMe7hktup8gNA+SH+QeS/1vIlMovV8dKVhbcwLScWoen+YQ 8tAHS8eW+kqyrpKC++Jug3Ft+nwoCq5kHyxjoUP2wtf5r9nNZQONw0eogq6b1yX/J+5N 2Q7A== X-Gm-Message-State: AOJu0Yx7XniTn6Ug4UslaXCCMtrNzHx057AvWJFxNbMdNqDBF56+lGBb LeTqKmzBo9Mh/+vD86eSkOmH9Q== X-Google-Smtp-Source: AGHT+IEPjZK20Aqh4DOH80nyWTVB2XY8RoIapnvcyiksM3wp5qxi6JV9wSTNi2A0D4DmrBL930vlSw== X-Received: by 2002:ad4:458d:0:b0:63f:9aa3:867b with SMTP id x13-20020ad4458d000000b0063f9aa3867bmr9395365qvu.40.1695050286275; Mon, 18 Sep 2023 08:18:06 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-26-201.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.26.201]) by smtp.gmail.com with ESMTPSA id r28-20020a0cb29c000000b0063d038df3f3sm3532215qve.52.2023.09.18.08.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 08:18:05 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1qiG0i-0005OR-Iy; Mon, 18 Sep 2023 12:18:04 -0300 Date: Mon, 18 Sep 2023 12:18:04 -0300 From: Jason Gunthorpe To: Sean Christopherson Cc: Catalin Marinas , Will Deacon , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Peter Zijlstra , Arnaldo Carvalho de Melo , Paolo Bonzini , Tony Krowiak , Halil Pasic , Jason Herne , Harald Freudenberger , Alex Williamson , Andy Lutomirski , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Anish Ghulati , Venkatesh Srinivas , Andrew Thornton Subject: Re: [PATCH 03/26] virt: Declare and define vfio_file_set_kvm() iff CONFIG_KVM is enabled Message-ID: <20230918151804.GH13795@ziepe.ca> References: <20230916003118.2540661-1-seanjc@google.com> <20230916003118.2540661-4-seanjc@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230916003118.2540661-4-seanjc@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230918_081808_584724_A72E1DC8 X-CRM114-Status: GOOD ( 15.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 15, 2023 at 05:30:55PM -0700, Sean Christopherson wrote: > Hide vfio_file_set_kvm() and its unique helpers if KVM is not enabled, > nothing else in the kernel (or out of the kernel) should be using a > KVM specific helper. > > Signed-off-by: Sean Christopherson > --- > drivers/vfio/vfio_main.c | 2 +- > include/linux/vfio.h | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) Patch subject should be vfio not virt Reviewed-by: Jason Gunthorpe > @@ -1388,6 +1387,7 @@ void vfio_file_set_kvm(struct file *file, struct kvm *kvm) > vfio_device_file_set_kvm(file, kvm); > } > EXPORT_SYMBOL_GPL(vfio_file_set_kvm); > +#endif We could even put this in a symbol namespace.. Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel