* [PATCH 1/1] spi: imx: take in account bits per word instead of assuming 8-bits
@ 2023-09-18 15:36 Stefan Moring
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Moring @ 2023-09-18 15:36 UTC (permalink / raw)
To: broonie, shawnguo, s.hauer, festevam, linux-imx, linux-spi,
linux-arm-kernel, sre
Cc: Stefan Moring
The IMX spi driver has a hardcoded 8, breaking the driver for word
lengths other than 8.
Signed-off-by: Stefan Moring <stefanmoring@gmail.com>
---
drivers/spi/spi-imx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
index a8a74c7cb79f..498e35c8db2c 100644
--- a/drivers/spi/spi-imx.c
+++ b/drivers/spi/spi-imx.c
@@ -662,7 +662,7 @@ static int mx51_ecspi_prepare_transfer(struct spi_imx_data *spi_imx,
if (spi_imx->count >= 512)
ctrl |= 0xFFF << MX51_ECSPI_CTRL_BL_OFFSET;
else
- ctrl |= (spi_imx->count*8 - 1)
+ ctrl |= (spi_imx->count * spi_imx->bits_per_word - 1)
<< MX51_ECSPI_CTRL_BL_OFFSET;
}
--
2.42.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 1/1] take in account bits per word instead of assuming 8-bits
@ 2023-09-17 16:40 Stefan Moring
2023-09-17 18:47 ` [PATCH 1/1] spi: imx: " Sebastian Reichel
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Moring @ 2023-09-17 16:40 UTC (permalink / raw)
To: broonie, shawnguo, s.hauer, festevam, linux-imx, linux-psi,
linux-arm-kernel, linux-kernel, sre
Cc: Stefan Moring
The IMX spi driver has a hardcoded 8, breaking the driver for word
lengths other than 8.
Signed-off-by: Stefan Moring <stefanmoring@gmail.com>
---
drivers/spi/spi-imx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
index a8a74c7cb79f..498e35c8db2c 100644
--- a/drivers/spi/spi-imx.c
+++ b/drivers/spi/spi-imx.c
@@ -662,7 +662,7 @@ static int mx51_ecspi_prepare_transfer(struct spi_imx_data *spi_imx,
if (spi_imx->count >= 512)
ctrl |= 0xFFF << MX51_ECSPI_CTRL_BL_OFFSET;
else
- ctrl |= (spi_imx->count*8 - 1)
+ ctrl |= (spi_imx->count * spi_imx->bits_per_word - 1)
<< MX51_ECSPI_CTRL_BL_OFFSET;
}
--
2.42.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] spi: imx: take in account bits per word instead of assuming 8-bits
2023-09-17 16:40 [PATCH 1/1] " Stefan Moring
@ 2023-09-17 18:47 ` Sebastian Reichel
2023-09-18 12:48 ` Fabio Estevam
0 siblings, 1 reply; 3+ messages in thread
From: Sebastian Reichel @ 2023-09-17 18:47 UTC (permalink / raw)
To: Stefan Moring
Cc: broonie, shawnguo, s.hauer, festevam, linux-imx, linux-psi,
linux-arm-kernel, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1181 bytes --]
Hi,
On Sun, Sep 17, 2023 at 06:40:37PM +0200, Stefan Moring wrote:
> The IMX spi driver has a hardcoded 8, breaking the driver for word
> lengths other than 8.
>
> Signed-off-by: Stefan Moring <stefanmoring@gmail.com>
> ---
patch subject is missing the 'spi: imx:' prefix. Otherwise:
Reported-by: Sebastian Reichel <sre@kernel.org>
Fixes: 15a6af94a277 ("spi: Increase imx51 ecspi burst length based on transfer length")
Tested-by: Sebastian Reichel <sre@kernel.org>
(no need to Cc stable, since the regression is only in v6.6-rc1)
-- Sebastian
> drivers/spi/spi-imx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
> index a8a74c7cb79f..498e35c8db2c 100644
> --- a/drivers/spi/spi-imx.c
> +++ b/drivers/spi/spi-imx.c
> @@ -662,7 +662,7 @@ static int mx51_ecspi_prepare_transfer(struct spi_imx_data *spi_imx,
> if (spi_imx->count >= 512)
> ctrl |= 0xFFF << MX51_ECSPI_CTRL_BL_OFFSET;
> else
> - ctrl |= (spi_imx->count*8 - 1)
> + ctrl |= (spi_imx->count * spi_imx->bits_per_word - 1)
> << MX51_ECSPI_CTRL_BL_OFFSET;
> }
>
> --
> 2.42.0
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] spi: imx: take in account bits per word instead of assuming 8-bits
2023-09-17 18:47 ` [PATCH 1/1] spi: imx: " Sebastian Reichel
@ 2023-09-18 12:48 ` Fabio Estevam
0 siblings, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2023-09-18 12:48 UTC (permalink / raw)
To: Sebastian Reichel
Cc: Stefan Moring, broonie, shawnguo, s.hauer, linux-imx, linux-psi,
linux-arm-kernel, linux-kernel
Hi Stefan,
There is a typo in the spi mailing list. It should be linux-spi@vger.kernel.org.
On Sun, Sep 17, 2023 at 3:47 PM Sebastian Reichel <sre@kernel.org> wrote:
>
> Hi,
>
> On Sun, Sep 17, 2023 at 06:40:37PM +0200, Stefan Moring wrote:
> > The IMX spi driver has a hardcoded 8, breaking the driver for word
> > lengths other than 8.
> >
> > Signed-off-by: Stefan Moring <stefanmoring@gmail.com>
> > ---
>
> patch subject is missing the 'spi: imx:' prefix. Otherwise:
>
> Reported-by: Sebastian Reichel <sre@kernel.org>
> Fixes: 15a6af94a277 ("spi: Increase imx51 ecspi burst length based on transfer length")
> Tested-by: Sebastian Reichel <sre@kernel.org>
With the above tags added and the Subject line fixed:
Reviewed-by: Fabio Estevam <festevam@gmail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-18 15:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-18 15:36 [PATCH 1/1] spi: imx: take in account bits per word instead of assuming 8-bits Stefan Moring
-- strict thread matches above, loose matches on Subject: below --
2023-09-17 16:40 [PATCH 1/1] " Stefan Moring
2023-09-17 18:47 ` [PATCH 1/1] spi: imx: " Sebastian Reichel
2023-09-18 12:48 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).