From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88B69C46CA1 for ; Mon, 18 Sep 2023 13:40:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZgUgqMDg+R6LWqxA9BRJvo1nwEXU1AbttuOt5UPxQdk=; b=Eb+TTrJ/mkRlP9 fLHb1n0hZ5+GtJPkSOuUKdqGDwkJ6WeLzKe07j4Rg8GMG0k5r5ZqcB/i4Ugd01dSViF8Kr4L2vhK6 ZoEpvZZU57lnHglLvgFH8TL/cyylbGZ6GjwWccbbqYb7a4WrBYmoCinZiOIoQvCRPt6iVIbYY1Hb4 Jqw+aEI5f3U5LLeal5gDm1ZOBnIkvbqOvGJ3mVYYe6vd8ytdIV8ljA8TdP1mlvvXpFGBJAEcbabzi joJtokuLDKUH/E5epLsUZMiE52r8eBHT+0tzhARcN40zcKEYixAy6b2ll3espT9Y3H5KXkBZOZkwj 0QXe9yxBxtQlT0AnMZUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qiETf-00FaLt-2V; Mon, 18 Sep 2023 13:39:51 +0000 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qiETc-00FaKt-20; Mon, 18 Sep 2023 13:39:50 +0000 Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38IDW6fj029216; Mon, 18 Sep 2023 13:39:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=pp1; bh=MSStuaxrt3lPU0HToni05ntjf8mTFhyARXhcilaZ3Qc=; b=H+pxQ1+Ho7+UtVHW+L+9U4TuBLIXLcxbX+V8fMPXWPDnrPxLop3kj0Ug8XoR2+7cKQxH SkSawKO1zJz6g6f71w4b0EoO4uNyXLTmMybbt1oSFzLZL/Qo2VuDiZUVaRy8O0lKe4Ie CE4N/VgGVZ0sdqRvJ4nmUpzypFxx5VVNSV2ae3lFRT0BCZftapG4ledUVupfc4IyjW/o Mkw6CToee56m1uHFs9Ymm8uXoghcEP3ll/zGtQDUN6osRFCSgNxDiEfxlDJVUrw+EM6X qVY8aKeJ+eCYRb+5QaUpCGr2Ui6Q9h6hURBdTbM65CcsEn9BOGcShugNqh9g5Wj0ArRc Ug== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3t6qcnreuh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Sep 2023 13:39:06 +0000 Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 38IDNBeL019026; Mon, 18 Sep 2023 13:39:05 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3t6qcnretu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Sep 2023 13:39:05 +0000 Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 38IDXOwx016436; Mon, 18 Sep 2023 13:39:04 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3t5sd1jkpv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Sep 2023 13:39:04 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 38IDd1K314025382 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 18 Sep 2023 13:39:01 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9DC312004B; Mon, 18 Sep 2023 13:39:01 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CCB1C20040; Mon, 18 Sep 2023 13:39:00 +0000 (GMT) Received: from p-imbrenda (unknown [9.152.224.66]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 18 Sep 2023 13:39:00 +0000 (GMT) Date: Mon, 18 Sep 2023 15:38:49 +0200 From: Claudio Imbrenda To: Sean Christopherson Cc: Catalin Marinas , Will Deacon , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Janosch Frank , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Peter Zijlstra , Arnaldo Carvalho de Melo , Paolo Bonzini , Tony Krowiak , Halil Pasic , Jason Herne , Harald Freudenberger , Alex Williamson , Andy Lutomirski , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Anish Ghulati , Venkatesh Srinivas , Andrew Thornton Subject: Re: [PATCH 18/26] KVM: s390: Stop adding virt/kvm to the arch include path Message-ID: <20230918153849.0363e8f9@p-imbrenda> In-Reply-To: <20230916003118.2540661-19-seanjc@google.com> References: <20230916003118.2540661-1-seanjc@google.com> <20230916003118.2540661-19-seanjc@google.com> Organization: IBM X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: fPGL0P6aBZRPKpHoi9BsueIs0DR2UDLH X-Proofpoint-GUID: IufBZyFpbUqfPMs_X5VI6hKT9V7tJleH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-18_06,2023-09-18_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 suspectscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 phishscore=0 malwarescore=0 priorityscore=1501 spamscore=0 mlxscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309180114 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230918_063948_800729_B47C1F87 X-CRM114-Status: GOOD ( 24.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 15 Sep 2023 17:31:10 -0700 Sean Christopherson wrote: > Don't add virt/kvm to KVM s390's include path, the headers in virt/kvm are > intended to be used only by other code in virt/kvm, i.e. are "private" to > the core KVM code. It's not clear that s390 *ever* included a header from > virt/kvm, i.e. odds are good the "-Ivirt/kvm" was copied from a x86's > Makefile when s390 support was first added. > > The only headers in virt/kvm at the time were the x86 specific ioapic.h, > and iodev.h, neither of which shows up as an #include in the diff for the > commit range 37817f2982d0f..e976a2b997fc4. > > Signed-off-by: Sean Christopherson > --- > arch/s390/kvm/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/s390/kvm/Makefile b/arch/s390/kvm/Makefile > index 02217fb4ae10..f17249ab2a72 100644 > --- a/arch/s390/kvm/Makefile > +++ b/arch/s390/kvm/Makefile > @@ -5,7 +5,7 @@ > > include $(srctree)/virt/kvm/Makefile.kvm > > -ccflags-y := -Ivirt/kvm -Iarch/s390/kvm > +ccflags-y := -Iarch/s390/kvm > > kvm-y += kvm-s390.o intercept.o interrupt.o priv.o sigp.o > kvm-y += diag.o gaccess.o guestdbg.o vsie.o pv.o Acked-by: Claudio Imbrenda _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel