From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE03CC46CA1 for ; Mon, 18 Sep 2023 19:48:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MAXSFAKrR+wLYS8uJo2AYcsIacF6MGSYAlQaMkoYF/M=; b=O4lZWj134Q5OIj XMV4BMcab0PQ8F4B2NApUwlGE4c02MHLSk6jFBu0Mta8OfMYAcRq8Ygd8CLulkrwTDWWpvvLbYCdd rawaffiAZ3gr9zMK3KUloxv2CU0O3ECYVDxLY+64qZ3mkzRamRRPsSlXDaIUhbnn1qtppV/+i32wS gc2u4Pr3pjEkD/kTcwkzmOEqRc7HuzQkqkD0LSo+KEwWKyGC+P1yQQpR/z28c9wCCuz/kwYrmNOMo z/qkjK+PCFWCOfRAGnnoPUNytib4mgh/5P3q/jbc55LgQuzpL5zm/dXEe/qnLE8VMPNfVkfr//eP+ jXWEGDxjWkGHGjU6Uc9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qiKDq-00GDN5-0v; Mon, 18 Sep 2023 19:47:54 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qiKDm-00GDLf-1v; Mon, 18 Sep 2023 19:47:52 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id BA215CE0B19; Mon, 18 Sep 2023 19:47:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D85BBC433C9; Mon, 18 Sep 2023 19:47:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695066467; bh=ewvdOKMJiJkXoXzc+h132xxTW89f9qi+QEhmHjAqHsY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RfTEKuAy8jLjjuWXkRdfn/hGnmvYFUCfWoPOiIQ/XZYIGIGYuZR7PNwQ+UbGSSYcU kXH2kUhNHsCrhF/ymroD3V808e5Q+hss4Zmj8l/Rxs3W+/2FR9yFHM+UVuFp4pbVW4 UAjvVQU/1IGvwK+wRMFt3TgDu7Und3b6+6MKi7nlzIeQKexugEhJZiwyTPZ5ow65XW zJSOL7gIZ1ub5Gch+g7PHZ8+fNUxcyoqs57G9F6LBfyf++GKeoH04jQBtPuDlcA7a4 ohvadedFu6yUU5onAzhDYDcXmAVXjSFwGWXQrlEXnaL6Bshpcoyfd0Z6GCN7g/tzRm U77lQjwzOq1vQ== Received: (nullmailer pid 1577852 invoked by uid 1000); Mon, 18 Sep 2023 19:47:44 -0000 Date: Mon, 18 Sep 2023 14:47:44 -0500 From: Rob Herring To: AngeloGioacchino Del Regno Cc: Krzysztof Kozlowski , William-tw Lin , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , Kevin Hilman , Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 3/3] dt-bindings: hwinfo: Add mtk-socinfo driver Message-ID: <20230918194744.GA1572413-robh@kernel.org> References: <20230915152607.18116-1-william-tw.lin@mediatek.com> <20230915152607.18116-4-william-tw.lin@mediatek.com> <3e7bc476-ffc7-fb07-8e64-246427da736c@linaro.org> <9acc8d99-e3db-3df8-4051-21d95450b28d@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9acc8d99-e3db-3df8-4051-21d95450b28d@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230918_124750_999165_66C0CBFE X-CRM114-Status: GOOD ( 30.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 18, 2023 at 10:47:53AM +0200, AngeloGioacchino Del Regno wrote: > Il 17/09/23 10:26, Krzysztof Kozlowski ha scritto: > > On 15/09/2023 17:26, William-tw Lin wrote: > > > dt-binding documentation for mtk-socinfo driver. > > > > Here and in subject, drop driver and instead descrbe hardware. > > > > > mtk-socinfo driver provides SoC-related information. > > > Such information includes manufacturer information, SoC name, > > > SoC segment name, and SoC marketing name. > > > > > > Signed-off-by: William-tw Lin > > > --- > > > .../bindings/hwinfo/mtk-socinfo.yaml | 48 +++++++++++++++++++ > > > 1 file changed, 48 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/hwinfo/mtk-socinfo.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/hwinfo/mtk-socinfo.yaml b/Documentation/devicetree/bindings/hwinfo/mtk-socinfo.yaml > > > new file mode 100644 > > > index 000000000000..74f03f1dc404 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/hwinfo/mtk-socinfo.yaml > > > > Nothing improved. > > > > This is a friendly reminder during the review process. > > > > It seems my previous comments were not fully addressed. Maybe my > > feedback got lost between the quotes, maybe you just forgot to apply it. > > Please go back to the previous discussion and either implement all > > requested changes or keep discussing them. > > > > Thank you. > > > > > @@ -0,0 +1,48 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/hwinfo/mtk-socinfo.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: MediaTek SoC ChipID > > > + > > > +maintainers: > > > + - William Lin > > > + - Matthias Brugger > > > + - Kevin Hilman > > > + - AngeloGioacchino Del Regno > > > + > > > +description: > > > + MediaTek SoCs store various product information in eFuses, including > > > + Chip ID and Revision fields, usable to identify the manufacturer, > > > + SoC version, plus segment and marketing names. > > > + > > > +properties: > > > + compatible: > > > + const: mediatek,socinfo > > > > What happened to compatibles? No, this is just wrong and no explained. > > You ignored other comments as well. Really, that's not the way to go. > > > > Practically, having different compatibles for each SoC is not needed, as > the only thing that changes between SoCs is the eFuse(s) that you read to > get the information - and that's all. > > So ... we either use this driver with devicetree, giving it the right eFuses > to read from, or we duplicate the mtk-efuse driver, or we statically assign > the eFuses in the driver itself and we set compatibles like > "mediatek,mt8195-socinfo" to select that... ideas? So this one is just a virtual device to instantiate a driver and there is no socinfo hw block? If so, that's definitely a NAK. Either instantiate your socinfo driver from the efuse driver or register as a socinfo provider in it. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel