From: Greg KH <gregkh@linuxfoundation.org>
To: Zhang Shurong <zhang_shurong@foxmail.com>
Cc: patrice.chotard@st.com, jslaby@suse.com,
linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] serial: st-asc: Fix to check return value of platform_get_irq() in asc_init_port()
Date: Mon, 18 Sep 2023 09:55:56 +0200 [thread overview]
Message-ID: <2023091849-chill-haziness-1a35@gregkh> (raw)
In-Reply-To: <tencent_7E9B9A5A97AD3B30550F1A8553D44F09C607@qq.com>
On Sat, Aug 26, 2023 at 03:54:59PM +0800, Zhang Shurong wrote:
> The platform_get_irq might be failed and return a negative result. So
> there should have an error handling code.
>
> Fixed this by adding an error handling code.
>
> Fixes: c4b058560762 ("serial:st-asc: Add ST ASC driver.")
> Signed-off-by: Zhang Shurong <zhang_shurong@foxmail.com>
> ---
> v1->v2: generated patch based on tty-next tree.
>
> drivers/tty/serial/st-asc.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
> index e7048515a79c..3d60ab6e9581 100644
> --- a/drivers/tty/serial/st-asc.c
> +++ b/drivers/tty/serial/st-asc.c
> @@ -723,9 +723,13 @@ static int asc_init_port(struct asc_port *ascport,
> port->ops = &asc_uart_ops;
> port->fifosize = ASC_FIFO_SIZE;
> port->dev = &pdev->dev;
> - port->irq = platform_get_irq(pdev, 0);
> port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_ST_ASC_CONSOLE);
>
> + ret = platform_get_irq(pdev, 0);
> + if (ret < 0)
> + return ret;
> + port->irq = ret;
> +
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> port->membase = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(port->membase))
> --
> 2.30.2
>
Does not apply to 6.6-rc2 :(
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-09-18 7:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-26 7:54 [PATCH v2] serial: st-asc: Fix to check return value of platform_get_irq() in asc_init_port() Zhang Shurong
2023-09-18 7:55 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023091849-chill-haziness-1a35@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=patrice.chotard@st.com \
--cc=zhang_shurong@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).