From: Sudeep Holla <sudeep.holla@arm.com>
To: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Sudeep Holla <sudeep.holla@arm.com>,
Jens Wiklander <jens.wiklander@linaro.org>,
Marc Bonnici <marc.bonnici@arm.com>,
Coboy Chen <coboy.chen@mediatek.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Olivier Deprez <olivier.deprez@arm.com>
Subject: [PATCH RFT v2 12/18] firmware: arm_ffa: Add notification handling mechanism
Date: Tue, 19 Sep 2023 18:41:00 +0100 [thread overview]
Message-ID: <20230919-ffa_v1-1_notif-v2-12-6f3a3ca3923c@arm.com> (raw)
In-Reply-To: <20230919-ffa_v1-1_notif-v2-0-6f3a3ca3923c@arm.com>
With all the necessary plumbing in place, let us add handling the
notifications as part of schedule receiver interrupt handler. In order
to do so, we need to just register scheduling callback on behalf of the
driver partition.
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
drivers/firmware/arm_ffa/driver.c | 62 ++++++++++++++++++++++++++++++++++++++-
1 file changed, 61 insertions(+), 1 deletion(-)
diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c
index b95c7979da8d..8a5b5c274bb9 100644
--- a/drivers/firmware/arm_ffa/driver.c
+++ b/drivers/firmware/arm_ffa/driver.c
@@ -103,6 +103,7 @@ struct ffa_drv_info {
unsigned int cpuhp_state;
struct ffa_pcpu_irq __percpu *irq_pcpu;
struct workqueue_struct *notif_pcpu_wq;
+ struct work_struct notif_pcpu_work;
struct work_struct irq_work;
bool info_get_64b;
struct xarray partition_info;
@@ -1045,6 +1046,55 @@ static int ffa_notify_send(struct ffa_device *dev, int notify_id,
BIT(notify_id));
}
+static void handle_notif_callbacks(u64 bitmap, u16 part_id)
+{
+ int notify_id;
+ struct notifier_cb_info *cb_info = NULL;
+
+ for (notify_id = 0; notify_id <= FFA_MAX_NOTIFICATIONS && bitmap;
+ notify_id++, bitmap >>= 1) {
+ if (!(bitmap & 1))
+ continue;
+
+ mutex_lock(&drv_info->notify_lock);
+ cb_info = notifier_hash_node_get(part_id, notify_id);
+ mutex_unlock(&drv_info->notify_lock);
+
+ if (cb_info && cb_info->cb)
+ cb_info->cb(notify_id, cb_info->cb_data);
+ }
+}
+
+static void notif_pcpu_irq_work_fn(struct work_struct *work)
+{
+ int rc;
+ struct ffa_notify_bitmaps bitmaps;
+ struct ffa_drv_info *info = container_of(work, struct ffa_drv_info,
+ notif_pcpu_work);
+
+ rc = ffa_notification_get(ALL_NOTIFICATION_BITMAPS_FLAGS, &bitmaps);
+ if (rc) {
+ pr_err("Failed to retrieve notifications with %d!\n", rc);
+ return;
+ }
+
+ handle_notif_callbacks(bitmaps.vm_map, info->vm_id);
+ handle_notif_callbacks(bitmaps.sp_map, info->vm_id);
+ handle_notif_callbacks(bitmaps.arch_map, info->vm_id);
+}
+
+static void
+ffa_self_notif_handle(u16 vcpu, bool is_per_vcpu, void *cb_data)
+{
+ struct ffa_drv_info *info = cb_data;
+
+ if (!is_per_vcpu)
+ notif_pcpu_irq_work_fn(&info->notif_pcpu_work);
+ else
+ queue_work_on(vcpu, info->notif_pcpu_wq,
+ &info->notif_pcpu_work);
+}
+
static const struct ffa_info_ops ffa_drv_info_ops = {
.api_version_get = ffa_api_version_get,
.partition_info_get = ffa_partition_info_get,
@@ -1149,6 +1199,13 @@ static void ffa_setup_partitions(void)
drv_info->partition_count = count;
kfree(pbuf);
+
+ /* Allocate for the host */
+ info = kzalloc(sizeof(*info), GFP_KERNEL);
+ if (!info)
+ return;
+ xa_store(&drv_info->partition_info, drv_info->vm_id, info, GFP_KERNEL);
+ drv_info->partition_count++;
}
static void ffa_partitions_cleanup(void)
@@ -1292,6 +1349,7 @@ static int ffa_init_pcpu_irq(unsigned int irq)
}
INIT_WORK(&drv_info->irq_work, ffa_sched_recv_irq_work_fn);
+ INIT_WORK(&drv_info->notif_pcpu_work, notif_pcpu_irq_work_fn);
drv_info->notif_pcpu_wq = create_workqueue("ffa_pcpu_irq_notification");
if (!drv_info->notif_pcpu_wq)
return -EINVAL;
@@ -1349,7 +1407,9 @@ static int ffa_notifications_setup(void)
hash_init(drv_info->notifier_hash);
mutex_init(&drv_info->notify_lock);
- return 0;
+ /* Register internal scheduling callback */
+ return ffa_sched_recv_cb_update(drv_info->vm_id,
+ ffa_self_notif_handle, drv_info, true);
cleanup:
ffa_notifications_cleanup();
return ret;
--
2.42.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-19 17:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 17:40 [PATCH RFT v2 00/18] firmware: arm_ffa: Add FF-A v1.1 support(notification + new memory descriptor format) Sudeep Holla
2023-09-19 17:40 ` [PATCH RFT v2 01/18] firmware: arm_ffa: Update the FF-A command list with v1.1 additions Sudeep Holla
2023-09-19 17:40 ` [PATCH RFT v2 02/18] firmware: arm_ffa: Implement notification bitmap create and destroy interfaces Sudeep Holla
2023-09-19 17:40 ` [PATCH RFT v2 03/18] firmware: arm_ffa: Implement the notification bind and unbind interface Sudeep Holla
2023-09-19 17:40 ` [PATCH RFT v2 04/18] firmware: arm_ffa: Implement the FFA_RUN interface Sudeep Holla
2023-09-19 17:40 ` [PATCH RFT v2 05/18] firmware: arm_ffa: Implement the FFA_NOTIFICATION_SET interface Sudeep Holla
2023-09-19 17:40 ` [PATCH RFT v2 06/18] firmware: arm_ffa: Implement the FFA_NOTIFICATION_GET interface Sudeep Holla
2023-09-19 17:40 ` [PATCH RFT v2 07/18] firmware: arm_ffa: Implement the NOTIFICATION_INFO_GET interface Sudeep Holla
2023-09-19 17:40 ` [PATCH RFT v2 08/18] firmware: arm_ffa: Initial support for scheduler receiver interrupt Sudeep Holla
2023-09-19 17:40 ` [PATCH RFT v2 09/18] firmware: arm_ffa: Add schedule receiver callback mechanism Sudeep Holla
2023-09-19 17:40 ` [PATCH RFT v2 10/18] firmware: arm_ffa: Add interfaces to request notification callbacks Sudeep Holla
2023-09-19 17:40 ` [PATCH RFT v2 11/18] firmware: arm_ffa: Add interface to send a notification to a given partition Sudeep Holla
2023-09-19 17:41 ` Sudeep Holla [this message]
2023-09-19 17:41 ` [PATCH RFT v2 13/18] firmware: arm_ffa: Don't set the memory region attributes for MEM_LEND Sudeep Holla
2023-09-19 17:41 ` [PATCH RFT v2 14/18] firmware: arm_ffa: Simplify the computation of transmit and fragment length Sudeep Holla
2023-09-19 17:41 ` [PATCH RFT v2 15/18] KVM: arm64: FFA: Remove access of endpoint memory access descriptor array Sudeep Holla
2023-09-19 17:41 ` [PATCH RFT v2 16/18] firmware: arm_ffa: Switch to using ffa_mem_desc_offset() accessor Sudeep Holla
2023-09-19 17:41 ` [PATCH RFT v2 17/18] firmware: arm_ffa: Update memory descriptor to support v1.1 format Sudeep Holla
2023-09-19 17:41 ` [PATCH RFT v2 18/18] firmware: arm_ffa: Upgrade the driver version to v1.1 Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230919-ffa_v1-1_notif-v2-12-6f3a3ca3923c@arm.com \
--to=sudeep.holla@arm.com \
--cc=coboy.chen@mediatek.com \
--cc=jens.wiklander@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=marc.bonnici@arm.com \
--cc=olivier.deprez@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).