From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B88D2CD5BA9 for ; Tue, 19 Sep 2023 12:26:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WfkbtW+iMbSWlbYG+ign6nc7nteuLwx49MYbSIUqWBU=; b=yws4RJH/LaxGZZ p6ay6SNjzQvpbuuNBwT8FSndFUftqEHC+nxCokQrBNi4MtdUGcyuECHdlAabAkruY8/MArnUJnWC1 NWEabCZ44ifHesllNR+L7sdbQ6d6N0rmik/NhAgVW9q8nVnfl+4fby2b3gWIGOKb55KRrJAt7KK7m hOi89jibYsA900kjPbC7aNxs4RcjSQdsQUcDkBC48Jf68ZCl+dtAn17lT2kY3snhDnrqReicJxMUJ lAj3eV3X0tekif8BKGrgLrWqPsRBDGxOTHRyIL7n68t6267dMBlBSWNZYqmwrpSstfrqc9ur8uZ0h pq7oh3ffLFQf7Rm6I2Vg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qiZny-000PXY-2A; Tue, 19 Sep 2023 12:26:14 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qiZnw-000PX4-12 for linux-arm-kernel@lists.infradead.org; Tue, 19 Sep 2023 12:26:13 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DD17AB8114B; Tue, 19 Sep 2023 12:26:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF915C433C9; Tue, 19 Sep 2023 12:26:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695126369; bh=OnEUCFS4cHitzCR7uggS8zW5KMJ/VY7vW2pRNgs+7/I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qyft4lyhCZ4WkH52m3Qm5Bkbe4FtSGuSCsac20JrU7kx8jLTyzoVUIrVOuVkJdIDa cbUr+xEIFMSFuVr1MbvdHNi6JKyPPYy8bNDGhD5meCRgpdDhRVEg5d22dxg99TGT3j shllbp1BKquJ+s+ckpk6Z7y60fNu2gu3w1qiKNq5t/H5NGsvsw7yuxzVL6t4WL3tff BLGfQQgj3wc1xyHFh52T834bXfCjx2Yw4NUXonQO8h3rFSlgDWY2iDJDHWkyheYIB3 Ixbgc46ehRzQDoK5v5nFq7UiT70JeQsCOYn+oLZokSBUg+ppyRLAFEVYGDWvliRyOK cjiV3w0xJ2B5A== Date: Tue, 19 Sep 2023 14:26:03 +0200 From: Shawn Guo To: Ming Qian Cc: mirela.rabulea@oss.nxp.com, robh+dt@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, linux-imx@nxp.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: imx8-ss-img: Assign slot for imx jpeg encoder/decoder Message-ID: <20230919122602.GC11740@T480> References: <20230601023801.25229-1-ming.qian@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230601023801.25229-1-ming.qian@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230919_052612_676077_073B859A X-CRM114-Status: GOOD ( 18.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 01, 2023 at 10:38:01AM +0800, Ming Qian wrote: > assign a single slot, > configure interrupt and power domain only for 1 slot, > not for the all 4 slots. > > Signed-off-by: Ming Qian > --- > .../arm64/boot/dts/freescale/imx8-ss-img.dtsi | 22 +++++-------------- > 1 file changed, 6 insertions(+), 16 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi > index a90654155a88..176dcce24b64 100644 > --- a/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi > @@ -18,10 +18,7 @@ img_ipg_clk: clock-img-ipg { > > jpegdec: jpegdec@58400000 { > reg = <0x58400000 0x00050000>; > - interrupts = , > - , > - , > - ; > + interrupts = ; > clocks = <&img_jpeg_dec_lpcg IMX_LPCG_CLK_0>, > <&img_jpeg_dec_lpcg IMX_LPCG_CLK_4>; > clock-names = "per", "ipg"; > @@ -29,18 +26,13 @@ jpegdec: jpegdec@58400000 { > <&img_jpeg_dec_lpcg IMX_LPCG_CLK_4>; > assigned-clock-rates = <200000000>, <200000000>; > power-domains = <&pd IMX_SC_R_MJPEG_DEC_MP>, > - <&pd IMX_SC_R_MJPEG_DEC_S0>, > - <&pd IMX_SC_R_MJPEG_DEC_S1>, > - <&pd IMX_SC_R_MJPEG_DEC_S2>, > - <&pd IMX_SC_R_MJPEG_DEC_S3>; > + <&pd IMX_SC_R_MJPEG_DEC_S0>; > + slot = <0>; I do not find this 'slot' property in bindings doc. Shawn > }; > > jpegenc: jpegenc@58450000 { > reg = <0x58450000 0x00050000>; > - interrupts = , > - , > - , > - ; > + interrupts = ; > clocks = <&img_jpeg_enc_lpcg IMX_LPCG_CLK_0>, > <&img_jpeg_enc_lpcg IMX_LPCG_CLK_4>; > clock-names = "per", "ipg"; > @@ -48,10 +40,8 @@ jpegenc: jpegenc@58450000 { > <&img_jpeg_enc_lpcg IMX_LPCG_CLK_4>; > assigned-clock-rates = <200000000>, <200000000>; > power-domains = <&pd IMX_SC_R_MJPEG_ENC_MP>, > - <&pd IMX_SC_R_MJPEG_ENC_S0>, > - <&pd IMX_SC_R_MJPEG_ENC_S1>, > - <&pd IMX_SC_R_MJPEG_ENC_S2>, > - <&pd IMX_SC_R_MJPEG_ENC_S3>; > + <&pd IMX_SC_R_MJPEG_ENC_S0>; > + slot = <0>; > }; > > img_jpeg_dec_lpcg: clock-controller@585d0000 { > -- > 2.38.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel