From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Conor Dooley <conor+dt@kernel.org>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-stm32@st-md-mailman.stormreply.com,
Maxime Coquelin <mcoquelin.stm32@gmail.com>
Subject: Re: [PATCH] ARM: dts: stm32: omit unused pinctrl groups from dtb files
Date: Wed, 20 Sep 2023 14:29:16 +0200 [thread overview]
Message-ID: <20230920122916.GV637806@pengutronix.de> (raw)
In-Reply-To: <33956b8b-465f-3a99-0331-7ed784c502f3@pengutronix.de>
On Wed, Sep 20, 2023 at 02:15:24PM +0200, Ahmad Fatoum wrote:
> Hello Sascha,
>
> On 20.09.23 14:11, Sascha Hauer wrote:
> > stm32mp15-pinctrl.dtsi contains nearly all pinctrl groups collected from
> > all boards. Most of them end up unused by a board and only waste binary
> > space. Add /omit-if-no-ref/ to the groups to scrub the unused groups
> > from the dtbs.
> >
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> > arch/arm/boot/dts/st/stm32mp15-pinctrl.dtsi | 228 ++++++++++++++++++++
> > 1 file changed, 228 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/st/stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/st/stm32mp15-pinctrl.dtsi
> > index e1df345801dc2..778a83471df4c 100644
> > --- a/arch/arm/boot/dts/st/stm32mp15-pinctrl.dtsi
> > +++ b/arch/arm/boot/dts/st/stm32mp15-pinctrl.dtsi
> > @@ -7,6 +7,7 @@
> >
> > &pinctrl {
> > adc1_ain_pins_a: adc1-ain-0 {
> > + /omit-if-no-ref/
>
> I think the correct place is above the node name that would be referenced,
> i.e. before adc1_ain_pins_a: adc1-ain-0 here.
Argh! You are right. I'll send a v2 once my fingers are no longer
bleeding.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-09-20 12:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 12:11 [PATCH] ARM: dts: stm32: omit unused pinctrl groups from dtb files Sascha Hauer
2023-09-20 12:15 ` Ahmad Fatoum
2023-09-20 12:29 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230920122916.GV637806@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=alexandre.torgue@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).