From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9BF4E7106D for ; Thu, 21 Sep 2023 13:30:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kbT5rgVXrdAoAQRJAAmAm+b7wRkCJ5+qeIZPfxmx6zA=; b=kVMAfh86cPz0XE bgwPH9sfp+DFSLSXAZOls0JH85m4lWcexosspKbZ+aX7aD0l629KHjEX6VtOg75ofOTVly117hohE 0sinNGpLVikCv97sEKrVjNjtRwOjQzjcTqVPgwXyFI2Saqjh0W1wKlc3P3DvO/vkoEFZAskXXDPeD L1QlX9kJUfjEGZW5mPjxuUxCWKOUbLbI2xAer5MAnUVISoK4j2ayc6nzS5LkYucMVb5Rji1K624P9 CzH4i2MUHCiGeATD/m3Wgw/QCnhua20M0f9Ai5ZO+IY36ot6TocNB5ef2hUvdqFA/9Nw7U6l2NJh8 WGqcEDjQqDdl6d8W3bLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qjJkU-0068Kc-0b; Thu, 21 Sep 2023 13:29:42 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qjJkR-0068Ji-0N for linux-arm-kernel@lists.infradead.org; Thu, 21 Sep 2023 13:29:41 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AA9CB1684; Thu, 21 Sep 2023 06:30:08 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1A7133F5A1; Thu, 21 Sep 2023 06:29:29 -0700 (PDT) Date: Thu, 21 Sep 2023 14:29:27 +0100 From: Sudeep Holla To: Ulf Hansson Cc: Cristian Marussi , Viresh Kumar , Nishanth Menon , Stephen Boyd , Nikunj Kela , Prasad Sodagudi , Alexandre Torgue , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 07/13] cpufreq: scmi: Drop redundant ifdef in scmi_cpufreq_probe() Message-ID: <20230921132927.ca6qoewimwn2xzh5@bogus> References: <20230825112633.236607-1-ulf.hansson@linaro.org> <20230825112633.236607-8-ulf.hansson@linaro.org> <20230921111426.b2vp5hu7ssdtmz3n@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230921_062939_263357_0FCF682B X-CRM114-Status: GOOD ( 19.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 21, 2023 at 03:02:16PM +0200, Ulf Hansson wrote: > On Thu, 21 Sept 2023 at 13:14, Sudeep Holla wrote: > > > > On Fri, Aug 25, 2023 at 01:26:27PM +0200, Ulf Hansson wrote: > > > We have stubs for devm_of_clk_add_hw_provider(), so there should be no need > > > to protect this with the '#ifdef CONFIG_COMMON_CLK'. Let's drop it to clean > > > up the code a bit. > > > > > > > No exactly. The stub is under !CONFIG_OF but we need it for !CONFIG_COMMON_CLK. > > The original build issue reported for which I add this was CONFIG_OF=y && > > CONFIG_COMMON_CLK=n. > > > > It looks like it is still valid combo though I don't have a handy randconfig > > to present to you. I prefer to drop this for now if that is OK with you. > > Sure, it's perfectly fine to drop it. It's just a thing I stumbled > over that isn't really needed in the $subject series! > Thanks ! -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel