From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BB2BE6FE58 for ; Fri, 22 Sep 2023 15:47:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NO1leIg4YnHTuk/IOwCGvXw1SENOAuMNn5t2ULSy/No=; b=NijPKjXf/Ly5UfG1wwsinL5TtB FlaCE1JFukEOTe5qLpeLzGhh9T7BlrVKBGa9W4NSPXa5uzLKiTAvycB0FrS6m/de9u6TwLtXYh/r2 hmB0x+qfZTMgW1Y2lP24R3ZnRVl2mMahhyBXNjPXoK2p72Bicbq5IW/DgkcOuRkpOQb1DMnnK4BqM 996Q9e7TVVzIUh7VL0iKqRB/lLGMfjtsQOafyfAZiVJUH1ROyGJzUKc459bvwiphELLwnTPQtk4Gl j4smAUb2CQrS2Pzfr/K5dM88F5ISw5Ulv3/MTXqPg1G2zghpkpVTyX8i5QNBpaJAx4oRdaLxtMU5/ jI8N+LjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qjiMv-009L3n-19; Fri, 22 Sep 2023 15:47:01 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qjiMr-009L2a-27; Fri, 22 Sep 2023 15:46:59 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 8AEB3CE23EB; Fri, 22 Sep 2023 15:46:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A3DBC433C7; Fri, 22 Sep 2023 15:46:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695397614; bh=MYb97kHVKXhuo3uqkZLINHlkPs+cMUfvW87Cog3BtqA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p1PvUvqHW9+CI4FtQ6dGHCku/bWa1qyERooyTKqO59o1ZwMvYAED2oCnmaZ0eIxaL i79wQiVZWvjq8fA6wKvMnGY6mh0v4VycoH17zCQeLVfay3LedISlD930pRIlJKbeHB HDvkNOHvPD44rgLwEurMpj3I47P/MDXSLnXjEbGeuA72Iid7JBU7osk3VLtavk8gIU 6cHPHwg6LqEzIewtQV0hf+rxSS4uNUQf05LcBORAoJdpMrTj304nX+EP8E/jZ0lPeu vn1ztEqC8Ex496xjME12m8O+ZVcvAdISpfNMma8UpwHMceztLJqhCpLEC5dWJSeiBo LQV32PthGxEzQ== Date: Fri, 22 Sep 2023 16:46:48 +0100 From: Conor Dooley To: Moudy Ho Cc: Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mauro Carvalho Chehab , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 05/16] dt-bindings: media: mediatek: mdp3: add support MT8195 RDMA Message-ID: <20230922-squealing-tipoff-e2fc6117ba7e@spud> References: <20230922072116.11009-1-moudy.ho@mediatek.com> <20230922072116.11009-6-moudy.ho@mediatek.com> MIME-Version: 1.0 In-Reply-To: <20230922072116.11009-6-moudy.ho@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230922_084658_040716_19FBFE92 X-CRM114-Status: GOOD ( 22.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2423006264117542162==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2423006264117542162== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TinQJ3EeZSdfbVkx" Content-Disposition: inline --TinQJ3EeZSdfbVkx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 22, 2023 at 03:21:05PM +0800, Moudy Ho wrote: > Support for MT8195 RDMA has been added, allowing for > the configuration of multiple MDP3 pipes. > Furthermore, this particular device does not require > sharing SRAM with RSZ. I'm sorry if I am going over past arguments, if this is 90% the same as the 8193 rdma, why the extraction + mostly duplicate file, rather than covering whatever clocks/mboxes differences with an if/then/else in a single file? Thanks, Conor. >=20 > Signed-off-by: Moudy Ho > --- > .../media/mediatek,mdp3-rdma-8195.yaml | 64 +++++++++++++++++++ > 1 file changed, 64 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3= -rdma-8195.yaml >=20 > diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma-8= 195.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma-8195.= yaml > new file mode 100644 > index 000000000000..f10139aec3c5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma-8195.yaml > @@ -0,0 +1,64 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/mediatek,mdp3-rdma-8195.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek MT8195 Read Direct Memory Access > + > +maintainers: > + - Matthias Brugger > + - Moudy Ho > + > +description: | > + MediaTek Read Direct Memory Access(RDMA) component used to do read DMA. > + This type of component is configured when there are multiple MDP3 pipe= lines > + that belong to different MMSYS subsystems. > + It contains one line buffer to store the sufficient pixel data, and > + must be siblings to the central MMSYS_CONFIG node. > + For a description of the MMSYS_CONFIG binding, see > + Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml > + for details. > + > +allOf: > + - $ref: mediatek,mdp3-rdma-common.yaml# > + > +properties: > + compatible: > + items: > + - const: mediatek,mt8195-mdp3-rdma > + > + clocks: > + maxItems: 1 > + > + mboxes: > + maxItems: 5 > + > +required: > + - compatible > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + #include > + > + dma-controller@14001000 { > + compatible =3D "mediatek,mt8195-mdp3-rdma"; > + reg =3D <0x14001000 0x1000>; > + mediatek,gce-client-reg =3D <&gce1 SUBSYS_1400XXXX 0x1000 0x1000= >; > + mediatek,gce-events =3D , > + ; > + power-domains =3D <&spm MT8195_POWER_DOMAIN_VPPSYS0>; > + iommus =3D <&iommu_vpp M4U_PORT_L4_MDP_RDMA>; > + clocks =3D <&vppsys0 CLK_VPP0_MDP_RDMA>; > + mboxes =3D <&gce1 12 CMDQ_THR_PRIO_1>, > + <&gce1 13 CMDQ_THR_PRIO_1>, > + <&gce1 14 CMDQ_THR_PRIO_1>, > + <&gce1 21 CMDQ_THR_PRIO_1>, > + <&gce1 22 CMDQ_THR_PRIO_1>; > + #dma-cells =3D <1>; > + }; > --=20 > 2.18.0 >=20 --TinQJ3EeZSdfbVkx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZQ225wAKCRB4tDGHoIJi 0uErAP0e5QDVnjiad7eoFZa5AYGjnmFnMgdtVRLzSMqVp/nBAAEA5+VrQJizrTYi p0CEoEAVK3R1+JddKhYmfChjMnNFJwM= =y+iv -----END PGP SIGNATURE----- --TinQJ3EeZSdfbVkx-- --===============2423006264117542162== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2423006264117542162==--