From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED1D5CD4F57 for ; Fri, 22 Sep 2023 11:13:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I8eq4B5XDeLjtgbrnWOmuKGChHplwGfOIdKu38OSjXk=; b=3k29qQP8BJW5rX fJXFSmhxHavA0diagm+4ZHQq9svUUmb2zxxy+eOsiYJjdjI21Cc6/QaGo0CVyzxydZPUqYv+iHzfc JzvclenSPo4JzcpdtIvLfb5dTHZiCTSQdtc9THM+MYEdN2md4BZGjZEKHqZ5pdpGm4+YpvkJBfmhf xjE3HWE9ummp/Ck13Dbk+s9L5PczjN7YIgwu2vNbclIa6yAvnTW9pCLsRQvlMklrVqKkU/b96ApJP Yf+N2AUIR8duHBLnXCUDxMKFsQVoyJYGXCKs2oa8Y9ExTWKiu6HkhmHx6H4xck17usB66odQEMScc Ffe6b79UAxhkw++7pfHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qje62-008vVE-2z; Fri, 22 Sep 2023 11:13:18 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qje5v-008vSf-1o for linux-arm-kernel@lists.infradead.org; Fri, 22 Sep 2023 11:13:12 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-4053db20d03so6060515e9.2 for ; Fri, 22 Sep 2023 04:13:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695381189; x=1695985989; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/ijlwZ6JRdK1U0SnHerxGcEJGjK9VRf4PRp/VeOrzMQ=; b=ECSqQ+EUXQf1UM5rObq6y8QdBG56d/6JbvGrYIuqlvpBXPSB3hdO12VF8VpobVR/rt 39U4f4BMAEC3qiO2mOXI9S7/tZ/jmu6WkLITABYE43S4xfOEt6A0941KUNPE+WX2oyHf p3SgEWq0novXg4vgX6HGGz1NXm65aM4AMvfB/jXOIWZduOi9HDHcPrQXwZcqwCzkkG9z k/2hOLeeN45gSlRBXtk74Fs3VGp6cwnPcDpZQMbJOqAbLfV/pPWSSbd3b7UjJI9AgikC sLG/cYkZhK/ULY+d6kltlFFxRRWEQ9h8Go3ESkHCmkqx13qgpNjnrmTLwtbnvJCnc1K4 3djA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695381189; x=1695985989; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/ijlwZ6JRdK1U0SnHerxGcEJGjK9VRf4PRp/VeOrzMQ=; b=VlCeP6+8bpDIi+VmIwYtF1dbsOkxmVOIgao5QIsjCEWcmt1sJ9AZOcRNij0gOYNgZn DTqIQUI1EnmxiqrPVRHg1kgtJYlgxv8akYdxNzGIvb3qexA1f6pQivyYWup+NngYnSBs v/6xpKEXycYwDrHIZv6PkNFcV6L2XaHeM+ThZHsFsu2uDx149MD/MmlfQbF/zNbWFjoA dmb4/Li2/hZNjc8zktOm82QccHYAjOcJnFwKdOtz4iNaz/KBMWAYT4Dgj5POF4HOJ9aR 1+kNxu5UaZiNzfCy0Kw62cs4OXNVnmyNX348MPvKgbMb19EXcQhvUYa5CuXOKy10KoVn uLaA== X-Gm-Message-State: AOJu0YyNyejv4Fktro00xE04dUvb7/hMSbgRHDhXhMmoEgpKzCKQdLg0 93jpQrADel4QfrOnKTmTiOI= X-Google-Smtp-Source: AGHT+IHTzusDD1Vj12nFTAofcTh5ujgUoGMSUjxYvnBVt5FrCDDmYAOQS2TIjfWAp8W6AwxsKaiBCA== X-Received: by 2002:a05:600c:152:b0:403:cc64:2dbf with SMTP id w18-20020a05600c015200b00403cc642dbfmr7548257wmm.27.1695381188563; Fri, 22 Sep 2023 04:13:08 -0700 (PDT) Received: from localhost.localdomain (93-34-89-13.ip49.fastwebnet.it. [93.34.89.13]) by smtp.googlemail.com with ESMTPSA id g10-20020adffc8a000000b003176c6e87b1sm4191765wrr.81.2023.09.22.04.13.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 04:13:07 -0700 (PDT) From: Christian Marangi To: Vincent Whitchurch , Raju Rangoju , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Ping-Ke Shih , Kalle Valo , Simon Horman , Daniel Borkmann , Jiri Pirko , Hangbin Liu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-wireless@vger.kernel.org Cc: Christian Marangi Subject: [net-next PATCH 3/3] net: stmmac: increase TX coalesce timer to 5ms Date: Fri, 22 Sep 2023 13:12:47 +0200 Message-Id: <20230922111247.497-3-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230922111247.497-1-ansuelsmth@gmail.com> References: <20230922111247.497-1-ansuelsmth@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230922_041311_598885_F42F1C59 X-CRM114-Status: GOOD ( 14.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Commit 8fce33317023 ("net: stmmac: Rework coalesce timer and fix multi-queue races") decreased the TX coalesce timer from 40ms to 1ms. This caused some performance regression on some target (regression was reported at least on ipq806x) in the order of 600mbps dropping from gigabit handling to only 200mbps. The problem was identified in the TX timer getting armed too much time. While this was fixed and improved in another commit, performance can be improved even further by increasing the timer delay a bit moving from 1ms to 5ms. The value is a good balance between battery saving by prevending too much interrupt to be generated and permitting good performance for internet oriented devices. Signed-off-by: Christian Marangi --- drivers/net/ethernet/stmicro/stmmac/common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/common.h b/drivers/net/ethernet/stmicro/stmmac/common.h index 403cb397d4d3..2d9f895c2193 100644 --- a/drivers/net/ethernet/stmicro/stmmac/common.h +++ b/drivers/net/ethernet/stmicro/stmmac/common.h @@ -290,7 +290,7 @@ struct stmmac_safety_stats { #define MIN_DMA_RIWT 0x10 #define DEF_DMA_RIWT 0xa0 /* Tx coalesce parameters */ -#define STMMAC_COAL_TX_TIMER 1000 +#define STMMAC_COAL_TX_TIMER 5000 #define STMMAC_MAX_COAL_TX_TICK 100000 #define STMMAC_TX_MAX_FRAMES 256 #define STMMAC_TX_FRAMES 25 -- 2.40.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel