From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9ACE5CD4840 for ; Fri, 22 Sep 2023 16:03:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rnLFIhkshbhk+C5gD7KlRpRM6TzBY1NU39sWVUEoXGM=; b=HSqswcIxGjG5BT bwyFkrPffa5pJInFtO2oQuXfqLL/FUxpoLlh0OpQKXWNkd5e/TGnTBXh8X7iVWTECXsMJHJnfWRhg TsE0ry2E7wKk/BccKt4ua+RfEIKnDjo6xVJNLAtajONiCBBMkNDHkh5XRGGGItD7dOtL23acM45VM cxTYqOqe3jE+7cNCzYlr3CGWP4E50QCy+cFnzJbhLHdsAZoJr27gYMTrl1ss5AQGRcThJvVXz0VEl tZaZhIcowYbl7jw+RzyzFmTQWRIK9apH2UqaxHvUoPzcN/n6I3FOxOrd+/dgfJHmqmvzbUlpU6KiY LmjEnIHBOooSq2YRH3uA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qjicW-009NAL-1n; Fri, 22 Sep 2023 16:03:08 +0000 Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qjicS-009N9I-2k for linux-arm-kernel@lists.infradead.org; Fri, 22 Sep 2023 16:03:06 +0000 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38M9vf5r030685; Fri, 22 Sep 2023 18:02:39 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=selector1; bh=YgwADyaAKP0p1utyzmW0h AzmCYwU7A3xe+e+mBk+eQ0=; b=fO8br+JCSQ5ogq5agBmect4Rxnu8pYZhCAtlV 370cONvJUPRFJ9A5QbsYjhbJ7+EcL4Bke0DM/MBNlIcNe/r84eovPjiHwMNOKCvb w8sRQQGJnJkxEyBBxwsOMAA43RLrKi3JAd76D2mgupogGqSOR2PmYdrQQrRXzmzH cEhVI9pZ/NtdDB6pByJ/s1ngwGRZNMHC8lprNSv8RQrCIBnu9kP/3X3usj3s35UJ augYvfkrjniu08V7qmJgY90hHJV3IkJkkNye2WbG3gwzXgSkqGLM67FgzvUYkpSl 0odtNLbBIpvCYqYC8kMl2GXiwZ7fGqHMEDh1MrugXv6ks2Rgw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3t8tt74730-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Sep 2023 18:02:38 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 3125B100051; Fri, 22 Sep 2023 18:02:37 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 1A4A724C0FA; Fri, 22 Sep 2023 18:02:37 +0200 (CEST) Received: from gnbcxd0016.gnb.st.com (10.129.178.213) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 22 Sep 2023 18:02:36 +0200 Date: Fri, 22 Sep 2023 18:02:27 +0200 From: Alain Volmat To: Laurent Pinchart CC: Hugues Fruchet , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Russell King , Philipp Zabel , Sakari Ailus , Dan Scally , , , , , Subject: Re: [PATCH v3 4/5] ARM: dts: stm32: add dcmipp support to stm32mp135 Message-ID: <20230922160227.GA608616@gnbcxd0016.gnb.st.com> Mail-Followup-To: Laurent Pinchart , Hugues Fruchet , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Russell King , Philipp Zabel , Sakari Ailus , Dan Scally , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230901155732.252436-1-alain.volmat@foss.st.com> <20230901155732.252436-5-alain.volmat@foss.st.com> <20230905090258.GC31594@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230905090258.GC31594@pendragon.ideasonboard.com> X-Disclaimer: ce message est personnel / this message is private X-Originating-IP: [10.129.178.213] X-ClientProxiedBy: EQNCAS1NODE4.st.com (10.75.129.82) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-09-22_14,2023-09-21_01,2023-05-22_02 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230922_090305_203924_FF4A105B X-CRM114-Status: GOOD ( 26.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Laurent, On Tue, Sep 05, 2023 at 12:02:58PM +0300, Laurent Pinchart wrote: > Hi Alain, > > Thank you for the patch. > > On Fri, Sep 01, 2023 at 05:57:23PM +0200, Alain Volmat wrote: > > From: Hugues Fruchet > > > > Add dcmipp support to STM32MP135. > > > > Signed-off-by: Hugues Fruchet > > Signed-off-by: Alain Volmat > > --- > > arch/arm/boot/dts/st/stm32mp135.dtsi | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/arch/arm/boot/dts/st/stm32mp135.dtsi b/arch/arm/boot/dts/st/stm32mp135.dtsi > > index abf2acd37b4e..beee9ec7ed0d 100644 > > --- a/arch/arm/boot/dts/st/stm32mp135.dtsi > > +++ b/arch/arm/boot/dts/st/stm32mp135.dtsi > > @@ -8,5 +8,13 @@ > > > > / { > > soc { > > + dcmipp: dcmipp@5a000000 { > > + compatible = "st,stm32mp13-dcmipp"; > > + reg = <0x5a000000 0x400>; > > + interrupts = ; > > + resets = <&rcc DCMIPP_R>; > > + clocks = <&rcc DCMIPP_K>; > > + status = "disabled"; > > This needs a port, as it's marked as required in the bindings. You can > leave the endpoint out. I first agreed with your comment but, having done the check (make CHECK_DTBS=y ...) this doesn't seem to be required because the dcmipp node is kept disabled within our dtsi. (it is later on only enabled in dts file which as well have the port property). Indeed, to check this I changed it to okay and DTC_CHK complained about missing port property. Hence, I'd think that port doesn't have to be added in this dtsi file. Would you agree with that ? Regards, Alain > > With this fixed, > > Reviewed-by: Laurent Pinchart > > > + }; > > }; > > }; > > -- > Regards, > > Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel