From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9C58CE7A89 for ; Sat, 23 Sep 2023 07:56:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+JFIiNaqTZ95Y/Q7D1w7eYKbupJqjiroOlWKfIi7yrM=; b=ON9V2YFLI8roeY tYZoqjzbSKC1jVNOPYq9BClqp9xqSfpse/ZqxzYW6Y06qhsDQgBN5/01PDwOXkstpFyflHl8LFr1O KTQtPOXBNCT4QfosoJ/s0Bpd89T0YHkWrwmWcYxMrkDU/rG9N1Qw5GYDb5vOkL1E2to++kDxUFNDP /z4sEqIdqT9fN7lIt+kAbGetYkJqyuH8cBXZ6FaudyZ9BHtDmNSxG8p4Hdi283BLJUlFDB8XQe5oz OG/pzbq/mOPHgtoPokT1mv3hySqdKaAki+POcP6Xg4suGhpBm+2Mluwi39HtAI6lsmCYLJV07raLi /QxRLEioPP2nTmzNC4Iw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qjxUy-00AbqX-2g; Sat, 23 Sep 2023 07:56:20 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qjxUw-00Abpp-13 for linux-arm-kernel@lists.infradead.org; Sat, 23 Sep 2023 07:56:19 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id CAF8FB82491; Sat, 23 Sep 2023 07:56:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E146C433C7; Sat, 23 Sep 2023 07:56:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1695455775; bh=LqG3KPeWI7ENhJ299tmnxeWZpLoJ9oK5WScmGb/OaoQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KsEwi/WPhH2PeWr5n3kqJVm61b2bAT6V/rKTA97CCsqNvmhjQGgIXgW5l0Dys5kmG dSN7bG6Ont1BZjdbOo9tyYbTedXAP9LufpoacZBjjVyXFTt8be8rg0idiiej5rAiK4 mfgwaPPOz3epU4y4HTGgvSUA+hzUA8DuCEYXAheE= Date: Sat, 23 Sep 2023 09:56:13 +0200 From: Greg KH To: Nuno Das Neves Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, patches@lists.linux.dev, mikelley@microsoft.com, kys@microsoft.com, wei.liu@kernel.org, haiyangz@microsoft.com, decui@microsoft.com, apais@linux.microsoft.com, Tianyu.Lan@microsoft.com, ssengar@linux.microsoft.com, mukeshrathor@microsoft.com, stanislav.kinsburskiy@gmail.com, jinankjain@linux.microsoft.com, vkuznets@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, will@kernel.org, catalin.marinas@arm.com Subject: Re: [PATCH v3 15/15] Drivers: hv: Add modules to expose /dev/mshv to VMMs running on Hyper-V Message-ID: <2023092318-starter-pointing-9388@gregkh> References: <1695407915-12216-1-git-send-email-nunodasneves@linux.microsoft.com> <1695407915-12216-16-git-send-email-nunodasneves@linux.microsoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1695407915-12216-16-git-send-email-nunodasneves@linux.microsoft.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230923_005618_525589_010FD2CB X-CRM114-Status: UNSURE ( 9.44 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 22, 2023 at 11:38:35AM -0700, Nuno Das Neves wrote: > +static int __init mshv_vtl_init(void) > +{ > + int ret; > + > + tasklet_init(&msg_dpc, mshv_vtl_sint_on_msg_dpc, 0); > + init_waitqueue_head(&fd_wait_queue); > + > + if (mshv_vtl_get_vsm_regs()) { > + pr_emerg("%s: Unable to get VSM capabilities !!\n", __func__); > + BUG(); > + } So you crash the whole kernel if someone loads this module on a non-mshv system? That seems quite excessive and hostile :( Or am I somehow reading this incorrectly? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel