From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89DA2CE7A8A for ; Sun, 24 Sep 2023 03:15:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zG71uDmaUAaO/kWDJEq7gycJG6941miefVRaB9o9YYE=; b=h/SzIhaM6lMtbX IYKn1gB19zrJgdbJWyG+V6JRu6xQYjpq+fL4smdP2SnkkPtkOoclhvQoLI+sMF+iCP3cvZIuV5SUW Q2IR/5/3WccuSMarGZYxyClpQFBy/Ab9pf5Hyu5lUkogisJATrZW8YaOQY96FrAJ3gFCiLAkAbGUj uoqodaiGTXKiGSVXm50Q4pM6zdiIi4ta17bFwmfSsQ7JVW7qT/yJyssD4REFNI6hQTD+JMBCu6eKX c9T3vaOIXXLy37SAhQd/obDnPdwncvAvdu+Qem/wlyxG4Y7ywgg+461P0emv5GRha/TkzsqExTUzQ orB+U8x1kRi25v+zCOMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkFaX-00Bhnw-0p; Sun, 24 Sep 2023 03:15:17 +0000 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkFaU-00BhnM-0n for linux-arm-kernel@lists.infradead.org; Sun, 24 Sep 2023 03:15:15 +0000 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1c0c6d4d650so38576285ad.0 for ; Sat, 23 Sep 2023 20:15:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1695525311; x=1696130111; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=amfWmJu/D4QCQg50FQhzHOc1h7E/bVbjM0QuAI+Q2Gk=; b=OdnUmCqvROMMehjUas1NiLz/2B8BgOiq1PeVOE5iU7nIPmfJyC8TxaVDE24cp46hE3 jKR4/CzMFWxiVHjdMaUjoByghQDfQoS789DE/s5EBlfFlATZ2dCF5JRaP0rwgDylGoW9 OAT5WoRpPnt5+Fh0c6NkmcplLv+4GN4LIaN5M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695525311; x=1696130111; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=amfWmJu/D4QCQg50FQhzHOc1h7E/bVbjM0QuAI+Q2Gk=; b=UTAQS/0pej9UwBK8sa6UxybNhFa6KFzBbZ26sR8z89PJBBPvyANg0L0/u7ii05b1JK JPAPD3jtDZOsiPBctsWYzfpwCtUsD0VSpPGF9P6lKcRyctcwpdO96LLeG+gsr7Sd8sCq P4zm2HO2IKr8lFpOZmC8SKh/NSg71IuVmG+X1QDtq60OL0DCaeZtEp1ppY1lpTfpAYl/ xyJfcI0BRwo+gdALaQOzD6wZyXZzABUSJNczDTN3PULeCknTYHKAmeBMwUiDzn1u88Pl 5R0h5Ju27trbLx0IhGvqqTsrf2nOr5HiknXV+WSmlotwELVh5BjIcyPruK4m3sffJH8o XfYQ== X-Gm-Message-State: AOJu0YxjrUKYPKH9/upjGgmOsius+/xtqsC3uRBkt6WtiCL4nK5NVWcB ulE0YiXJHFI1E1hPQDq7Jd0E7g== X-Google-Smtp-Source: AGHT+IGisq+WD0tay8J8+6P9QCEXyW0JTTlcVZMxuf3DfjOxdjEguwLeM2nc5M2gPZJSS04saXBlow== X-Received: by 2002:a17:903:11c6:b0:1c4:4251:68b3 with SMTP id q6-20020a17090311c600b001c4425168b3mr4201343plh.54.1695525310870; Sat, 23 Sep 2023 20:15:10 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id i18-20020a170902eb5200b001bbdd44bbb6sm700006pli.136.2023.09.23.20.15.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Sep 2023 20:15:10 -0700 (PDT) Date: Sat, 23 Sep 2023 20:15:09 -0700 From: Kees Cook To: Justin Stitt Cc: Jonathan Cameron , Lars-Peter Clausen , Maxime Coquelin , Alexandre Torgue , linux-iio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] iio: adc: stm32-adc: replace deprecated strncpy Message-ID: <202309232006.690F89A@keescook> References: <20230921-strncpy-drivers-iio-adc-stm32-adc-c-v1-1-c50eca098597@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230921-strncpy-drivers-iio-adc-stm32-adc-c-v1-1-c50eca098597@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230923_201514_326291_37A698BA X-CRM114-Status: GOOD ( 23.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 21, 2023 at 04:54:00AM +0000, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > We should prefer more robust and less ambiguous string interfaces. > > We expect adc->chan_name[val] to be NUL-terminated based on ch_name's > use within functions that expect NUL-terminated strings like strncmp and > printf-likes: > | if (!strncmp(stm32_adc_ic[i].name, ch_name, STM32_ADC_CH_SZ)) { > | /* Check internal channel availability */ > | switch (i) { > | case STM32_ADC_INT_CH_VDDCORE: > | if (!adc->cfg->regs->or_vddcore.reg) > | dev_warn(&indio_dev->dev, > | "%s channel not available\n", ch_name); > ... > > There is no evidence that NUL-padding is needed either. Agreed -- it's used as a C string everywhere I can see. > > Considering the above, a suitable replacement is `strscpy` [2] due to > the fact that it guarantees NUL-termination on the destination buffer > without unnecessarily NUL-padding. If, for any reason, NUL-padding _is_ > required we should go for `strscpy_pad`. > > Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] > Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] > Link: https://github.com/KSPP/linux/issues/90 > Cc: linux-hardening@vger.kernel.org > Signed-off-by: Justin Stitt > --- > Note: build-tested > --- > drivers/iio/adc/stm32-adc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/stm32-adc.c b/drivers/iio/adc/stm32-adc.c > index f7613efb870d..9cdcf396d901 100644 > --- a/drivers/iio/adc/stm32-adc.c > +++ b/drivers/iio/adc/stm32-adc.c > @@ -2209,7 +2209,7 @@ static int stm32_adc_generic_chan_init(struct iio_dev *indio_dev, > ret = -EINVAL; > goto err; > } > - strncpy(adc->chan_name[val], name, STM32_ADC_CH_SZ); > + strscpy(adc->chan_name[val], name, STM32_ADC_CH_SZ); I still prefer sizeof($dst), but yes, these are the same: char chan_name[STM32_ADC_CH_MAX][STM32_ADC_CH_SZ]; If this needs a v2, please improve the Subject, but it is technically correct, so: Reviewed-by: Kees Cook :) -Kees -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel