From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03BC0CE7A88 for ; Sun, 24 Sep 2023 12:43:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Gnkbihixhxw9fjOCY9qOUQ2vJV4eeMDUF5F1Lw29X4g=; b=xdDJY0EZkJxxA9 QXe8chSSXV3ynin++mVcsuTzAKpyntAcJYTXXFxBVLLT5KaEuJOXw34IWpwAWU8oKgiFjcnb6su2d MbB9RNH1q/HfWtNWzNac4z4aNNmIkBfxWDLJ3tFkcBvzJ1f8FPGeqk9R78dMyKaE+MAhFsqXoWFTW Qd2A8RVgBUsBuGguL0vbnczfm0DKyiVCN65icSlPTSi5o+v+RIa+zjNsANR6VVzABG8ZvEnwoC8iq bhotloA6x0674k3RVxKP0sQwY4JO64je/rnQwZQbq46wWkru/ZbfSCbWhfGcLZNNzG2L/bDpficqV mSToXX0YEQAKoCVWMpSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkORe-00CGEC-2D; Sun, 24 Sep 2023 12:42:42 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkORb-00CGDc-38 for linux-arm-kernel@lists.infradead.org; Sun, 24 Sep 2023 12:42:41 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1B606CE0AED; Sun, 24 Sep 2023 12:42:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA273C433C8; Sun, 24 Sep 2023 12:42:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695559357; bh=f9QaCT7P+Eym8wOvTxbBRKuAxNofL+bJzAubHNGHt38=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ItdJ5hH5RCJ6d6zgIM5fgBlbKBcGnfLZiplra28IUBfcyypc6M0goS5gFA+Lrc6nr jzqhfMiqooOm5w4gGJk3DmTRMTk8z15JKyhAvJ9h7JO0ZzVt8qOwNiGdxKMW6hrtFo a5tWUZLakstd9aljmPuKFY63a2bFhcZfgCj7Ad96N6qa6s24hxBgxwHn2HeLyTZ6fP X+fmvPta6ILhdaWuTvKKRTmJHhPYssFBl6NGnKSrB7DUjF3mQJ2L5mSTjSrJvGnQ3b zin6fQm/DOfbFnvNLyi/Pg4FXu7dGsEs78XOSGZRwNumv/RUizVqHe6GE9zyQbBb9y o9StdWYawQGxQ== Date: Sun, 24 Sep 2023 20:42:24 +0800 From: Shawn Guo To: Adam Ford Cc: linux-arm-kernel@lists.infradead.org, aford@beaconembedded.com, Lucas Stach , Fabio Estevam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3 1/2] arm64: dts: imx8mp: Fix SDMA2/3 clocks Message-ID: <20230924124224.GC7231@dragon> References: <20230819105002.132750-1-aford173@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230819105002.132750-1-aford173@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230924_054240_190580_22F545DD X-CRM114-Status: GOOD ( 15.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Aug 19, 2023 at 05:50:01AM -0500, Adam Ford wrote: > Commit 16c984524862 ("arm64: dts: imx8mp: don't initialize audio clocks > from CCM node") removed the Audio clocks from the main clock node, because > the intent is to force people to setup the audio PLL clocks per board > instead of having a common set of rates, since not all boards may use > the various audio PLL clocks in the same way. > > Unfortunately, with this parenting removed, the SDMA2 and SDMA3 > clocks were slowed to 24MHz because the SDMA2/3 clocks are controlled > via the audio_blk_ctrl which is clocked from IMX8MP_CLK_AUDIO_ROOT, > and that clock is enabled by pgc_audio. > > Per the TRM, "The SDMA2/3 target frequency is 400MHz IPG and 400MHz > AHB, always 1:1 mode, to make sure there is enough throughput for all > the audio use cases." > > Instead of cluttering the clock node, place the clock rate and parent > information into the pgc_audio node. > > With the parenting and clock rates restored for IMX8MP_CLK_AUDIO_AHB, > and IMX8MP_CLK_AUDIO_AXI_SRC, it appears the SDMA2 and SDMA3 run at > 400MHz again. > > Fixes: 16c984524862 ("arm64: dts: imx8mp: don't initialize audio clocks from CCM node") > Signed-off-by: Adam Ford > Reviewed-by: Lucas Stach > Reviewed-by: Fabio Estevam Applied both, thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel