From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82977CE7A88 for ; Sun, 24 Sep 2023 12:47:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TqL1vHt8ZEmTKhGxEYTx9Sdp1c/nmfy6wwh6RFr3G/4=; b=a0yqptvHFe0py1 cylFIlv92cYotq1ljQT1I0Sp4Rre9R/0sytp5ngnySQgeCqGAY9MaP5EkqKSREoF/UyHSAj8F3scX T93y69Vb3fbzyP2QZJsPr23EypdPQeYFSRRu2XMizrltZHu9uXVIwbRM0V77aND0ykYngk7MbfMVG 9NBSrvbYYNzjyuiz3jNga1ck+L0hvDvrUR03K5qxWBRx4voH+cSsGmHfneGscqVJLk3wmaCDABUjI Jluu0t2j9eU0sOxR0xCvdchHuDZTjvlytHcx8i6+0pirS6YOdvFdLlbbwEXJixmTpgrM1s0A+rA7v n6od56J841/7WaXu6PxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkOVx-00CGRe-02; Sun, 24 Sep 2023 12:47:09 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkOVu-00CGRH-1h for linux-arm-kernel@lists.infradead.org; Sun, 24 Sep 2023 12:47:07 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 1EBF3B80AD6; Sun, 24 Sep 2023 12:47:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BBD85C433C8; Sun, 24 Sep 2023 12:46:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695559624; bh=uYDw7caeln0FE8YZ0R4Znc7FgE+rD8pGLZ2Fc9rKI3U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EHqwBAXiXCUH9ykTbb0MTUF/PMGUmFZBUnid9zNYIU6+jUiHLI4TsroGwPKQPAFJx Fc4kdKrYSW3174uAaC4eA/tPaMd2NnwjVGY2jjyEIDNqB3uAyaoqRDV4PS5wyG/3e4 f2SlyocrDXLZo4ZHAL4gvfQd+9lfvzNtKrcKTPgoRXd63x5JD8GUSCCUY2q6OtiySI bGxJhUuTtslZ22g9IFWf0FimwjUp3hSIo7AEGE05Aa7jbuMK0RmG83110SmUFTRwPZ efy1asMpQQVDS0llyYEQrgkqLysqHVe6LawO8MvjUpDioEBf6MwBj4jiE/+u6pMeun hH+46nlkAQ7NQ== Date: Sun, 24 Sep 2023 20:46:50 +0800 From: Shawn Guo To: Adam Ford Cc: linux-arm-kernel@lists.infradead.org, aford@beaconembedded.com, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Geert Uytterhoeven , Magnus Damm , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH V2] arm64: dts: imx8mp-beacon: Configure 100MHz PCIe Ref Clk Message-ID: <20230924124650.GD7231@dragon> References: <20230813164003.23665-1-aford173@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230813164003.23665-1-aford173@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230924_054706_715032_E60E3BD0 X-CRM114-Status: GOOD ( 17.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Aug 13, 2023 at 11:40:03AM -0500, Adam Ford wrote: > There is a I2C controlled 100MHz Reference clock used by the PCIe > controller. Configure this clock's DIF1 output to be used by > the PCIe. > > Signed-off-by: Adam Ford > --- > V2: Remove the pcie0_refclk clock that the new one replaces. > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts b/arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts > index acd265d8b58e..a8ccde678c33 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts > @@ -23,6 +23,12 @@ chosen { > stdout-path = &uart2; > }; > > + clk_xtal25: clk-xtal25 { clock-xtal25 for the node name? > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <25000000>; > + }; > + > connector { > compatible = "usb-c-connector"; > label = "USB-C"; > @@ -112,12 +118,6 @@ led-3 { > }; > }; > > - pcie0_refclk: clock-pcie { > - compatible = "fixed-clock"; > - #clock-cells = <0>; > - clock-frequency = <100000000>; > - }; > - > reg_audio: regulator-wm8962 { > compatible = "regulator-fixed"; > regulator-name = "3v3_aud"; > @@ -246,6 +246,13 @@ pca6416_3: gpio@20 { > interrupt-controller; > #interrupt-cells = <2>; > }; > + > + pcieclk: clk@68 { clock-generator in the bindings example seems a better node name to me. Shawn > + compatible = "renesas,9fgv0241"; > + reg = <0x68>; > + clocks = <&clk_xtal25>; > + #clock-cells = <1>; > + }; > }; > > &i2c3 { > @@ -372,8 +379,9 @@ &pcie { > }; > > &pcie_phy { > + fsl,clkreq-unsupported; > fsl,refclk-pad-mode = ; > - clocks = <&pcie0_refclk>; > + clocks = <&pcieclk 1>; > clock-names = "ref"; > status = "okay"; > }; > -- > 2.39.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel