From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86899CE7A88 for ; Sun, 24 Sep 2023 09:11:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j9HDqghBbPn8KCgM07z+8cPMyyw/HSEm4+GXIXmS3bI=; b=wP36hfNOpQ3/ou zOjEs3LJYcCjPRvRGEVx4nXiux3lOE75fFCwm+MplEeKIEDiOkQYpKi2EjDaam1hpGVmFCg87IKan YO9dRUYuijDGPAfGj050WLa9sjeLjXdG9Hm4HwNorVvcwykAmyWJ2MBRSWVnzH7+gfpz5CD9MBjxC CoQqhWVFS5K2c/ozFW/zeCq+7c1BE4W7rBcyIqCds0aspFcfbm4s6AygrhoGvgeOkRvxqeBh4trGB ZHaHqSXon/mSCDV5mXhHKqNc3mnBJdHdHSXCbwKi3dchsfeKiOkgp3IPErGAZ17+ft19IMwdBVzil oj6B/Fj9BhQGnIYDDnaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkL8d-00BzzX-1F; Sun, 24 Sep 2023 09:10:51 +0000 Received: from mgamail.intel.com ([192.55.52.120]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkL8Z-00Bzyq-1W for linux-arm-kernel@lists.infradead.org; Sun, 24 Sep 2023 09:10:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695546647; x=1727082647; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=qhGRDGNm74HMENeARfnpLwAzRCmbV4L9fDQ+20U0EQc=; b=ks/VUnWxnAEc9lSQOs4Oguy/dUcM8t+TLLBVHFo6ZMm3lERg88YNyH21 XVEd7tgZ1XmA+7mucfFcXTWl9J1Tl8WpvgHBx78qlt5BuWSUGgM/r+PLK V2U5q36ySm+6rP9W6QI7sN5HD2fbyxmLUyRfU0jSMOoEsexARCwJoVw+L ye9Lrx6tAq5RdBXqqHubhZYXtvp7VCt5TzPAw/zVPigpPCK8VjZkNdwon i72atR3waYzQUbhUncDUKdj76/GmPtVmI7PWR2HKINaZMdQ9T2AT++SHp aV900TDpkB6+4O0K3bTuQSZ9JqoJbKkT+hSQ3Hz1MoZTKZiSmb9Uz7pEk A==; X-IronPort-AV: E=McAfee;i="6600,9927,10842"; a="379959018" X-IronPort-AV: E=Sophos;i="6.03,173,1694761200"; d="scan'208";a="379959018" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2023 02:10:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10842"; a="995048020" X-IronPort-AV: E=Sophos;i="6.03,173,1694761200"; d="scan'208";a="995048020" Received: from lkp-server02.sh.intel.com (HELO 493f6c7fed5d) ([10.239.97.151]) by fmsmga006.fm.intel.com with ESMTP; 24 Sep 2023 02:10:42 -0700 Received: from kbuild by 493f6c7fed5d with local (Exim 4.96) (envelope-from ) id 1qkL8S-0003QP-0R; Sun, 24 Sep 2023 09:10:40 +0000 Date: Sun, 24 Sep 2023 17:09:41 +0800 From: kernel test robot To: liuhaoran , airlied@gmail.com Cc: oe-kbuild-all@lists.linux.dev, liuhaoran , samuel@sholland.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, jernej.skrabec@gmail.com, linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] drm/sun4i: Add error handling in sun4i_layer_init_one() Message-ID: <202309241647.QEGaCh1E-lkp@intel.com> References: <20230924074216.17390-1-liuhaoran14@163.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230924074216.17390-1-liuhaoran14@163.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230924_021047_526631_D90C5D4F X-CRM114-Status: GOOD ( 18.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi liuhaoran, kernel test robot noticed the following build warnings: [auto build test WARNING on sunxi/sunxi/for-next] [also build test WARNING on linus/master v6.6-rc2 next-20230921] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/liuhaoran/drm-sun4i-Add-error-handling-in-sun4i_layer_init_one/20230924-154504 base: https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git sunxi/for-next patch link: https://lore.kernel.org/r/20230924074216.17390-1-liuhaoran14%40163.com patch subject: [PATCH] drm/sun4i: Add error handling in sun4i_layer_init_one() config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230924/202309241647.QEGaCh1E-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230924/202309241647.QEGaCh1E-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202309241647.QEGaCh1E-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/gpu/drm/sun4i/sun4i_layer.c: In function 'sun4i_layer_init_one': >> drivers/gpu/drm/sun4i/sun4i_layer.c:230:35: warning: missing terminating " character 230 | dev_err(drm->dev, "Failed to install alpha property, | ^ drivers/gpu/drm/sun4i/sun4i_layer.c:231:34: warning: missing terminating " character 231 | rc = %d\n", ret); | ^ drivers/gpu/drm/sun4i/sun4i_layer.c:239:35: warning: missing terminating " character 239 | dev_err(drm->dev, "Failed to install zpos property, | ^ drivers/gpu/drm/sun4i/sun4i_layer.c:240:34: warning: missing terminating " character 240 | rc = %d\n", ret); | ^ drivers/gpu/drm/sun4i/sun4i_layer.c:275:2: error: unterminated argument list invoking macro "dev_err" 275 | } | ^ drivers/gpu/drm/sun4i/sun4i_layer.c:230:17: error: 'dev_err' undeclared (first use in this function); did you mean '_dev_err'? 230 | dev_err(drm->dev, "Failed to install alpha property, | ^~~~~~~ | _dev_err drivers/gpu/drm/sun4i/sun4i_layer.c:230:17: note: each undeclared identifier is reported only once for each function it appears in drivers/gpu/drm/sun4i/sun4i_layer.c:230:24: error: expected ';' at end of input 230 | dev_err(drm->dev, "Failed to install alpha property, | ^ | ; ...... drivers/gpu/drm/sun4i/sun4i_layer.c:230:17: error: expected declaration or statement at end of input 230 | dev_err(drm->dev, "Failed to install alpha property, | ^~~~~~~ drivers/gpu/drm/sun4i/sun4i_layer.c:230:17: error: expected declaration or statement at end of input drivers/gpu/drm/sun4i/sun4i_layer.c: At top level: >> drivers/gpu/drm/sun4i/sun4i_layer.c:190:28: warning: 'sun4i_layer_init_one' defined but not used [-Wunused-function] 190 | static struct sun4i_layer *sun4i_layer_init_one(struct drm_device *drm, | ^~~~~~~~~~~~~~~~~~~~ vim +230 drivers/gpu/drm/sun4i/sun4i_layer.c 189 > 190 static struct sun4i_layer *sun4i_layer_init_one(struct drm_device *drm, 191 struct sun4i_backend *backend, 192 enum drm_plane_type type, 193 unsigned int id) 194 { 195 const uint64_t *modifiers = sun4i_layer_modifiers; 196 const uint32_t *formats = sun4i_layer_formats; 197 unsigned int formats_len = ARRAY_SIZE(sun4i_layer_formats); 198 struct sun4i_layer *layer; 199 int ret; 200 201 layer = devm_kzalloc(drm->dev, sizeof(*layer), GFP_KERNEL); 202 if (!layer) 203 return ERR_PTR(-ENOMEM); 204 205 layer->id = id; 206 layer->backend = backend; 207 208 if (IS_ERR_OR_NULL(backend->frontend)) { 209 formats = sun4i_backend_layer_formats; 210 formats_len = ARRAY_SIZE(sun4i_backend_layer_formats); 211 modifiers = NULL; 212 } 213 214 /* possible crtcs are set later */ 215 ret = drm_universal_plane_init(drm, &layer->plane, 0, 216 &sun4i_backend_layer_funcs, 217 formats, formats_len, 218 modifiers, type, NULL); 219 if (ret) { 220 dev_err(drm->dev, "Couldn't initialize layer\n"); 221 return ERR_PTR(ret); 222 } 223 224 drm_plane_helper_add(&layer->plane, 225 &sun4i_backend_layer_helper_funcs); 226 227 ret = drm_plane_create_alpha_property(&layer->plane); 228 229 if (ret) { > 230 dev_err(drm->dev, "Failed to install alpha property, 231 rc = %d\n", ret); 232 return ERR_PTR(ret); 233 } 234 235 ret = drm_plane_create_zpos_property(&layer->plane, layer->id, 0, 236 SUN4I_BACKEND_NUM_LAYERS - 1); 237 238 if (ret) { 239 dev_err(drm->dev, "Failed to install zpos property, 240 rc = %d\n", ret); 241 return ERR_PTR(ret); 242 } 243 244 return layer; 245 } 246 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel