Re: [PATCH V3 2/3] arm64: dts: imx8mp: Add micfil node

Marek Vasut
2023-09-01T21:06:39Z

On 9/1/23 13:06, Adam Ford wrote:
> On Thu, Aug 31, 2023 at 4:53 PM Marek Vasut <marex@denx.de> wrote:
>>
>> On 8/31/23 06:44, Adam Ford wrote:
>>> The i.MX8MP has a micfil controller which is used for interfacing
>>> with a pulse density microphone. Add the node and mark it as
>>> disabled by default.
>>>
>>> Signed-off-by: Adam Ford <aford173@gmail.com>
>>> ---
>>> V3: The AUDIOMIX_PDM_ROOT doesn't exist and the real clock is
>>> called IMX8MP_CLK_AUDIOMIX_PDM_SEL, so swap it out.
>>>
>>> V2: No change
>>>
>>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>>> index 3167706d81e1..341fd0369ce9 100644
>>> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>>> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>>> @@ -1479,6 +1479,27 @@ easrc: easrc@30c90000 {
>>> fsl,asrc-format = <2>;
>>> status = "disabled";
>>> };
>>> +
>>> + micfil: audio-controller@30ca0000 {
>>> + compatible = "fsl,imx8mp-micfil";
>>> + reg = <0x30ca0000 0x10000>;
>>> + #sound-dai-cells = <0>;
>>> + interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
>>> + clocks = <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_PDM_IPG>,
>>> + <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_PDM_SEL>,
>>> + <&clk IMX8MP_AUDIO_PLL1_OUT>,
>>> + <&clk IMX8MP_AUDIO_PLL2_OUT>,
>>> + <&clk IMX8MP_CLK_EXT3>;
>>> + clock-names = "ipg_clk", "ipg_clk_app",
>>> + "pll8k", "pll11k", "clkext3";
>>> + dmas = <&sdma2 24 25 0x80000000>;
>>> + dma-names = "rx";
>>
>> Is dma-names really required if there is only a single DMA channel in DT ?
>
> I would normally agree with you, the DT binding file shows it's
> required, and the driver looks like it's searching for a channel name
> called 'rx'

Maybe something that can be improved both in the driver and bindings ?