From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5ECF8CE7A8B for ; Mon, 25 Sep 2023 01:15:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DBHhM8klGheFMvcDd0OFlpBjpSa6kzGDngV1AGhNdSA=; b=xRf5rPiF2WEUWt GnUFlO7x/mq7AMnSvWKjJ179rM8qXVcCxw3KTBjwVNFC8UCImIkkeUs1QBTCPInscDtZUsPV3TSmp fJm+5UT8GqJjLUJRtPZikaGDWvc8unFRgc1vumC8hXPP9Mju/Ed0ANIMrremaW/skrietAqcdjpKa wWyXVbNmCH2d/dGZwyDk/Ms1/7WWy3YiDeD2SWAhq22O5K5keuQa38W3YoCkAhUNL/6FjqWf95AwD wZYGd3tCmX6heKjuO5VsLr+Ol4Zo2DoyMaVkFyhcjgJwAeuW8ve0SFfC0BAiVgZonyeGykxSr3ZGB N9gSQrrZlEUtNTnIIIow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkaBu-00D4vt-0G; Mon, 25 Sep 2023 01:15:14 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkaBs-00D4vC-14 for linux-arm-kernel@lists.infradead.org; Mon, 25 Sep 2023 01:15:13 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A4AD060E06; Mon, 25 Sep 2023 01:15:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84EDDC433C8; Mon, 25 Sep 2023 01:15:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695604508; bh=OoTH/z7nJRsjocyuzHaS3i7q/qJKfFeyOBG9EcrBcPU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=joo4UVaG71XsA8rVr0xsLwun4AUIm0EYEba5zZDra7qr/cKm69w5yn7TDqm99io0z QATvZbDjvztYeY42GNCDrC06aRplIxVkjKw2PlIpSHvkRvAvy6AplCdJ0EEIOQa+KB TChpvcsJIjOzTHiEMUyDYhVbSeA2kfmK3uPenfzE36qLpO0mIMnCkoirwj9WkaO7qy W0vf9mTkiSmoWkrm4cesEVEjK6MvDfyewmQ5WKRf/dJB2CH3sKqbTU3Dn42KJcVDkS GBBmtO9klvu81t6GgeUtZ0iZT4DpKkefoGkRmjLliYBC1IdwAS+E3YKRBb6G78S3zx rpVojpL8aMydQ== Date: Mon, 25 Sep 2023 09:14:57 +0800 From: Shawn Guo To: Adam Ford Cc: linux-arm-kernel@lists.infradead.org, aford@beaconembedded.com, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] arm64: dts: imx8mm-beacon: Add DMIC support Message-ID: <20230925011457.GE7231@dragon> References: <20230831115128.254226-1-aford173@gmail.com> <20230831115128.254226-2-aford173@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230831115128.254226-2-aford173@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230924_181512_462682_80694FC1 X-CRM114-Status: GOOD ( 15.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 31, 2023 at 06:51:26AM -0500, Adam Ford wrote: > The baseboard has a connector for a pulse density microphone. > This is connected via the micfil interface and uses the DMIC > audio codec with the simple-audio-card. > > Signed-off-by: Adam Ford > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi > index 313e93663d6f..d0dd4c81a557 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi > @@ -6,6 +6,13 @@ > #include > > / { > + > + dmic_codec: dmic-codec { > + compatible = "dmic-codec"; > + num-channels = <1>; > + #sound-dai-cells = <0>; > + }; > + > leds { > compatible = "gpio-leds"; > > @@ -98,6 +105,22 @@ reg_usdhc2_vmmc: regulator-usdhc2 { > enable-active-high; > }; > > + sound-dmic { > + compatible = "simple-audio-card"; > + simple-audio-card,name = "dmic"; > + simple-audio-card,format = "pdm"; > + simple-audio-card,bitclock-master = <&dailink_master>; > + simple-audio-card,frame-master = <&dailink_master>; > + > + dailink_master: simple-audio-card,cpu { > + sound-dai = <&micfil>; > + }; > + > + simple-audio-card,codec { > + sound-dai = <&dmic_codec>; > + }; > + }; > + > sound-wm8962 { > compatible = "simple-audio-card"; > simple-audio-card,name = "wm8962"; > @@ -228,6 +251,16 @@ pca6416_1: gpio@21 { > }; > }; > > +&micfil { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pdm>; > + assigned-clocks = <&clk IMX8MM_CLK_PDM>; > + assigned-clock-parents = <&clk IMX8MM_AUDIO_PLL1_OUT>; > + assigned-clock-rates = <49152000>; > + status = "okay"; We usually end property list with 'status'. Shawn > + #sound-dai-cells = <0>; > +}; > + > &mipi_csi { > status = "okay"; > ports { > @@ -365,6 +398,13 @@ MX8MM_IOMUXC_SAI2_MCLK_GPIO4_IO27 0x19 > >; > }; > > + pinctrl_pdm: pdmgrp { > + fsl,pins = < > + MX8MM_IOMUXC_SAI5_RXC_PDM_CLK 0xd6 > + MX8MM_IOMUXC_SAI5_RXD0_PDM_DATA0 0xd6 > + >; > + }; > + > pinctrl_reg_usb_otg1: usbotg1grp { > fsl,pins = < > MX8MM_IOMUXC_SAI3_RXC_GPIO4_IO29 0x19 > -- > 2.39.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel