public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: imx8x-colibri-iris-v2: Fix pinctrl node names
@ 2023-09-09 12:48 Fabio Estevam
  2023-09-11  9:30 ` Marcel Ziswiler
  2023-09-25  2:03 ` Shawn Guo
  0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2023-09-09 12:48 UTC (permalink / raw)
  To: shawnguo; +Cc: linux-arm-kernel, marcel.ziswiler, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

Per fsl,scu-pinctrl.yaml, the pinctrl node names should end with 'grp'.

Change them to fix the following schema warning:

imx8qxp-colibri-iris-v2.dtb: pinctrl: 'enable_3v3_vmmc', 'lcd-lvds' do not match any of the regexes: 'grp$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/pinctrl/fsl,scu-pinctrl.yaml#

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm64/boot/dts/freescale/imx8x-colibri-iris-v2.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8x-colibri-iris-v2.dtsi b/arch/arm64/boot/dts/freescale/imx8x-colibri-iris-v2.dtsi
index 98202a437040..58ec0b399c4f 100644
--- a/arch/arm64/boot/dts/freescale/imx8x-colibri-iris-v2.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8x-colibri-iris-v2.dtsi
@@ -23,11 +23,11 @@ &iomuxc {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_lvds_converter &pinctrl_gpio_iris>;
 
-	pinctrl_enable_3v3_vmmc: enable_3v3_vmmc {
+	pinctrl_enable_3v3_vmmc: enable-3v3-vmmc-grp {
 		fsl,pins = <IMX8QXP_SAI1_RXFS_LSIO_GPIO0_IO31	0x20>;	/* SODIMM 100 */
 	};
 
-	pinctrl_lvds_converter: lcd-lvds {
+	pinctrl_lvds_converter: lvds-converter-grp {
 		fsl,pins = <IMX8QXP_FLEXCAN1_TX_LSIO_GPIO1_IO18		0x20>,	/* SODIMM  55 */
 			   /* 6B/8B mode. Select LOW - 8B mode (24bit) */
 			   <IMX8QXP_FLEXCAN1_RX_LSIO_GPIO1_IO17		0x20>,	/* SODIMM  63 */
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: imx8x-colibri-iris-v2: Fix pinctrl node names
  2023-09-09 12:48 [PATCH] arm64: dts: imx8x-colibri-iris-v2: Fix pinctrl node names Fabio Estevam
@ 2023-09-11  9:30 ` Marcel Ziswiler
  2023-09-25  2:03 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Marcel Ziswiler @ 2023-09-11  9:30 UTC (permalink / raw)
  To: festevam@gmail.com, shawnguo@kernel.org
  Cc: linux-arm-kernel@lists.infradead.org, festevam@denx.de

Hi Fabio

Thanks!

On Sat, 2023-09-09 at 09:48 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Per fsl,scu-pinctrl.yaml, the pinctrl node names should end with 'grp'.
> 
> Change them to fix the following schema warning:
> 
> imx8qxp-colibri-iris-v2.dtb: pinctrl: 'enable_3v3_vmmc', 'lcd-lvds' do not match any of the regexes: 'grp$',
> 'pinctrl-[0-9]+'
>         from schema $id: http://devicetree.org/schemas/pinctrl/fsl,scu-pinctrl.yaml#
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Reviewed-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

> ---
>  arch/arm64/boot/dts/freescale/imx8x-colibri-iris-v2.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8x-colibri-iris-v2.dtsi b/arch/arm64/boot/dts/freescale/imx8x-
> colibri-iris-v2.dtsi
> index 98202a437040..58ec0b399c4f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8x-colibri-iris-v2.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8x-colibri-iris-v2.dtsi
> @@ -23,11 +23,11 @@ &iomuxc {
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_lvds_converter &pinctrl_gpio_iris>;
>  
> -       pinctrl_enable_3v3_vmmc: enable_3v3_vmmc {
> +       pinctrl_enable_3v3_vmmc: enable-3v3-vmmc-grp {
>                 fsl,pins = <IMX8QXP_SAI1_RXFS_LSIO_GPIO0_IO31   0x20>;  /* SODIMM 100 */
>         };
>  
> -       pinctrl_lvds_converter: lcd-lvds {
> +       pinctrl_lvds_converter: lvds-converter-grp {
>                 fsl,pins = <IMX8QXP_FLEXCAN1_TX_LSIO_GPIO1_IO18         0x20>,  /* SODIMM  55 */
>                            /* 6B/8B mode. Select LOW - 8B mode (24bit) */
>                            <IMX8QXP_FLEXCAN1_RX_LSIO_GPIO1_IO17         0x20>,  /* SODIMM  63 */

Cheers

Marcel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: imx8x-colibri-iris-v2: Fix pinctrl node names
  2023-09-09 12:48 [PATCH] arm64: dts: imx8x-colibri-iris-v2: Fix pinctrl node names Fabio Estevam
  2023-09-11  9:30 ` Marcel Ziswiler
@ 2023-09-25  2:03 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2023-09-25  2:03 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: linux-arm-kernel, marcel.ziswiler, Fabio Estevam

On Sat, Sep 09, 2023 at 09:48:34AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Per fsl,scu-pinctrl.yaml, the pinctrl node names should end with 'grp'.
> 
> Change them to fix the following schema warning:
> 
> imx8qxp-colibri-iris-v2.dtb: pinctrl: 'enable_3v3_vmmc', 'lcd-lvds' do not match any of the regexes: 'grp$', 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/pinctrl/fsl,scu-pinctrl.yaml#
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied, thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-09-25  2:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-09 12:48 [PATCH] arm64: dts: imx8x-colibri-iris-v2: Fix pinctrl node names Fabio Estevam
2023-09-11  9:30 ` Marcel Ziswiler
2023-09-25  2:03 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox