linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: imx6ul-tx6ul: Use preferred i2c-gpios properties
@ 2023-09-12 21:36 Fabio Estevam
  2023-09-12 21:36 ` [PATCH 2/2] ARM: dts: imx51-zii-rdu1: " Fabio Estevam
  2023-09-25  2:33 ` [PATCH 1/2] ARM: dts: imx6ul-tx6ul: " Shawn Guo
  0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2023-09-12 21:36 UTC (permalink / raw)
  To: shawnguo; +Cc: linux-arm-kernel, Fabio Estevam

The 'gpios' property to describe the SDA and SCL GPIOs is considered
deprecated according to i2c-gpio.yaml.

Switch to the preferred 'sda-gpios' and 'scl-gpios' properties.

Thsis fixes the following schema warnings:

imx6ul-tx6ul-0011.dtb: i2c-gpio: 'sda-gpios' is a required property
	from schema $id: http://devicetree.org/schemas/i2c/i2c-gpio.yaml#
imx6ul-tx6ul-0011.dtb: i2c-gpio: 'scl-gpios' is a required property
	from schema $id: http://devicetree.org/schemas/i2c/i2c-gpio.yaml#

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 arch/arm/boot/dts/nxp/imx/imx6ul-tx6ul.dtsi | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul-tx6ul.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ul-tx6ul.dtsi
index 6bd90473050b..1db146ac1c17 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6ul-tx6ul.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6ul-tx6ul.dtsi
@@ -114,10 +114,8 @@ i2c_gpio: i2c-gpio {
 		#size-cells = <0>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_i2c_gpio>;
-		gpios = <
-			&gpio5 1 GPIO_ACTIVE_HIGH /* SDA */
-			&gpio5 0 GPIO_ACTIVE_HIGH /* SCL */
-		>;
+		sda-gpios = <&gpio5 1 GPIO_ACTIVE_HIGH>;
+		scl-gpios = <&gpio5 0 GPIO_ACTIVE_HIGH>;
 		clock-frequency = <400000>;
 		status = "okay";
 
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] ARM: dts: imx51-zii-rdu1: Use preferred i2c-gpios properties
  2023-09-12 21:36 [PATCH 1/2] ARM: dts: imx6ul-tx6ul: Use preferred i2c-gpios properties Fabio Estevam
@ 2023-09-12 21:36 ` Fabio Estevam
  2023-09-25  2:33 ` [PATCH 1/2] ARM: dts: imx6ul-tx6ul: " Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2023-09-12 21:36 UTC (permalink / raw)
  To: shawnguo; +Cc: linux-arm-kernel, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

The 'gpios' property to describe the SDA and SCL GPIOs is considered
deprecated according to i2c-gpio.yaml.

Switch to the preferred 'sda-gpios' and 'scl-gpios' properties.

Thsis fixes the following schema warnings:

imx51-zii-rdu1.dtb: i2c-gpio: 'sda-gpios' is a required property
	from schema $id: http://devicetree.org/schemas/i2c/i2c-gpio.yaml#
imx51-zii-rdu1.dtb: i2c-gpio: 'scl-gpios' is a required property
	from schema $id: http://devicetree.org/schemas/i2c/i2c-gpio.yaml#

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/nxp/imx/imx51-zii-rdu1.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx51-zii-rdu1.dts b/arch/arm/boot/dts/nxp/imx/imx51-zii-rdu1.dts
index 5d4b29d76585..7cd17b43b4b2 100644
--- a/arch/arm/boot/dts/nxp/imx/imx51-zii-rdu1.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx51-zii-rdu1.dts
@@ -119,8 +119,8 @@ i2c_gpio: i2c-gpio {
 		compatible = "i2c-gpio";
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_swi2c>;
-		gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>, /* sda */
-			<&gpio3 4 GPIO_ACTIVE_HIGH>; /* scl */
+		sda-gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>;
+		scl-gpios = <&gpio3 4 GPIO_ACTIVE_HIGH>;
 		i2c-gpio,delay-us = <50>;
 		status = "okay";
 
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] ARM: dts: imx6ul-tx6ul: Use preferred i2c-gpios properties
  2023-09-12 21:36 [PATCH 1/2] ARM: dts: imx6ul-tx6ul: Use preferred i2c-gpios properties Fabio Estevam
  2023-09-12 21:36 ` [PATCH 2/2] ARM: dts: imx51-zii-rdu1: " Fabio Estevam
@ 2023-09-25  2:33 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2023-09-25  2:33 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: linux-arm-kernel

On Tue, Sep 12, 2023 at 06:36:44PM -0300, Fabio Estevam wrote:
> The 'gpios' property to describe the SDA and SCL GPIOs is considered
> deprecated according to i2c-gpio.yaml.
> 
> Switch to the preferred 'sda-gpios' and 'scl-gpios' properties.
> 
> Thsis fixes the following schema warnings:
> 
> imx6ul-tx6ul-0011.dtb: i2c-gpio: 'sda-gpios' is a required property
> 	from schema $id: http://devicetree.org/schemas/i2c/i2c-gpio.yaml#
> imx6ul-tx6ul-0011.dtb: i2c-gpio: 'scl-gpios' is a required property
> 	from schema $id: http://devicetree.org/schemas/i2c/i2c-gpio.yaml#
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Applied both, thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-09-25  2:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-12 21:36 [PATCH 1/2] ARM: dts: imx6ul-tx6ul: Use preferred i2c-gpios properties Fabio Estevam
2023-09-12 21:36 ` [PATCH 2/2] ARM: dts: imx51-zii-rdu1: " Fabio Estevam
2023-09-25  2:33 ` [PATCH 1/2] ARM: dts: imx6ul-tx6ul: " Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).