Re: [PATCH 3/6] dt-bindings: opp: Add compatible for H616

Martin Botka
2023-09-04T19:52:57Z

On Mon, Sep 4 2023 at 09:31:34 PM +02:00:00, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> On 04/09/2023 17:57, Martin Botka wrote:
>> We need to add compatible for H616 to H6 cpufreq driver bindings.
>
> Please describe the hardware, not what is needed for drivers.
Got it. Sorry.
>
>>
>> Also enable opp_supported_hw property that will be needed for H616.
>>
>> Signed-off-by: Martin Botka <martin.botka@somainline.org>
>> ---
>> .../bindings/opp/allwinner,sun50i-h6-operating-points.yaml
>> | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml
>> b/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml
>> index 51f62c3ae194..2fa1199f2d23 100644
>> ---
>> a/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml
>> +++
>> b/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml
>> @@ -23,7 +23,10 @@ allOf:
>>
>> properties:
>> compatible:
>> - const: allwinner,sun50i-h6-operating-points
>> + contains:
>
> This does not look like part of allOf, so contains is no correct here.
> This must be specific, so drop contains.
ack.
>
>> + enum:
>> + - allwinner,sun50i-h6-operating-points
>> + - allwinner,sun50i-h616-operating-points
>>
>> nvmem-cells:
>> description: |
>> @@ -47,6 +50,7 @@ patternProperties:
>> properties:
>> opp-hz: true
>> clock-latency-ns: true
>> + opp-supported-hw: true
>
> Why? It is already allowed. You should rather explain the values.
Yea this can be dropped. I forgot to remove it. My bad.
Also the values i think are very clear ? The values converted to binary
represent which chip revision is allowed to use the specified frequency.
1 bit for each revision.
>
>>
>
> Best regards,
> Krzysztof