Re: [RFC PATCH 27/45] KVM: arm64: smmu-v3: Setup domains and page table configuration

Jean-Philippe Brucker
2023-07-03T10:42:26Z

Hi Mostafa,

On Fri, Jun 23, 2023 at 07:12:05PM +0000, Mostafa Saleh wrote:
> > +static int smmu_detach_dev(struct kvm_hyp_iommu *iommu, pkvm_handle_t domain_id,
> > + struct kvm_hyp_iommu_domain *domain, u32 sid)
> > +{
> > + u64 ttb;
> > + u64 *dst;
> > + int i, ret;
> > + struct hyp_arm_smmu_v3_device *smmu = to_smmu(iommu);
> > +
> > + dst = smmu_get_ste_ptr(smmu, sid);
> > + if (!dst)
> > + return -ENODEV;
> > +
> > + ttb = dst[3] & STRTAB_STE_3_S2TTB_MASK;
> This is unused, does detach needs to do anything with ttb?

No it doesn't look like I've ever used this, I removed it

Thanks,
Jean