Re: [RFC PATCH 05/45] iommu/io-pgtable: Split io_pgtable structure

Jean-Philippe Brucker
2023-02-08T18:02:30Z

Hi Mostafa,

On Tue, Feb 07, 2023 at 12:16:12PM +0000, Mostafa Saleh wrote:
> > +static inline size_t
> > +iopt_unmap_pages(struct io_pgtable *iop, unsigned long iova, size_t pgsize,
> > + size_t pgcount, struct iommu_iotlb_gather *gather)
> > +{
> > + if (!iop->ops || !iop->ops->map_pages)
> Should this be !iop->ops->unmap_pages?

Oh right, good catch!

Sorry about the size of this patch by the way. If we decide to keep this
change I'll reduce it by first introducing these helpers and then
splitting the structure in another patch.

Thanks,
Jean