From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78A65E7D26A for ; Tue, 26 Sep 2023 09:14:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=crM4sBLwMFC5XUAX3VlQ8ukd6Jmfvio300Qs6JWR84Q=; b=Tcb0d8dcVbvgaJ CAS8n6OAWPxjS6gUtEJiK1UqCWXbEAJlS7ArsNuMK6GlRLHoE8VKArte/vcLdHF9hYaV+V4pX8F8r 3uudkesrgx2uZe+dM6u4l5e7piaZFpTYq1RcB9vkA3ihN/kSI8ldpSRppDOqiEyX1ZFpYvLeFBHxS fPNMCBhdV3oj2G9eMGrfdR1nbDwfzpEn5roc4wpv1CVJU+2d2o0Y0aGnHPTeNDqYm5bzmulgQI/xz iWZBXm1cISWtc9mEXN2PdFnHGm1K4Mh4qiImhXhfaSw9CemSZoXj6P7h6iWBlXPYnUTq6IaJU0wvl DwuZFqfPdz45udU5EGAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ql48r-00FwRq-07; Tue, 26 Sep 2023 09:14:05 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ql48n-00FwQx-2Z for linux-arm-kernel@lists.infradead.org; Tue, 26 Sep 2023 09:14:03 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 4E60BB80EC2; Tue, 26 Sep 2023 09:13:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD9E7C433C7; Tue, 26 Sep 2023 09:13:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1695719636; bh=Y+odGCOczssjR27qb7hGuZghKba17wGbQ+Fm6GLNnFU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2gydh655lyZCnI+wjfFSVuoKOwPzdGfBn7ZdmdQYpx9dOzM+V6UQnb/Wba/hWeVdv vTXx3o01rrnH44UQagmltNR/5/c3QvbDKXRVIGSuF88PXCm8VPfhn2h9dsFxOlmXNj Hqtf8x0xAtjSDX+mNjlSoT/Qx7Z+ciSC4vTy2Y/M= Date: Tue, 26 Sep 2023 11:13:52 +0200 From: Greg Kroah-Hartman To: Stefan Wahren Cc: Umang Jain , Florian Fainelli , Dan Carpenter , Phil Elwell , Dave Stevenson , Kieran Bingham , Laurent Pinchart , linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: Re: [PATCH RFC] staging: vchiq_arm: move state dump to debugfs Message-ID: <2023092638-tacky-although-65ef@gregkh> References: <20230923235325.14329-1-wahrenst@gmx.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230923235325.14329-1-wahrenst@gmx.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230926_021401_966350_46DDC8A1 X-CRM114-Status: GOOD ( 16.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Sep 24, 2023 at 01:53:25AM +0200, Stefan Wahren wrote: > Besides the IOCTL interface the VCHIQ character device also provides > a state dump of the whole VCHIQ driver via read. Moving the state dump > function to debugfs has a lot advantages: > > - following changes on state dump doesn't break userspace ABI > - debug doesn't depend on VCHIQ_CDEV > - dump code simplifies a lot and reduce the chance of buffer overflows > > Signed-off-by: Stefan Wahren > --- > > Hello, > > since recent discussion raised the question about the future of debugfs > for vchiq [1], i want to submit this cleanup patch as part of the > discussion. The patch itself based on the latest series [2] of > Umang Jain to convert VCHIQ into a bus. I'm aware of the checkpatch > warnings which will be fixed in the next version, but not revelant > to the discussion. Looks good to me, thanks for moving this to debugfs. greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel