* [PATCH] media: sunxi: a83-mips-csi2: also select GENERIC_PHY
@ 2023-09-27 4:04 Randy Dunlap
2023-09-27 10:48 ` Sakari Ailus
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2023-09-27 4:04 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, kernel test robot, Arnd Bergmann, Sakari Ailus,
Mauro Carvalho Chehab, linux-media, Chen-Yu Tsai, Jernej Skrabec,
Samuel Holland, linux-arm-kernel, linux-sunxi
When selecting GENERIC_PHY_MIPI_DPHY, also select GENERIC_PHY to
prevent kconfig warnings:
WARNING: unmet direct dependencies detected for GENERIC_PHY_MIPI_DPHY
Depends on [n]: GENERIC_PHY [=n]
Selected by [y]:
- VIDEO_SUN8I_A83T_MIPI_CSI2 [=y] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && VIDEO_DEV [=y] && (ARCH_SUNXI || COMPILE_TEST [=y]) && PM [=y] && COMMON_CLK [=y] && RESET_CONTROLLER [=y]
Fixes: 94d7fd9692b5 ("media: sunxi: Depend on GENERIC_PHY_MIPI_DPHY")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Closes: lore.kernel.org/r/ZQ/WS8HC1A3F0Qn8@rli9-mobl
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Samuel Holland <samuel@sholland.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-sunxi@lists.linux.dev
---
drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff -- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
--- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
+++ b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
@@ -8,6 +8,7 @@ config VIDEO_SUN8I_A83T_MIPI_CSI2
select VIDEO_V4L2_SUBDEV_API
select V4L2_FWNODE
select REGMAP_MMIO
+ select GENERIC_PHY
select GENERIC_PHY_MIPI_DPHY
help
Support for the Allwinner A83T MIPI CSI-2 controller and D-PHY.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] media: sunxi: a83-mips-csi2: also select GENERIC_PHY
2023-09-27 4:04 [PATCH] media: sunxi: a83-mips-csi2: also select GENERIC_PHY Randy Dunlap
@ 2023-09-27 10:48 ` Sakari Ailus
2023-10-01 2:20 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Sakari Ailus @ 2023-09-27 10:48 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, kernel test robot, Arnd Bergmann,
Mauro Carvalho Chehab, linux-media, Chen-Yu Tsai, Jernej Skrabec,
Samuel Holland, linux-arm-kernel, linux-sunxi
Hi Randy,
Thanks for the patch.
On Tue, Sep 26, 2023 at 09:04:38PM -0700, Randy Dunlap wrote:
> When selecting GENERIC_PHY_MIPI_DPHY, also select GENERIC_PHY to
> prevent kconfig warnings:
>
> WARNING: unmet direct dependencies detected for GENERIC_PHY_MIPI_DPHY
> Depends on [n]: GENERIC_PHY [=n]
> Selected by [y]:
> - VIDEO_SUN8I_A83T_MIPI_CSI2 [=y] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && VIDEO_DEV [=y] && (ARCH_SUNXI || COMPILE_TEST [=y]) && PM [=y] && COMMON_CLK [=y] && RESET_CONTROLLER [=y]
>
> Fixes: 94d7fd9692b5 ("media: sunxi: Depend on GENERIC_PHY_MIPI_DPHY")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: lore.kernel.org/r/ZQ/WS8HC1A3F0Qn8@rli9-mobl
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: linux-media@vger.kernel.org
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> Cc: Samuel Holland <samuel@sholland.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-sunxi@lists.linux.dev
> ---
> drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
> --- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
> +++ b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
> @@ -8,6 +8,7 @@ config VIDEO_SUN8I_A83T_MIPI_CSI2
> select VIDEO_V4L2_SUBDEV_API
> select V4L2_FWNODE
> select REGMAP_MMIO
> + select GENERIC_PHY
Could GENERIC_PHY_MIPI_DPHY select GENERIC_PHY instead of depending it?
There seem to be a few other drivers that appear to have the same issue.
> select GENERIC_PHY_MIPI_DPHY
> help
> Support for the Allwinner A83T MIPI CSI-2 controller and D-PHY.
--
Regards,
Sakari Ailus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] media: sunxi: a83-mips-csi2: also select GENERIC_PHY
2023-09-27 10:48 ` Sakari Ailus
@ 2023-10-01 2:20 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2023-10-01 2:20 UTC (permalink / raw)
To: Sakari Ailus
Cc: linux-kernel, kernel test robot, Arnd Bergmann,
Mauro Carvalho Chehab, linux-media, Chen-Yu Tsai, Jernej Skrabec,
Samuel Holland, linux-arm-kernel, linux-sunxi, Vinod Koul,
Kishon Vijay Abraham I, linux-phy
On 9/27/23 03:48, Sakari Ailus wrote:
> Hi Randy,
>
> Thanks for the patch.
>
> On Tue, Sep 26, 2023 at 09:04:38PM -0700, Randy Dunlap wrote:
>> When selecting GENERIC_PHY_MIPI_DPHY, also select GENERIC_PHY to
>> prevent kconfig warnings:
>>
>> WARNING: unmet direct dependencies detected for GENERIC_PHY_MIPI_DPHY
>> Depends on [n]: GENERIC_PHY [=n]
>> Selected by [y]:
>> - VIDEO_SUN8I_A83T_MIPI_CSI2 [=y] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && VIDEO_DEV [=y] && (ARCH_SUNXI || COMPILE_TEST [=y]) && PM [=y] && COMMON_CLK [=y] && RESET_CONTROLLER [=y]
>>
>> Fixes: 94d7fd9692b5 ("media: sunxi: Depend on GENERIC_PHY_MIPI_DPHY")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: lore.kernel.org/r/ZQ/WS8HC1A3F0Qn8@rli9-mobl
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
>> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
>> Cc: linux-media@vger.kernel.org
>> Cc: Chen-Yu Tsai <wens@csie.org>
>> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
>> Cc: Samuel Holland <samuel@sholland.org>
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: linux-sunxi@lists.linux.dev
>> ---
>> drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff -- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
>> --- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
>> +++ b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
>> @@ -8,6 +8,7 @@ config VIDEO_SUN8I_A83T_MIPI_CSI2
>> select VIDEO_V4L2_SUBDEV_API
>> select V4L2_FWNODE
>> select REGMAP_MMIO
>> + select GENERIC_PHY
>
> Could GENERIC_PHY_MIPI_DPHY select GENERIC_PHY instead of depending it?
Yes, I don't see why not. Let's see what the PHY framework people have to say about it.
Vinod, Kishon, do you see any reason that GENERIC_PHY_MIPI_DPHY could not select
GENERIC_PHY instead of depending on it?
> There seem to be a few other drivers that appear to have the same issue.
Yes, I see 4 others that have the same issue.
>> select GENERIC_PHY_MIPI_DPHY
>> help
>> Support for the Allwinner A83T MIPI CSI-2 controller and D-PHY.
>
~Randy
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-01 2:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-27 4:04 [PATCH] media: sunxi: a83-mips-csi2: also select GENERIC_PHY Randy Dunlap
2023-09-27 10:48 ` Sakari Ailus
2023-10-01 2:20 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).