From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8D60E810CB for ; Wed, 27 Sep 2023 11:04:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ktmak8tI+HkcKXzUCT7ZngTrRlhB8QIdyfgCLjP/0Qo=; b=eKVkUKGq/d3Wl7 d5yhqNHF80FyMnsJCdi1+lwVenFiz4wuF/zZm5unRw5Ws19vNbKAp7RrQLGJ9gf/Im7x7T4xMFlt+ W6fwYVisLA68x2F+Cl82DnuldDZwmhU2bCc1dbd4ICjIkeUZEdCE7fBRHR9LUkxwVZDDNjn0UjCeD snO/pcXi/9x93BWNAGrpjtbry47bLSNCTZnIQ+zvFJqdhioDfrw1GGleY7asJ7gz5HyuWWLJGluYr dxAxRVsM/vfgQihW9NewEcoU9NnHOju3atWd8x7w2ME17rhl9i10brsOUM0A5DA72l+S1/iK7XhcL jful/kjoUjkZQgK//3LQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qlSKk-000m8e-1A; Wed, 27 Sep 2023 11:03:58 +0000 Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qlSKh-000m7H-0q for linux-arm-kernel@lists.infradead.org; Wed, 27 Sep 2023 11:03:57 +0000 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 38RAqtcH007388; Wed, 27 Sep 2023 13:03:21 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=selector1; bh=7yB8NpWtK7dweb2CR9jUC ltaouL0nwx9ysquf7k9XsU=; b=6MqffwuzRrn1OHJG57ZKwmRGL7DSWZNV0eqiA RW5LVYc4K10Avm+4T0WRZ266snMYvpY29q3RyyisXXHugzrt5z3834lRld5qNTqb vD1BcP4hWKj3A9aNo9JuT3MPsRzb2DpOO7kgSFxxD6zd+6A4k8g3fSdrUxBGoEdo n3OKi7kXLuBSSMWAOLJIGMzlmYMQhuYWPVO2aDFDbdtj/hEed1djI67C7QjPXe1E YLHDkM+7lM69cmYKd5E0BgP33kyDy8fMgmfo62xvfVja1yYetDAh20ncaA8x2WZm xBJfD8USXkIe90IRKzDWBsWaJfADp2qFdwtlOMFpzjUFLhYKQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3t9pwd9thf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Sep 2023 13:03:21 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id E8259100058; Wed, 27 Sep 2023 13:03:19 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id D736C217B6C; Wed, 27 Sep 2023 13:03:19 +0200 (CEST) Received: from gnbcxd0016.gnb.st.com (10.129.178.213) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 27 Sep 2023 13:03:19 +0200 Date: Wed, 27 Sep 2023 13:03:11 +0200 From: Alain Volmat To: Laurent Pinchart CC: Hugues Fruchet , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Russell King , Philipp Zabel , Sakari Ailus , Dan Scally , , , , , Subject: Re: [PATCH v3 4/5] ARM: dts: stm32: add dcmipp support to stm32mp135 Message-ID: <20230927110311.GA834168@gnbcxd0016.gnb.st.com> Mail-Followup-To: Laurent Pinchart , Hugues Fruchet , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Russell King , Philipp Zabel , Sakari Ailus , Dan Scally , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230901155732.252436-1-alain.volmat@foss.st.com> <20230901155732.252436-5-alain.volmat@foss.st.com> <20230905090258.GC31594@pendragon.ideasonboard.com> <20230922160227.GA608616@gnbcxd0016.gnb.st.com> <20230922160818.GJ19112@pendragon.ideasonboard.com> <20230925113542.GA646870@gnbcxd0016.gnb.st.com> <20230925114332.GC8583@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230925114332.GC8583@pendragon.ideasonboard.com> X-Disclaimer: ce message est personnel / this message is private X-Originating-IP: [10.129.178.213] X-ClientProxiedBy: SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-09-27_06,2023-09-27_01,2023-05-22_02 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230927_040355_598207_0E444E83 X-CRM114-Status: GOOD ( 39.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Laurent, On Mon, Sep 25, 2023 at 02:43:32PM +0300, Laurent Pinchart wrote: > On Mon, Sep 25, 2023 at 01:35:42PM +0200, Alain Volmat wrote: > > On Fri, Sep 22, 2023 at 07:08:18PM +0300, Laurent Pinchart wrote: > > > On Fri, Sep 22, 2023 at 06:02:27PM +0200, Alain Volmat wrote: > > > > On Tue, Sep 05, 2023 at 12:02:58PM +0300, Laurent Pinchart wrote: > > > > > On Fri, Sep 01, 2023 at 05:57:23PM +0200, Alain Volmat wrote: > > > > > > From: Hugues Fruchet > > > > > > > > > > > > Add dcmipp support to STM32MP135. > > > > > > > > > > > > Signed-off-by: Hugues Fruchet > > > > > > Signed-off-by: Alain Volmat > > > > > > --- > > > > > > arch/arm/boot/dts/st/stm32mp135.dtsi | 8 ++++++++ > > > > > > 1 file changed, 8 insertions(+) > > > > > > > > > > > > diff --git a/arch/arm/boot/dts/st/stm32mp135.dtsi b/arch/arm/boot/dts/st/stm32mp135.dtsi > > > > > > index abf2acd37b4e..beee9ec7ed0d 100644 > > > > > > --- a/arch/arm/boot/dts/st/stm32mp135.dtsi > > > > > > +++ b/arch/arm/boot/dts/st/stm32mp135.dtsi > > > > > > @@ -8,5 +8,13 @@ > > > > > > > > > > > > / { > > > > > > soc { > > > > > > + dcmipp: dcmipp@5a000000 { > > > > > > + compatible = "st,stm32mp13-dcmipp"; > > > > > > + reg = <0x5a000000 0x400>; > > > > > > + interrupts = ; > > > > > > + resets = <&rcc DCMIPP_R>; > > > > > > + clocks = <&rcc DCMIPP_K>; > > > > > > + status = "disabled"; > > > > > > > > > > This needs a port, as it's marked as required in the bindings. You can > > > > > leave the endpoint out. > > > > > > > > I first agreed with your comment but, having done the check (make > > > > CHECK_DTBS=y ...) this doesn't seem to be required because the dcmipp > > > > node is kept disabled within our dtsi. > > > > > > Interesting. > > > > > > > (it is later on only enabled in dts file which as well have the port > > > > property). > > > > Indeed, to check this I changed it to okay and DTC_CHK complained about > > > > missing port property. > > > > > > > > Hence, I'd think that port doesn't have to be added in this dtsi file. > > > > Would you agree with that ? > > > > > > I still think the port belongs here, as it's an intrinsic property of > > > the dcmipp, not a property of the board. Does it cause any issue to add > > > a port in the .dtsi ? > > > > I agree that the port refers more to the SoC (hence dtsi) rather than > > the board (hence dts), however I am wondering if this is really > > something usually done. I had a look at other dtsi with node related > > to similar kind of devices and it seems to me that there is no such case > > of a dtsi with a port having nothing in it. Did I missed something ? > > Look at the csi@32e4000 and csi@32e5000 nodes in > arch/arm64/boot/dts/freescale/imx8mp.dtsi for instance. There are quite > a few other examples. Ok, thanks for pointer. Understood, I add an empty port child within the node. I've also covered the points of your review of the v3 and post now the v4. > > > > > > With this fixed, > > > > > > > > > > Reviewed-by: Laurent Pinchart > > > > > > > > > > > + }; > > > > > > }; > > > > > > }; > > -- > Regards, > > Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel