* Re: [PATCH v3 1/1] PCI: layerscape-ep: set 64-bit DMA mask
2023-09-26 14:04 [PATCH v3 1/1] PCI: layerscape-ep: set 64-bit DMA mask Frank Li
@ 2023-09-27 9:26 ` Christoph Hellwig
2023-09-27 12:46 ` Manivannan Sadhasivam
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Christoph Hellwig @ 2023-09-27 9:26 UTC (permalink / raw)
To: Frank Li
Cc: hch, bhelgaas, christophe.jaillet, imx, kw, linux-arm-kernel,
linux-kernel, linux-pci, linuxppc-dev, lpieralisi, minghuan.Lian,
mingkai.hu, robh, roy.zang
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v3 1/1] PCI: layerscape-ep: set 64-bit DMA mask
2023-09-26 14:04 [PATCH v3 1/1] PCI: layerscape-ep: set 64-bit DMA mask Frank Li
2023-09-27 9:26 ` Christoph Hellwig
@ 2023-09-27 12:46 ` Manivannan Sadhasivam
2023-10-10 14:18 ` Frank Li
2023-09-27 13:25 ` Roy Zang
2023-10-10 15:44 ` Lorenzo Pieralisi
3 siblings, 1 reply; 7+ messages in thread
From: Manivannan Sadhasivam @ 2023-09-27 12:46 UTC (permalink / raw)
To: Frank Li
Cc: hch, bhelgaas, christophe.jaillet, imx, kw, linux-arm-kernel,
linux-kernel, linux-pci, linuxppc-dev, lpieralisi, minghuan.Lian,
mingkai.hu, robh, roy.zang
On Tue, Sep 26, 2023 at 10:04:45AM -0400, Frank Li wrote:
> From: Guanhua Gao <guanhua.gao@nxp.com>
>
> Set DMA mask and coherent DMA mask to enable 64-bit addressing.
>
> Signed-off-by: Guanhua Gao <guanhua.gao@nxp.com>
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
- Mani
> ---
>
> Notes:
> change from v2 to v3
> - remove check return value of dma_set_mask_and_coherent. 64bit mask always
> return success.
> - remove redundate comments
> change from v1 to v2
> - Remove 32bit DMA mask set.
>
> drivers/pci/controller/dwc/pci-layerscape-ep.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> index de4c1758a6c3..2c2c9aaa8700 100644
> --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> @@ -249,6 +249,8 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)
>
> pcie->big_endian = of_property_read_bool(dev->of_node, "big-endian");
>
> + dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
> +
> platform_set_drvdata(pdev, pcie);
>
> ret = dw_pcie_ep_init(&pci->ep);
> --
> 2.34.1
>
--
மணிவண்ணன் சதாசிவம்
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 1/1] PCI: layerscape-ep: set 64-bit DMA mask
2023-09-27 12:46 ` Manivannan Sadhasivam
@ 2023-10-10 14:18 ` Frank Li
0 siblings, 0 replies; 7+ messages in thread
From: Frank Li @ 2023-10-10 14:18 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: hch, bhelgaas, christophe.jaillet, imx, kw, linux-arm-kernel,
linux-kernel, linux-pci, linuxppc-dev, lpieralisi, minghuan.Lian,
mingkai.hu, robh, roy.zang
On Wed, Sep 27, 2023 at 02:46:21PM +0200, Manivannan Sadhasivam wrote:
> On Tue, Sep 26, 2023 at 10:04:45AM -0400, Frank Li wrote:
> > From: Guanhua Gao <guanhua.gao@nxp.com>
> >
> > Set DMA mask and coherent DMA mask to enable 64-bit addressing.
> >
> > Signed-off-by: Guanhua Gao <guanhua.gao@nxp.com>
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
>
> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
@Lorenzo
Could you please consider pick this patch?
Manivannan already reviewed and only impact layerscape.
Frank
>
> - Mani
>
> > ---
> >
> > Notes:
> > change from v2 to v3
> > - remove check return value of dma_set_mask_and_coherent. 64bit mask always
> > return success.
> > - remove redundate comments
> > change from v1 to v2
> > - Remove 32bit DMA mask set.
> >
> > drivers/pci/controller/dwc/pci-layerscape-ep.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > index de4c1758a6c3..2c2c9aaa8700 100644
> > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > @@ -249,6 +249,8 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)
> >
> > pcie->big_endian = of_property_read_bool(dev->of_node, "big-endian");
> >
> > + dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
> > +
> > platform_set_drvdata(pdev, pcie);
> >
> > ret = dw_pcie_ep_init(&pci->ep);
> > --
> > 2.34.1
> >
>
> --
> மணிவண்ணன் சதாசிவம்
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v3 1/1] PCI: layerscape-ep: set 64-bit DMA mask
2023-09-26 14:04 [PATCH v3 1/1] PCI: layerscape-ep: set 64-bit DMA mask Frank Li
2023-09-27 9:26 ` Christoph Hellwig
2023-09-27 12:46 ` Manivannan Sadhasivam
@ 2023-09-27 13:25 ` Roy Zang
2023-10-10 15:44 ` Lorenzo Pieralisi
3 siblings, 0 replies; 7+ messages in thread
From: Roy Zang @ 2023-09-27 13:25 UTC (permalink / raw)
To: Frank Li, hch@infradead.org
Cc: bhelgaas@google.com, christophe.jaillet@wanadoo.fr,
imx@lists.linux.dev, kw@linux.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, lpieralisi@kernel.org, M.H. Lian,
Mingkai Hu, robh@kernel.org
> -----Original Message-----
> From: Frank Li <frank.li@nxp.com>
> Sent: Tuesday, September 26, 2023 9:05 AM
> From: Guanhua Gao <guanhua.gao@nxp.com>
>
> Set DMA mask and coherent DMA mask to enable 64-bit addressing.
>
> Signed-off-by: Guanhua Gao <guanhua.gao@nxp.com>
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>
> Notes:
> change from v2 to v3
> - remove check return value of dma_set_mask_and_coherent. 64bit mask
> always
> return success.
> - remove redundate comments
> change from v1 to v2
> - Remove 32bit DMA mask set.
>
> drivers/pci/controller/dwc/pci-layerscape-ep.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> index de4c1758a6c3..2c2c9aaa8700 100644
> --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> @@ -249,6 +249,8 @@ static int __init ls_pcie_ep_probe(struct
> platform_device *pdev)
>
> pcie->big_endian = of_property_read_bool(dev->of_node, "big-
> endian");
>
> + dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
> +
Acked-by: Roy Zang <Roy.Zang@nxp.com>
-R
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 1/1] PCI: layerscape-ep: set 64-bit DMA mask
2023-09-26 14:04 [PATCH v3 1/1] PCI: layerscape-ep: set 64-bit DMA mask Frank Li
` (2 preceding siblings ...)
2023-09-27 13:25 ` Roy Zang
@ 2023-10-10 15:44 ` Lorenzo Pieralisi
2023-10-10 16:02 ` Frank Li
3 siblings, 1 reply; 7+ messages in thread
From: Lorenzo Pieralisi @ 2023-10-10 15:44 UTC (permalink / raw)
To: hch, Frank Li
Cc: Lorenzo Pieralisi, bhelgaas, christophe.jaillet, imx, kw,
linux-arm-kernel, linux-kernel, linux-pci, linuxppc-dev,
minghuan.Lian, mingkai.hu, robh, roy.zang
On Tue, 26 Sep 2023 10:04:45 -0400, Frank Li wrote:
> Set DMA mask and coherent DMA mask to enable 64-bit addressing.
>
>
Read this:
https://lore.kernel.org/linux-pci/20171026223701.GA25649@bhelgaas-glaptop.roam.corp.google.com
Find the issue with the commit log (that I fixed).
This does not apply to v6.6-rc1 so I tweaked it,
check that everything is OK please.
Applied to controller/layerscape, thanks!
[1/1] PCI: layerscape-ep: set 64-bit DMA mask
https://git.kernel.org/pci/pci/c/81ef01bc5934
Thanks,
Lorenzo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v3 1/1] PCI: layerscape-ep: set 64-bit DMA mask
2023-10-10 15:44 ` Lorenzo Pieralisi
@ 2023-10-10 16:02 ` Frank Li
0 siblings, 0 replies; 7+ messages in thread
From: Frank Li @ 2023-10-10 16:02 UTC (permalink / raw)
To: Lorenzo Pieralisi
Cc: hch, bhelgaas, christophe.jaillet, imx, kw, linux-arm-kernel,
linux-kernel, linux-pci, linuxppc-dev, minghuan.Lian, mingkai.hu,
robh, roy.zang
On Tue, Oct 10, 2023 at 05:44:23PM +0200, Lorenzo Pieralisi wrote:
> On Tue, 26 Sep 2023 10:04:45 -0400, Frank Li wrote:
> > Set DMA mask and coherent DMA mask to enable 64-bit addressing.
> >
> >
>
> Read this:
> https://lore.kernel.org/linux-pci/20171026223701.GA25649@bhelgaas-glaptop.roam.corp.google.com
>
> Find the issue with the commit log (that I fixed).
Do you means "set" should be "Set"?
Frank
>
> This does not apply to v6.6-rc1 so I tweaked it,
> check that everything is OK please.
>
> Applied to controller/layerscape, thanks!
Thanks, everthing is good!
>
> [1/1] PCI: layerscape-ep: set 64-bit DMA mask
> https://git.kernel.org/pci/pci/c/81ef01bc5934
>
> Thanks,
> Lorenzo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread