From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A6DEE732FE for ; Thu, 28 Sep 2023 17:18:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m/pLpwwqeOLnxvwWBYLeoiSLPt8MNsJ8MlKVuxCQxB0=; b=UCZ/LwBWpF6do4qp3cdfE1cwue O96TRHEL39XTIlGDQgdIrfbseM7lAecxGi8lxe1Mg14poglEfCMsdwdeChZOvUCdCDhj/KGdZx08I +0apCT2WxC6Pfbg1xWxk+Rr9WbGQmSchAqY/fxg//GG1zOaQP0J11W+OpFt9c6hjC8+bpR7sv6FmB OAIHDSxQlL1ZZVQvgsX9COfKFp2KpWZCyEMA4leSyRR9n8oJZAa58+cK+kbuqaClqGBfhrx8wQmDe XJmnHEA0yCQ0lWgLS7JG0kGPs64YycinrjoycalArJTIVKNjdDoUABHHB6+J4lBodqx3Kj6pVw9r1 fI2MvORw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qludr-006Pfn-1u; Thu, 28 Sep 2023 17:17:35 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qludo-006Pez-25 for linux-arm-kernel@lists.infradead.org; Thu, 28 Sep 2023 17:17:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id EFD7AB81DDD; Thu, 28 Sep 2023 17:17:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C6DCC433C8; Thu, 28 Sep 2023 17:17:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695921449; bh=kp48/6NY2s2Fwy7SPTbkm1Qxejl2zfg3J9xsj/VLKl4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=frwM8cmwFgXPPt6PQw33IXpDzfdefGVZdi/irC1N2cQJEBvz17+e9WaCpC6UKZCKq S+yHTjowoARHIOm0Gaizj5BqYC/eUFb994s7vYCM/NvFo3hFiyR1flVnlv3AWtZAp2 sdyfP3XMlm+nSwtbyXHiqArvrmdFERQpF2CJeVxwt4RCzIFVTj9Cmza/unomjPzsDo t7fwMaJW8dhoh9YZCQjN3GstiXyrkWfTsSd23eSkvxEHnJnNkt7j6lmMt1iKvcM4/B KHUIfbPYBM2nxM1X62LiBWFOOTl9ZiEGW6KR7opg7xwwndszH8Yl2SIyg7NdAabq74 ahJxwYu5Iomew== Date: Thu, 28 Sep 2023 18:17:23 +0100 From: Conor Dooley To: Christophe Roullier Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Jose Abreu , Liam Girdwood , Mark Brown , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 02/12] dt-bindings: net: add new property st,ext-phyclk in documentation for stm32 Message-ID: <20230928-ruse-parsnip-ce691bd4d0c9@spud> References: <20230928151512.322016-1-christophe.roullier@foss.st.com> <20230928151512.322016-3-christophe.roullier@foss.st.com> MIME-Version: 1.0 In-Reply-To: <20230928151512.322016-3-christophe.roullier@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230928_101732_962093_90E790A6 X-CRM114-Status: GOOD ( 24.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1666575347913196827==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1666575347913196827== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GZ6Z6SVMMl7xgZNo" Content-Disposition: inline --GZ6Z6SVMMl7xgZNo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 28, 2023 at 05:15:02PM +0200, Christophe Roullier wrote: > Add property st,ext-phyclk to manage cases when PHY have no cristal/quartz > This property can be used with RMII phy without cristal 50Mhz and when we > want to select RCC clock instead of ETH_REF_CLK > Can be used also with RGMII phy with no cristal and we select RCC clock > instead of ETH_CLK125 > This new property replace st,eth-clk-sel and st,eth-ref-clk-sel I don't really see a response to Rob's comment on v2, either here or in a reply to his email on v2: | Certainly 1 property is better than 2 for me, but carrying 3 is not | great. I don't understand why the we need a new property. What can't be | supported with the existing properties? A sentence saying explaining exactly what the old properties do not support that this one does, would be very helpful. Thanks, Conor. >=20 > Signed-off-by: Christophe Roullier > --- > Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml b/Doc= umentation/devicetree/bindings/net/stm32-dwmac.yaml > index ca976281bfc22..67840cab02d2d 100644 > --- a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml > @@ -78,12 +78,21 @@ properties: > encompases the glue register, the offset of the control register a= nd > the mask to set bitfield in control register > =20 > + st,ext-phyclk: > + description: > + set this property in RMII mode when you have PHY without crystal 5= 0MHz and want to > + select RCC clock instead of ETH_REF_CLK. or in RGMII mode when you= want to select > + RCC clock instead of ETH_CLK125. > + type: boolean > + > st,eth-clk-sel: > + deprecated: true > description: > set this property in RGMII PHY when you want to select RCC clock i= nstead of ETH_CLK125. > type: boolean > =20 > st,eth-ref-clk-sel: > + deprecated: true > description: > set this property in RMII mode when you have PHY without crystal 5= 0MHz and want to > select RCC clock instead of ETH_REF_CLK. > --=20 > 2.25.1 >=20 --GZ6Z6SVMMl7xgZNo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZRW1IwAKCRB4tDGHoIJi 0rNRAP9awNrP3aiGsCbGuiS8lMmRYwhVF+LyYev2PPrjoiD9mwD/XczIb1gqXTpN dTxeIbKTupCl7S7dTc2C+xJDpScgrA8= =YoXR -----END PGP SIGNATURE----- --GZ6Z6SVMMl7xgZNo-- --===============1666575347913196827== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1666575347913196827==--